-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused 3rd argument in assert.strictEqual() #22113
Remove unused 3rd argument in assert.strictEqual() #22113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to lib/assert.js introduces a breaking change to a public API. lib/assert.js should not be changed in this PR.
The change to the test is good.
c71cacc
to
c188ca0
Compare
PR updated |
Hey all, I've updated my PR
בתאריך שבת, 4 באוג׳ 2018 ב-20:31 מאת Colin Ihrig <
notifications@github.com>:
… ***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22113 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AgaT7R2XRmesq3Op0ydmB8IWAdEfUKi6ks5uNdqJgaJpZM4Vuo9T>
.
|
Let's merge? |
PR-URL: nodejs#22113 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Landed in 1284fa2. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: #22113 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Line 9 contains a call to assert.strictEqual(). It has a string literal as the third argument. Unfortunately, that means that if there is an AssertionError, the value of status (the first argument) will not be reported. The third argument here is not adding any value (and in fact is reporting the wrong thing in the event of an AssertionError) so removed it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes