lib: extract validateNumber validator #22249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls out another common argument validator to `internal/validators`
nodejs-github-bot
added
the
lib / src
bengl
approved these changes
Aug 10, 2018
richardlau
approved these changes
Aug 10, 2018
jasnell
approved these changes
Aug 10, 2018
cjihrig
approved these changes
Aug 11, 2018
trivikr
approved these changes
Aug 12, 2018
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16378/ |
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16437/ |
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16440/ |
|
Re node-test-commit-linux failures, |
|
Landed in 3e44b8c |
maclover7
added a commit
that referenced
this pull request
Aug 14, 2018
Pulls out another common argument validator to `internal/validators` PR-URL: #22249 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Should this be backported to |
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
Pulls out another common argument validator to `internal/validators` PR-URL: #22249 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Pulls out another common argument validator to `internal/validators` PR-URL: #22249 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Pulls out another common argument validator to `internal/validators` PR-URL: #22249 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out another common argument validator to
internal/validatorsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes