build: use echo command instead of shell comments #22293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
jasnell
approved these changes
Aug 13, 2018
lpinca
reviewed
Aug 13, 2018
Makefile
Outdated
| $(MAKE) -s build-addons | ||
| $(MAKE) -s build-addons-napi | ||
| $(MAKE) -s cctest | ||
| $(MAKE) -s jstest | ||
|
|
||
| .PHONY: test-only | ||
| test-only: all ## For a quick test, does not run linter or build docs. | ||
| # Build the addons before running the tests so the test results | ||
| # can be displayed together | ||
| $(MAKE) build-addons |
There was a problem hiding this comment.
No, that was a mistake 😞 Thanks for catching that. I'll update shortly.
maclover7
approved these changes
Aug 14, 2018
maclover7
added
the
author ready
Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach used in other recipes in the makefile.
danbev
force-pushed
the
build_comments_to_echo
branch
from
d7ebe84
to
c1d2e7e
Compare
|
Rerun of failing node-test-commit-freebsd ✅ |
|
Landed in 6bc43ae. |
danbev
added a commit
that referenced
this pull request
Aug 20, 2018
Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach used in other recipes in the makefile. PR-URL: #22293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Aug 21, 2018
Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach used in other recipes in the makefile. PR-URL: #22293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Currently, there are a few recipes where comments are indented and being passed to the shell. This commit updates these comments to use the echo command instead, which is the more common approach used in other recipes in the makefile. PR-URL: #22293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are a few recipes where comments are indented
and being passed to the shell.
This commit updates these comments to use the echo command instead,
which is the more common approach used in other recipes in the
makefile.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes