-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: bump icu version to avoid confusion #22313
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icu has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion.
vsemozhetbyt
approved these changes
Aug 14, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
benjamingr
approved these changes
Aug 14, 2018
gdams
approved these changes
Aug 14, 2018
gdams
approved these changes
Aug 14, 2018
trivikr
approved these changes
Aug 14, 2018
jasnell
approved these changes
Aug 14, 2018
Landed in 85f7ae4 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Aug 14, 2018
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: #22313 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
ICU has been on 6X for a while but example file name in Intl docs still refers to it as 5X. It might be a small thing but I think it's good to update this to avoid confusion. PR-URL: #22313 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
i18n-api
Issues and PRs related to the i18n implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist