Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: move process.binding('http2') to internalBinding #22328

Closed
wants to merge 1 commit into from
Closed

http2: move process.binding('http2') to internalBinding #22328

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 14, 2018

Refs: #22160

The http2 module is still experimental.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. http2 Issues or PRs related to the http2 subsystem. labels Aug 14, 2018
@nodejs-github-bot
Copy link
Collaborator

@jasnell sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 14, 2018
@jasnell jasnell mentioned this pull request Aug 14, 2018
Closed
33 tasks
@jasnell
Copy link
Member Author

jasnell commented Aug 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16472/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2018
@jasnell
Copy link
Member Author

jasnell commented Aug 17, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/16515/

@joyeecheung joyeecheung mentioned this pull request Aug 17, 2018
Closed
@Trott
Copy link
Member

Trott commented Aug 18, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16528/

@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/16534/

@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/16539/

@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16545/

jasnell added a commit that referenced this pull request Aug 18, 2018
@jasnell
http2: move process.binding('http2') to internalBinding
4fa5448 
Refs: #22160

PR-URL: #22328
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 18, 2018

Landed in 4fa5448

@jasnell jasnell closed this Aug 18, 2018
@joyeecheung joyeecheung mentioned this pull request Aug 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@devsnek devsnek devsnek approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jasnell @nodejs-github-bot @Trott @cjihrig @joyeecheung @devsnek @BridgeAR @trivikr