-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_parser: move process.binding('http_parser') to internalBinding #22329
Conversation
@jasnell sadly an error occured when I tried to trigger a build :( |
one interesting thing here is that people override |
Yep, this one is definitely going to need the fallthrough support #22269 once I get that landed and we will need to be careful about fully deprecating this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits
const hooks = initHooks(); | ||
hooks.enable(); | ||
|
||
// The hooks.enable() must come before require('interna/test/binding') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: interna --> internal
|
||
hooks.enable(); | ||
|
||
// The hooks.enable() must come before require('interna/test/binding') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
ccb4aba
to
381cb2a
Compare
ping @nodejs/tsc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I prefer not to move the other functions inside of the main function. Instead, it should be possible to pass through the arguments and it's likely less churn that way.
dd2785a
to
2a25ea1
Compare
Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/16538/ |
Unrelated failure in CI...again... https://ci.nodejs.org/job/node-test-pull-request/16543/ |
Finally good CI. @nodejs/tsc ... PTAL |
Refs: #22160 PR-URL: #22329 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Landed in 1744205 |
Was this ever somehow addressed? Currently facing issue in #22064 (comment) |
Refs: #22160
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes