test: harden sequential/test-performance #22404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) This adds a better error logging so we are able to address further failures easier. 2) It adds a extra epsilon so the test runs into less issues in case the machine is under heavy load. 3) The epsilon in increased if the CPU is under heavy load. 4) The total startup epsilon was reduced due to recent startup time improvements.
|
@nodejs/testing PTAL |
jasnell
approved these changes
Aug 19, 2018
BridgeAR
added
the
author ready
joyeecheung
approved these changes
Aug 20, 2018
|
Unrelated failure. Resume build: https://ci.nodejs.org/job/node-test-pull-request/16587/ Failures in job https://ci.nodejs.org/job/node-test-pull-request/16579/ COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3See failures on test-rackspace-win2008r2-x64-5: |
|
Windows builds cannot be resumed. New one: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20100/ ✔️ |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 22, 2018
1) This adds a better error logging so we are able to address further failures easier. 2) It adds a extra epsilon so the test runs into less issues in case the machine is under heavy load. 3) The epsilon in increased if the CPU is under heavy load. 4) The total startup epsilon was reduced due to recent startup time improvements. PR-URL: nodejs#22404 Fixes: nodejs#19197 Refs: nodejs/reliability#14 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in c35ce56 🎉 |
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
1) This adds a better error logging so we are able to address further failures easier. 2) It adds a extra epsilon so the test runs into less issues in case the machine is under heavy load. 3) The epsilon in increased if the CPU is under heavy load. 4) The total startup epsilon was reduced due to recent startup time improvements. PR-URL: #22404 Fixes: #19197 Refs: nodejs/reliability#14 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
1) This adds a better error logging so we are able to address further failures easier. 2) It adds a extra epsilon so the test runs into less issues in case the machine is under heavy load. 3) The epsilon in increased if the CPU is under heavy load. 4) The total startup epsilon was reduced due to recent startup time improvements. PR-URL: #22404 Fixes: #19197 Refs: nodejs/reliability#14 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failures easier.
the machine is under heavy load.
improvements.
Fixes: #19197
Refs: nodejs/reliability#14
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes