Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: properly extend process.env in child_process #22430

Closed
wants to merge 1 commit into from
Closed

test: properly extend process.env in child_process #22430

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added: no api has changed
  • commit message follows commit guidelines

Options on child_process.spawn was not properly constructed for process.env not assigned to options.env.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 21, 2018
addaleax
addaleax approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'd be curious to hear how you figured this out -- did this cause real-world problems for you?

@addaleax addaleax added the child_process Issues and PRs related to the child_process subsystem. label Aug 21, 2018
@legendecas
Copy link
Member Author

@addaleax: I'd be curious to hear how you figured this out -- did this cause real-world problems for you?

Haha, yes, we're trying to applying node.js' test set to a node.js port (ShadowNode) for much more limited memory, and then picked out this nit on review :p

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16801/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@gdams
Copy link
Member

gdams commented Aug 28, 2018

landed in: dca2f98

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@gdams gdams closed this Aug 28, 2018
gdams pushed a commit that referenced this pull request Aug 28, 2018
@legendecas
test: properly extend process.env in child_process
dca2f98 
PR-URL: #22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Aug 28, 2018
@legendecas @addaleax
test: properly extend process.env in child_process
b058601 
PR-URL: #22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@legendecas @targos
test: properly extend process.env in child_process
d27e463 
PR-URL: #22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@legendecas @targos
test: properly extend process.env in child_process
2d8e637 
PR-URL: #22430
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@legendecas @addaleax @gdams @jasnell @cjihrig @BridgeAR @trivikr @nodejs-github-bot