doc: state callback behavior on empty buffer #22461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
mcollina
reviewed
Aug 22, 2018
doc/api/http.md
Outdated
|
|
||
| Returns `true` if the entire data was flushed successfully to the kernel | ||
| buffer. Returns `false` if all or part of the data was queued in user memory. | ||
| `'drain'` will be emitted when the buffer is free again. | ||
|
|
||
| When `write` function is called with empty string or buffer, it does | ||
| nothing and waits for more input. |
There was a problem hiding this comment.
I would keep this and the empty line afterwards.
|
The subsystem prefix for doc-only changes should be |
|
@mscdex Fixed. |
jasnell
approved these changes
Aug 22, 2018
mscdex
changed the title
BridgeAR
approved these changes
Aug 22, 2018
trivikr
approved these changes
Aug 23, 2018
lpinca
approved these changes
Aug 23, 2018
|
Please 🎉 for fast-track. |
vsemozhetbyt
approved these changes
Aug 23, 2018
vsemozhetbyt
added
fast-track
|
Landed in f7273ed |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Aug 23, 2018
PR-URL: #22461 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2018
PR-URL: #22461 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22461 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed suggestion for #22066 as requested by @mcollina.
Checklist