Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: specify ESLint rules being disabled in two files #22563

Closed
wants to merge 2 commits into from
Closed

tools: specify ESLint rules being disabled in two files #22563

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 28, 2018

Instead of disabling all ESLint rules, just disable the rules necessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the tools Issues and PRs related to the tools directory. label Aug 28, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/710/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2018
@Trott
Copy link
Member Author

Trott commented Aug 28, 2018

Can't seem to start a full CI at the moment, but perhaps the Lite CI is enough since this changes comments only, so linting is the thing to check?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 28, 2018
@Trott
Copy link
Member Author

Trott commented Aug 28, 2018

Please 👍 here for fast-tracking.

@vsemozhetbyt
Copy link
Contributor

Something wrong with CI lite (rebasing?) happens now. In this PR CI lite has a wrong commit:

https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/710/

(In this PR last CI lite had many wrong commits: #22170)

@Trott
Copy link
Member Author

Trott commented Aug 28, 2018

CI Lite re-run: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/714/pipeline

richardlau
richardlau requested changes Aug 28, 2018
View reviewed changes
test/parallel/test-assert.js
@@ -692,7 +692,7 @@ common.expectsError(
() => {
a(
(() => 'string')()
// eslint-disable-next-line
// eslint-disable-next-line operator-linebreak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the message check in L701-L712 needs to be updated to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! Fixed.

test/parallel/test-assert.js
@@ -716,7 +716,7 @@ common.expectsError(
() => {
a(
(() => 'string')()
// eslint-disable-next-line
// eslint-disable-next-line operator-linebreak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the message check in L725-L736 needs to be updated to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: Argh! Fixed.

@Trott
tools: specify rules disabled in common/dns.js
91727d3 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.
@Trott
tools: specify rule disabled in test-assert.js
26af2e5 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.
@Trott
Copy link
Member Author

Trott commented Aug 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16846/

@Trott
Copy link
Member Author

Trott commented Aug 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16892/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 31, 2018
@addaleax
Copy link
Member

Landed in c5bd856, f86d0eb

@addaleax addaleax closed this Aug 31, 2018
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@Trott @addaleax
tools: specify rules disabled in common/dns.js
c5bd856 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@Trott @addaleax
tools: specify rule disabled in test-assert.js
f86d0eb 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@Trott @addaleax
tools: specify rules disabled in common/dns.js
8235ef0 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
@Trott @addaleax
tools: specify rule disabled in test-assert.js
984a15d 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 3, 2018
@Trott @targos
tools: specify rules disabled in common/dns.js
15b7f75 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 3, 2018
@Trott @targos
tools: specify rule disabled in test-assert.js
f5520cc 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott @targos
tools: specify rules disabled in common/dns.js
b3e4a53 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2018
@Trott @targos
tools: specify rule disabled in test-assert.js
6df8426 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
Closed
Closed
@Trott Trott deleted the no-abusive-eslint-disable branch October 10, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Trott @nodejs-github-bot @vsemozhetbyt @addaleax @cjihrig @richardlau @BridgeAR @trivikr