Doc Update : BufferwriteDoubleLE/writeDoubleBE #22170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing #22158
nodejs-github-bot
added
buffer
vsemozhetbyt
approved these changes
Aug 7, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Aug 7, 2018
This comment has been minimized.
This comment has been minimized.
|
CI lite again but rebased on master which hopefully has the fix for what was causing the failures: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/469/ |
prog1dev
approved these changes
Aug 27, 2018
BridgeAR
approved these changes
Aug 27, 2018
|
Sorry, I cannot understand why CI is so weird( |
2 tasks
|
CI 😢 |
|
|
||
| buf.writeDoubleLE(0xdeadbeefcafebabe, 0); | ||
|
|
There was a problem hiding this comment.
Linter issue:
2152:1 error More than 1 blank line not allowed no-multiple-empty-lines
|
@pranshuchittora Is it convenient for you to fix linter issue? If not, we can fix it on landing. |
addaleax
approved these changes
Sep 2, 2018
|
Landed in 9f7efd5 with commit message & linter fixed, thanks for the PR! 🎉 |
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing
#22158