-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove flaky designation for test #22856
Conversation
Looks like we're now getting SIGABRT rather than SIGSEGV? Is that a step in the right direction? (I think so...) https://ci.nodejs.org/job/node-test-commit-freebsd/20477/nodes=freebsd11-x64/console 22:24:54 not ok 1905 parallel/test-trace-events-fs-sync
22:24:54 ---
22:24:54 duration_ms: 3.60
22:24:54 severity: fail
22:24:54 exitcode: 1
22:24:54 stack: |-
22:24:54 assert.js:84
22:24:54 throw new AssertionError(obj);
22:24:54 ^
22:24:54
22:24:54 AssertionError [ERR_ASSERTION]: fs.sync.stat:
22:24:54 { status: null,
22:24:54 signal: 'SIGABRT',
22:24:54 output: [ null, '', '' ],
22:24:54 pid: 99508,
22:24:54 stdout: '',
22:24:54 stderr: '' }
22:24:54 at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:139:10)
22:24:54 at Module._compile (internal/modules/cjs/loader.js:694:30)
22:24:54 at Object.Module._extensions..js (internal/modules/cjs/loader.js:705:10)
22:24:54 at Module.load (internal/modules/cjs/loader.js:604:32)
22:24:54 at tryModuleLoad (internal/modules/cjs/loader.js:543:12)
22:24:54 at Function.Module._load (internal/modules/cjs/loader.js:535:3)
22:24:54 at Function.Module.runMain (internal/modules/cjs/loader.js:747:12)
22:24:54 at startup (internal/bootstrap/node.js:270:19)
22:24:54 at bootstrapNodeJSCore (internal/bootstrap/node.js:801:3)
22:24:54 ... |
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: nodejs#22812 Ref: nodejs#21038 (comment)
merge conflict resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a node-stress-single-test, just to be sure?
Stress |
Windows stress test failed while building: 09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]
09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj] |
That seems like an infra issue - c++ compiler ran out of memory.
…On Sat, Oct 6, 2018, 10:22 AM Rich Trott ***@***.***> wrote:
Windows stress test failed while building:
09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22856 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAE0qWmfM49QYdSWtKJCdbt6UflaBsRMks5uiObFgaJpZM4WooHB>
.
|
Trying Windows again, hoping it compiles this time...: https://ci.nodejs.org/job/node-stress-single-test/2062/ |
Windows stress test compile failed again. 😞 |
Windows stress test rebuild but this time on a few different Windows variants. Hopefully if one or two fail, one or two others will successfully build and we'll see how the tests go. https://ci.nodejs.org/job/node-stress-single-test/2063/ |
That's an interesting thing to follow up on form a @nodejs/build perspective.
on https://ci.nodejs.org/computer/test-azure_msft-win2016-x64-6/ |
assert.js:84
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ ''
- 'false\n'
at ChildProcess.procDisabled.once.common.mustCall (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd11-x64/test/parallel/test-trace-events-category-used.js:52:10) 1 in 500 on freebsd11
On https://ci.nodejs.org/job/node-stress-single-test/2063/nodes=win10-vs2017/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO stress passed.
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: nodejs#22812 Ref: nodejs#21038 (comment) PR-URL: nodejs#22856 Refs: nodejs#22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Landed in e5170d4 |
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: #22812 Ref: #21038 (comment) PR-URL: #22856 Refs: #22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: #22812 Ref: #21038 (comment) PR-URL: #22856 Refs: #22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: #22812 Ref: #21038 (comment) PR-URL: #22856 Refs: #22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Unreliability for test-trace-events-fs-sync is believed to have been
fixed. Remove flaky designation.
Ref: #22812
Ref: #21038 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes