-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tty: handle setRawMode errors #22886
Conversation
Is it possible (and not too onerous) to add a reliable test that will cover the error condition? |
I don't think it's possible to trigger an error intentionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that major? I'm not really sure. I guess in theory errors should be so uncommon that it doesn't matter?
Re-run of CI: https://ci.nodejs.org/job/node-test-commit-linux/21689/ was successful. |
Landed in a82fc30. |
Refs: #21773
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes