test: don't inspect values if not necessary #22903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inspection triggered on each assert call eagerly even tough the assertion was never triggered. That caused significant CPU overhead.
addaleax
approved these changes
Sep 17, 2018
BridgeAR
added
the
author ready
Trott
approved these changes
Sep 18, 2018
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17270/ ✔️ (besides arm) I expect the arm-fanned re-run to fail so that will need a Rebuild, but let's see if this at least clears up the other two red subtasks. |
|
arm rebuild: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3576/ ✔️ |
|
Landed in 9ccf5c8 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 18, 2018
The inspection triggered on each assert call eagerly even tough the assertion was never triggered. That caused significant CPU overhead. PR-URL: nodejs#22903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
@BridgeAR Just for future reference, from our collaborator guide:
What most people do is to something like “:+1: this comment if you approve of fast-tracking” to a comment on the PR, and then wait for approvals. |
targos
pushed a commit
that referenced
this pull request
Sep 18, 2018
The inspection triggered on each assert call eagerly even tough the assertion was never triggered. That caused significant CPU overhead. PR-URL: #22903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
The inspection triggered on each assert call eagerly even tough the assertion was never triggered. That caused significant CPU overhead. PR-URL: #22903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
The inspection triggered on each assert call eagerly even tough the assertion was never triggered. That caused significant CPU overhead. PR-URL: #22903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspection triggered on each assert call eagerly even tough the
assertion was never triggered. That caused significant CPU overhead.
I currently try to figure out what a nice API would look like for lazy custom assert messages but this can go in right away.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes