Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move perf tools and APIs to Tier 3 #22915

Closed
wants to merge 1 commit into from
Closed

doc: move perf tools and APIs to Tier 3 #22915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions doc/guides/diagnostic-tooling-support-tiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,13 @@ The tools are currently assigned to Tiers as follows:

## Tier 3

| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
|-----------|---------------------------|-------------------------------|-------------------------|-------------|
| | | | | |
| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
|-----------|--------------------------------------|-------------------------------|-------------------------|-------------|
| Profiling | V8 CPU profiler | Partial (V8 Tests) | Yes | 1 |
| Profiling | --prof/--prof-process flags | Yes | Yes | 1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these flags are separate to the V8 CPU profiler? And the current tests do not properly test everything in depth, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these flags are separate to the V8 CPU profiler?

Because they are separate things: V8 CpuProfiler is a C++ API officially supported by V8 which can also be used through the inspector protocol. --prof is a flag not officially supported by V8.

And the current tests do not properly test everything in depth, right?

Right. That's why we're moving them to Tier 3 and not 2/1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe say it's also partial in that case until we have more tests in place?

| Profiling | V8 CodeEventHandler API | Partial (V8 Tests) | Yes | 2 |
| Profiling | V8 --interpreted-frames-native-stack | Yes | Yes | 2 |
| Profiling | Linux perf | Yes | Partial | 2 |

## Tier 4

Expand Down Expand Up @@ -136,10 +140,6 @@ The tools are currently assigned to Tiers as follows:
| Tracing | LTTng | No | Removed? | N/A |
| Tracing | ETW | No | Partial | 3 |
| Tracing | Systemtap | No | Partial | ? |
| Profiling | V8 CPU profiler (--prof) | No | Yes | 1 |
| Profiling | V8 CodeEventHandler API | No | Yes | ? |
| Profiling | V8 --interpreted-frames-native-stack | Yes | Yes | ? |
| Profiling | Linux perf | Yes | Partial | ? |
| Profiling | DTrace | No | Partial | 3 |
| Profiling | Windows Xperf | No | ? | ? |
| Profiling | 0x | No | No | 4 |
Expand Down