Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: initialize pid variable before goto #22961

Closed
wants to merge 1 commit into from

Commits on Sep 19, 2018

  1. src: initialize pid variable before goto

    This fixes an error when compiling with clang-cl on Windows:
    
    ```
    src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
        goto out;
        ^
    src/node.cc(2441,9):  note: jump bypasses variable initialization
      DWORD pid = args[0].As<Integer>()->Value();
            ^
    ```
    nornagon committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    ba9e794 View commit details
    Browse the repository at this point in the history