Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: initialize pid variable before goto #22961

Closed
wants to merge 1 commit into from
Closed

src: initialize pid variable before goto #22961

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Contributor

This fixes an error when compiling with clang-cl on Windows:

src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
    goto out;
    ^
src/node.cc(2441,9):  note: jump bypasses variable initialization
  DWORD pid = args[0].As<Integer>()->Value();
        ^
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nornagon
src: initialize pid variable before goto
ba9e794 
This fixes an error when compiling with clang-cl on Windows:

```
src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
    goto out;
    ^
src/node.cc(2441,9):  note: jump bypasses variable initialization
  DWORD pid = args[0].As<Integer>()->Value();
        ^
```
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 19, 2018
nornagon added a commit to electron/node that referenced this pull request Sep 19, 2018
@nornagon
fix: microsoft-goto warning w/ clang-cl
59083d5 
see nodejs/node#22961
@nornagon nornagon mentioned this pull request Sep 19, 2018
Merged
nornagon added a commit to electron/node that referenced this pull request Sep 19, 2018
@nornagon
fix: microsoft-goto warning w/ clang-cl
fd1a701 
see nodejs/node#22961
@addaleax
Copy link
Member

addaleax commented Sep 20, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17338/ (:heavy_check_mark:)

Please 👍 this comment to approve fast-tracking

@addaleax addaleax added windows Issues and PRs related to the Windows platform. lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 20, 2018
@addaleax
Copy link
Member

Landed in b7c1038, thanks for the PR!

@addaleax addaleax closed this Sep 20, 2018
addaleax pushed a commit that referenced this pull request Sep 20, 2018
@nornagon @addaleax
src: initialize pid variable before goto
b7c1038 
This fixes an error when compiling with clang-cl on Windows:

```
src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
    goto out;
    ^
src/node.cc(2441,9):  note: jump bypasses variable initialization
  DWORD pid = args[0].As<Integer>()->Value();
        ^
```

PR-URL: #22961
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Sep 21, 2018
@nornagon @targos
src: initialize pid variable before goto
ace6e07 
This fixes an error when compiling with clang-cl on Windows:

```
src/node.cc(2437,5):  error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
    goto out;
    ^
src/node.cc(2441,9):  note: jump bypasses variable initialization
  DWORD pid = args[0].As<Integer>()->Value();
        ^
```

PR-URL: #22961
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nornagon nornagon deleted the patch-1 branch September 21, 2018 17:08
codebytere pushed a commit to electron/node that referenced this pull request Oct 2, 2018
@nornagon @codebytere
fix: microsoft-goto warning w/ clang-cl
0fee0c1 
see nodejs/node#22961
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nornagon @addaleax @jasnell @cjihrig @tniessen @joyeecheung @richardlau @lundibundi @nodejs-github-bot