-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0.0 proposal #23230
11.0.0 proposal #23230
Conversation
Please consider also #23181 |
320e4ae
to
4f809c0
Compare
@targos: would you be able to point to a concise summary of the new v8 features in V8 7.0 relative to the 6.8 version currently in Node.js 10? |
@vsemozhetbyt ... Can you please tag that pr with the 11.0 milestone? I'm not at my laptop at the moment to do so. |
Done. |
@@ -8,7 +8,8 @@ release lines. | |||
|
|||
Select a Node.js version below to view the changelog history: | |||
|
|||
* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) — **Current** | |||
* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - **Current** | |||
* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) — Current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to have two current releases (10 and 11) until 10 turns LTS later this month?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately.
Some of the V8 news are:
|
Friendly suggestion for the release notes:
migrating to.... what? I would suggest adding that to that sentence. |
@@ -934,8 +934,8 @@ is not supported. | |||
<!-- YAML | |||
added: v8.3.0 | |||
changes: | |||
- version: REPLACEME | |||
pr-url: REPLACEME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be: #22281
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh... we need to update the docs to request that people not use the REPLACEME
as a token in the pr-url
field. That needs to be filled in either before landing the PR or as it is landed so it doesn't get missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a lint rule, probably added to the mythical commit-queue, and in the meantime to ncu (nodejs/automation#29)
@@ -995,8 +995,8 @@ mark. | |||
<!-- YAML | |||
added: v8.3.0 | |||
changes: | |||
- version: REPLACEME | |||
pr-url: REPLACEME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be: #22281
@jasnell Any new about |
@mapeso ... nothing significant. Work is progressing on that on a variety of fronts but there are not notable changes there specifically in 11.0.0 at this time. Because the ESM stuff is experimental, most of those changes will roll in incrementally through multiple patch and minor releases until it is stable enough to graduate from experimental. |
What about stable workers? |
@cloudever #22940 tracks the progress on that :) |
This comment has been minimized.
This comment has been minimized.
Many semver-minor commits are going to be in v10.12.0: #23313 |
Yep, I expected as much. I usually churn through the changelog 4 or 5 times before the actual release happens. I suspect the changelog for 11.0.0 is going to be much smaller. |
201ce61
to
91a54dd
Compare
Updated to master. Small nit... waiting a few minutes to start CI again... |
91a54dd
to
25e4efe
Compare
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17975/ Test build: https://ci-release.nodejs.org/job/iojs+release/3853/ (not everyone will be able to see this link) |
Quick question: I'm guessing you weren't able to pull in #22842? |
f3f837f
to
3b38625
Compare
Notable changes: * Build * FreeBSD 10 is no longer supported.[#22617](#22617) * `child_process` * The default value of the `windowsHide` option has been changed to `true`. [#21316](#21316) * `console` * `console.countReset()` will emit a warning if the timer being reset does not exist. [#21649](#21649) * `console.time()` will no longer reset a timer if it already exists. [#20442](#20442) * Dependencies * V8 has been updated to 7.0. [#22754](#22754) * `fs` * The `fs.read()` method now requires a callback. [#22146](#22146) * The previously deprecated `fs.SyncWriteStream` utility has been removed.[#20735](#20735) * `http` * The `http`, `https`, and `tls` modules now use the WHATWG URL parser by default. [#20270](#20270) * General * Use of `process.binding()` has been deprecated. Userland code using `process.binding()` should re-evaluate that use and begin migrating. If there are no supported API alternatives, please open an issue in the Node.js GitHub repository so that a suitable alternative may be discussed. * An experimental implementation of `queueMicrotask()` has been added. [#22951](#22951) * Internal * Windows performance-counter support has been removed. [#22485](#22485) * The `--expose-http2` command-line option has been removed. [#20887](#20887) * Timers * Interval timers will be rescheduled even if previous interval threw an error. [#20002](#20002) * `util` * The WHATWG `TextEncoder` and `TextDecoder` are now globals. [#22281](#22281) * `util.inspect()` output size is limited to 128 MB by default. [#22756](#22756) * A runtime warning will be emitted when `NODE_DEBUG` is set for either `http` or `http2`. [#21914](#21914)
PR-URL: TBD
3b38625
to
157c416
Compare
Release Candidate Build: https://ci-release.nodejs.org/job/iojs+release/3860/ |
Release build: https://ci-release.nodejs.org/job/iojs+release/3862/ (not everyone will be able to access this link) |
@targos ... have you had any issues running |
@indutny @targos @nodejs/build ... The release might not happen today unless I'm able to figure out why I'm having the following issue with git-secure-tag..
|
I think I have a temporary work around... |
@Trott cool. btw i'm going by |
Since the rule changed recently, it may be out of date. Try upgrading to the latest node-core-utils. If that doesn't fix it, open an issue or PR in the node-core-utils repo if there isn't one already. |
No, it did not make it. |
will there be an 11.0.1 then? queueMicrotask is kinda broken without that commit... |
Released! @devsnek ... Perhaps in a week or two, yes. I won't be cutting a new release this week unless a regression is found in 11.0.0. Keep in mind that this is precisely why we added |
@jasnell I never had issues with |
This is the in progress 11.0.0 release. The changelog is expected to change significantly as new 10.x releases occur between now and Oct 23.
Please consider the semver-major cut-off to be in effect. I will only pull in semver-major commits that have consensus from the TSC or are considered critical fixes
Notable Changes (DRAFT):
child_process
windowsHide
option has been changed totrue
. #21316console
console.countReset()
will emit a warning if the timer being reset does not exist. #21649console.time()
will no longer reset a timer if it already exists. #20442crypto
fs
fs.read()
method now requires a callback. #22146fs.SyncWriteStream
utility has been removed.#20735http
http
,https
, andtls
modules now use the WHATWG URL parser by default. #20270http2
PING
frame is received. #23009ORIGIN
frame has been added. #22956process.binding()
has been deprecated. Userland code usingprocess.binding()
should re-evaluate that use and begin migrating.queueMicrotask()
has been added. #22951--expose-http2
command-line option has been removed. #20887multipleResolves
event will be emitted when a Promise is resolved (or rejected) more than once. #22218util
TextEncoder
andTextDecoder
are now globals. #22281util.inspect()
output size is limited to 128 MB by default. #22756NODE_DEBUG
is set for eitherhttp
orhttp2
. #21914Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes