Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-cluster-worker-events to use arrow functions. #23469

Closed
wants to merge 3 commits into from
Closed

test: update test-cluster-worker-events to use arrow functions. #23469

wants to merge 3 commits into from

Conversation

Ev-Abbott
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@digitalinfinity
Copy link
Contributor

@AbbottEverett thanks for your PR- the change itself looks good to me but your git config needs a little tweak. Can you run the following command to set your email in your git config:
git config user.email "MY_NAME@example.com"

Then run git commit --amend --reset-author and push again
This is so that you're credited correctly for this PR (for instance, your github badge will change from "First time contributor" to "Contributor" once this PR lands if your email is correct)

(thanks to @gireeshpunthil for this tip!)

@Ev-Abbott
Copy link
Author

Thanks for the advice @digitalinfinity. I made the changes and pushed to this branch.

const messages = [];

function check(m) {
const check = (m) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit: for top level functions like this, using the function check(m) { form is preferred. The arrow functions on the event handlers is fine.

@Trott
Copy link
Member

Trott commented Oct 13, 2018

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 13, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Collaborators, please 👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Oct 13, 2018

Landed in 3989785.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Oct 13, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
PR-URL: nodejs#23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 14, 2018
PR-URL: #23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
PR-URL: #23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
PR-URL: #23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
PR-URL: #23469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants