Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.13.1 proposal #24675

Closed
wants to merge 328 commits into from

Conversation

@codebytere
Copy link
Member

commented Nov 27, 2018

2018-11-27, Version 10.13.1 'Dubnium' (LTS), @codebytere

Notable Changes

Coming soon.

Commits

  • [8345a8227d] - async_hooks: add missing async_hooks destroys in AsyncReset (Bastian Krol) #23272
  • [9e92b8124d] - benchmark: fix bench-mkdirp to use recursive option (Klaus Meinhardt) #23699
  • [d13bb2c2eb] - benchmark: coerce PORT to number (Ali Ijaz Sheikh) #23721
  • [99d39f9cf0] - benchmark: added a test benchmark for worker (Muzafar Umarov) #23475
  • [c39b910f6e] - bootstrapper: move internalBinding to NativeModule (Gus Caplan) #23025
  • [74f128a3cd] - build: make benchmark/napi all prereq order-only (Daniel Bevenius) #23951
  • [bd73da00f2] - build: add -Werror=undefined-inline to clang builds (Refael Ackermann) #23961
  • [51947a515d] - build: configure default v8_optimized_debug (Refael Ackermann) #23704
  • [aed45d7ce9] - build: add lint-py which uses flake8 (cclauss) #21952
  • [9844188025] - build: allow for overwriting of use_openssl_def (Shelley Vohr) #23763
  • [a5530159c1] - build: fix coverage generation (Michael Dawson) #23769
  • [abd46ee1b5] - build: fix ./configure --enable-d8 (Ben Noordhuis) #23656
  • [715768e1e1] - build: add .DS_store to .gitgnore (Marcos Frony) #23554
  • [8f58eed775] - build,meta: switch to gcc-4.9 on travis (Refael Ackermann) #23778
  • [d1ac802989] - child_process: handle undefined/null for fork() args (Shobhit Chittora) #22416
  • [d62d6666d4] - crypto: add SET_INTEGER_CONSANT macro (Daniel Bevenius) #23687
  • [cbc54d4f5d] - crypto: strip unwanted space from openssl version (Sam Roberts) #23678
  • [f216699ab4] - crypto: remove DiffieHellman.initialised_ (Tobias Nießen) #23717
  • [3ca41dce5c] - crypto: simplify internal state handling (Tobias Nießen) #23648
  • [4ba897750d] - crypto: simplify error handling in ECDH::New (Tobias Nießen) #23647
  • [86a5690e38] - crypto: move field initialization to class (Diana Holland) #23610
  • [a3540914c9] - crypto: fix length argument to snprintf() (Ben Noordhuis) #23622
  • [e66c09e459] - deps: cherry-pick 2987946 from upstream V8 (Refael Ackermann) #24555
  • [b2fbefb037] - deps: icu: apply workaround patch (Steven R. Loomis) #23764
  • [20430ae487] - deps: V8: Add virtual dtor to avoid aix gcc error (Vasili Skurydzin) #23695
  • [d3fb599b61] - deps: cherry-pick 67b5499 from V8 upstream (Vasili Skurydzin) #23695
  • [f2d3bade81] - deps: cherry-pick d2e0166 from V8 upstream (Vasili Skurydzin) #23695
  • [a4d67c95b6] - deps: cherry-pick a51f429 from V8 upstream (Vasili Skurydzin) #23695
  • [01544e1224] - deps: cherry-pick abab9fb from V8 upstream (Vasili Skurydzin) #23695
  • [d4c8d778e8] - deps: cherry-pick d9e7832 from V8 upstream (Vasili Skurydzin) #23695
  • [1e9b4a2a09] - deps: backport 525b396195 from upstream V8 (Peter Marshall) #23827
  • [2290c315a2] - deps: partially revert 'increase V8 deprecation levels' (Peter Marshall) #24195
  • [44279e03fc] - deps: add missing ares_android.h file (cjihrig) #23682
  • [67f5d3052d] - deps,v8: fix gypfile bug (Refael Ackermann) #23704
  • [b2252ea81d] - dns: fix inconsistent (hostname vs host) (Ulises Gascón) #23572
  • [a66d8774ac] - doc: fix dublication in net.createServer() docs (Ivan Filenko) #24026
  • [435e7b4673] - doc: address bits of proof reading work (Jagannath Bhat) #23978
  • [514b537604] - doc: revise COLLABORATOR_GUIDE.md (Rich Trott) #23990
  • [8f782fbe27] - doc: simplify CODE_OF_CONDUCT.md (Rich Trott) #23989
  • [5c6d49b486] - doc: revise CHANGELOG.md text (Rich Trott) #23988
  • [17c2ddd71d] - doc: improve COLLABORATOR_GUIDE (Jagannath Bhat) #23977
  • [a9dcf6f0ce] - doc: improve BUILDING.md (Jagannath Bhat) #23976
  • [a35e8f1666] - doc: add types and their corresponding return values (Ouyang Yadong) #23998
  • [4a52fc0fea] - doc: add branding to style guide (Rich Trott) #23967
  • [803070b7f1] - doc: use Node.js instead of Node (Rich Trott) #23967
  • [f6abca9d62] - doc: revise BUILDING.md (Rich Trott) #23966
  • [8180b0b5b3] - doc: clarify fd behaviour with {read,write}File (Sakthipriyan Vairamani (thefourtheye)) #23706
  • [1c9ae77c40] - doc: fix typographical issues (Denis McDonald) #23970
  • [d19a3d6ee3] - doc: document HPE_HEADER_OVERFLOW error (Sam Roberts) #23963
  • [3c46c03678] - doc: add documentation for http.IncomingMessage$complete (James M Snell) #23914
  • [ddfb22fd96] - doc: remove mailing list (Rich Trott) #23932
  • [5072fcb899] - doc: remove notice of dashes in V8 options (Denys Otrishko) #23903
  • [839f026ded] - doc: rename README section for Release Keys (Rich Trott) #23927
  • [565f4ca950] - doc: add note about ABI compatibility (Myles Borins) #22237
  • [64c683bcdc] - doc: add optional callback to socket.end() (Ajido) #23937
  • [c0649c83b3] - doc: make example more clarified in cluster.md (ZYSzys) #23931
  • [fa9d2861ed] - doc: simplify valid security issue descriptions (Rich Trott) #23881
  • [28ee410c9d] - doc: simplify path.basename() on POSIX and Windows (ZYSzys) #23864
  • [09faedfcf5] - doc: document nullptr comparisons in style guide (Anna Henningsen) #23805
  • [9a09f8af90] - doc: remove problematic example from README (Rich Trott) #23817
  • [8a6086c682] - doc: use Cookie in request.setHeader() examples (Luigi Pinca) #23707
  • [f5c68dc363] - doc: NODE_EXTRA_CA_CERTS is ignored if setuid root (Ben Noordhuis) #23770
  • [e711e45191] - doc: add review suggestions to require() (erickwendel) #23605
  • [f1c2fb3ae2] - doc: document and warn if the ICU version is too old (Steven R. Loomis) #23766
  • [c77d127dfe] - doc: move @phillipj to emeriti (Phillip Johnsen) #23790
  • [9982c09469] - doc: add note about removeListener order (James M Snell) #23762
  • [bd0e0d2105] - doc: document ACL limitation for fs.access on Windows (James M Snell) #23772
  • [64f9a3c138] - doc: document that addMembership must be called once in a cluster (James M Snell) #23746
  • [30bcddcaeb] - doc: add missing YAML labels (Vse Mozhet Byt) #23810
  • [f8bd7c0f02] - doc: remove reference to sslv3 in tls.md (James M Snell) #23745
  • [da65cb61e5] - doc: revise security-reporting example text (Rich Trott) #23759
  • [30b1a4a61f] - doc: formalize non-const reference usage in C++ style guide (Anna Henningsen) #23155
  • [523db5f5a9] - doc: fix headings for CHANGELOG_v10.md (Myles Borins) #23973
  • [4c9d993d8c] - doc: add missing deprecation labels (James M Snell) #23761
  • [f318d163a5] - doc: document use of buffer.swap16() for utf16be (James M Snell) #23747
  • [d862f1e894] - doc: add Backport-PR-URL info in backport guide (Ali Ijaz Sheikh) #23701
  • [8cd83c50b8] - doc: improve README.md (Rich Trott) #23705
  • [e856fa2155] - doc: simplify security reporting text (Rich Trott) #23686
  • [3e4032a333] - doc: cleanup and references in C++ guide (Refael Ackermann) #23650
  • [00c028fb1d] - doc: fix url example to match behavior (Сковорода Никита Андреевич) #23359
  • [272d4faadf] - doc: use reserved domains for examples in url.md (Сковорода Никита Андреевич) #23359
  • [43d4977c96] - doc: fix pr-url in repl.md (Сковорода Никита Андреевич) #23359
  • [5ee0d90b6e] - doc: wrap links in <> (Сковорода Никита Андреевич) #23359
  • [45fbcbb68d] - doc: edit BUILDING.md (Rich Trott) #23435
  • [1266878cbe] - doc: describe SNI host name format (Sam Roberts) #23357
  • [4e1a54f309] - doc: revise security-reporting text in README (Rich Trott) #23407
  • [39c59be38a] - doc: rewrite consensus seeking in guide (Rich Trott) #23349
  • [f63bf3fe0e] - doc: edit for minor fixes to prcoess.md (Rich Trott) #23347
  • [6603592ab4] - doc: remove personal pronoun from worker_threads (Rich Trott) #23347
  • [ab90013836] - doc: remove personal pronoun from domain.md (Rich Trott) #23347
  • [1e119eb6ae] - doc: remove style instruction that is not followed (Rich Trott) #23346
  • [6196884390] - doc: add WebAssembly to globals (Steven) #23339
  • [26f4221fc0] - doc,meta: assign PR semantics (Refael Ackermann) #23292
  • [b7d6c1ae96] - doc,meta: refresh wording in colab guide (Refael Ackermann) #23292
  • [2f51e49570] - doc,meta: add references to outside C++ guides (Refael Ackermann) #23317
  • [d4f0366a7d] - http: reduce duplicated code for cleaning parser (Weijia Wang) #23351
  • [9f4be5d1cb] - http2: make Http2Settings constructors delegate (Daniel Bevenius) #23326
  • [7374c0c5e1] - lib: fix code cache generation (Joyee Cheung) #23855
  • [dd82014f60] - lib: remove useless cwd in posix.resolve (ZYSzys) #23902
  • [c601fdef12] - lib: migrate from process.binding('config') to getOptions() (Vladimir Ilic) #23588
  • [9b89e9c250] - lib: migrate process.binding to internalBinding (surreal8) #23517
  • [100ed74216] - lib: migrate process.binding to getOptions (Randy Wressell) #23522
  • [6eea5dc6e8] - lib: migrate process.binding('config') to getOptions() (Jonny Kalambay) #23526
  • [5a0b9faab8] - lib: removed unused variable (Long Nguyen) #23497
  • [c634698d5c] - lib: switch to internalBinding for cjs loader (Steven Scott) #23492
  • [26f356f7ab] - lib: migrate from process.binding to internalBinding (Andres Monge) #23586
  • [6acc89172f] - lib: migrate to getOptions in loaders.js (David Xue) #23455
  • [00698cc4e5] - lib: remove an unused variable (Claire Liu) #23482
  • [63988f6cfd] - lib: remove unused 'e' from catch (Matt Holmes) #23458
  • [8016d35ea3] - lib: http server, friendly error messages (Sagi Tsofan) #22995
  • [8ec2c51bc9] - meta: clarify fast-track approval (James M Snell) #23744
  • [4f8e4f065c] - module: removed unused variable (Martin Omander) #23624
  • [9b951601e2] - n-api: make per-Context-ness of napi\_env explicit (Anna Henningsen) #23689
  • [ac73050fc8] - os: fix memory leak in userInfo() (Anna Henningsen) #23893
  • [5e1b9c3c91] - readline: assert without the use of event listener (Lian Li) #23472
  • [d1c0827294] - repl: migrate from process.binding('config') to getOptions() (Jose Bucio) #23684
  • [9dfc13efa0] - repl: remove unused variable from try catch (mmisiarek) #23452
  • [18060f2d12] - repl: remove unused variable e from try catch (Khalid Adil) #23449
  • [d25e94b795] - src: fix fully-static & large-pages combination (Suresh Srinivas) #23964
  • [592f5bd49c] - src: use "constants" string instead of creating new one (Ouyang Yadong) #23894
  • [98649dc17f] - src: reduce duplication in tcp_wrap Connect (Daniel Bevenius) #23753
  • [d316f64e9e] - src: refactor deprecated v8::String::NewFromTwoByte call (Romain Lanz) #23803
  • [2e3e68aac1] - src: refactor deprecated v8::Function::Call call (Romain Lanz) #23804
  • [9a7554a85b] - src: fix CreatePlatform header param mismatch (Shelley Vohr) #23947
  • [de2340dccd] - src: trace_event: secondary storage for metadata (Ali Ijaz Sheikh) #20900
  • [d1102f81dc] - src: initial large page (2M) support (Suresh Srinivas) #22079
  • [850b54f4fd] - src: changed stdio_pipes_ to std::vector (Steven Auger) #23615
  • [f5cadf6c12] - src: update v8::Object::GetPropertyNames() usage (cjihrig) #23660
  • [ea9c44d6f8] - src: remove OCB support ifdef OPENSSL_NO_OCB (Shelley Vohr) #23635
  • [dd91c1d20c] - src: change macro to fn (Gino Notto) #23603
  • [db44a1a5a8] - src: add default initializer in tls_wrap (Richard Hoehn) #23567
  • [b55fed075c] - src: use MallocedBuffer abstraction for buffers (Cody Hazelwood) #23543
  • [90cbeae6d9] - src: use default initializers over settings fields on the constructor (Andrew J D McCann) #23532
  • [fa7d0ce486] - src: remove unused UVHandle methods (MarianneDr) #23535
  • [25d7c0213c] - src: ready background workers before bootstrap (Ali Ijaz Sheikh) #23233
  • [264d1298b7] - src: move default assignment of async_id_ in async_wrap.h (David Corona) #23495
  • [8cd41aa742] - src: fix bug in MallocedBuffer constructor (Tobias Nießen) #23434
  • [8e198f0494] - src: improve SSL version extraction logic (Gireesh Punathil) #23050
  • [cdb6da9478] - src: revert removal of SecureContext \_external getter (Vitaly Dyatlov) #21711
  • [2564abfc99] - src: remove unused limits header from util-inl.h (Daniel Bevenius) #23353
  • [168885f9c6] - src: replace NO_RETURN with [[noreturn]] (Refael Ackermann) #23337
  • [0b39975cd4] - src: fix usage of deprecated v8::Date::New (Michaël Zasso) #23288
  • [c32cf17907] - src,win: informative stack traces (Refael Ackermann) #23822
  • [1484eeb456] - stream: do not error async iterators on destroy(null) (Matteo Collina) #23901
  • [5ea25c2a97] - stream: ended streams should resolve the async iteration (Matteo Collina) #23901
  • [dbd37ab256] - stream: async iteration should work with destroyed stream (Matteo Collina) #23785
  • [203c420025] - test: assert that invalidcmd throws error code (Jerome Covington) #23942
  • [31eff105e0] - test: fix strictEqual arguments order (Esteban Sotillo) #23956
  • [a15de4876a] - test: add property for RangeError in test-buffer-copy (mritunjaygoutam12) #23968
  • [b89297b618] - test: fix test-fs-watch-system-limit (Ali Ijaz Sheikh) #23986
  • [ff59c1c97e] - test: run code cache test by default and test generator (Joyee Cheung) #23855
  • [5fb583240e] - test: fix regression when compiled with FIPS (Adam Majer) #23871
  • [1c6820b9e1] - test: fix strictEqual() argument order (Loic) #23829
  • [f30f11bd5d] - test: verify performance.timerify() works w/ non-Node Contexts (Anna Henningsen) #23784
  • [9e9bb85b6c] - test: add test-benchmark-napi (Emily Marigold Klassen) #23585
  • [60f1a5aae8] - test: increase coverage of internal/stream/end-of-stream (Tyler Vann-Campbell) #23751
  • [01c1ee6730] - test: fix strictEqual() arguments order (Nolan Rigo) #23800
  • [79be83dde9] - test: fix invalid modulesLength for DSA keygen (Adam Majer) #23732
  • [cdf89339e4] - test: fix test-require-symlink on Windows (Bartosz Sosnowski) #23691
  • [fd12699f7d] - test: fix strictEqual() argument order (Romain Lanz) #23768
  • [6ee9273e9e] - test: fix strictEqual() arguments order (Thomas GENTILHOMME) #23771
  • [4116788f76] - test: fix assertion arguments order (Elian Gutierrez) #23787
  • [4673848025] - test: add blocks and comments to fs-promises tests (Ian Sutherland) #23627
  • [9ad176ab50] - test: add a test for tls.Socket with allowHalfOpen (Ouyang Yadong) #23866
  • [874371df89] - test: increase coverage for readfile with withFileTypes (christian-bromann) #23557
  • [ce03acac71] - test: skip failing tests for osx mojave (jn99) #23550
  • [8552bb4065] - test: enable trace-events tests for workers (Richard Lau) #23698
  • [8e7a12f450] - test: improve test coverage for fs module (garrik.leonardo@gmail.com) #23601
  • [0b7aa275a9] - test: fix argument order in assertion (Illescas, Ricardo) #23581
  • [4e019f05bc] - test: reversed params in assert.strictEqual() (Dusan Radovanovic) #23591
  • [ff9232db35] - test: correct order of args in buffer compare (James Irwin) #23521
  • [11eabba0fb] - test: check codes of thrown errors (Nancy Truong) #23519
  • [79d7733c59] - test: fix strictEqual arguments order (Jonathan Samines) #23486
  • [642b1686be] - test: add test coverage for fs.truncate (christian-bromann) #23620
  • [f82611a27e] - test: use smaller keys for a faster keygen test (Sam Roberts) #23430
  • [e8ca33025a] - test: increased code coverage for slowCases (Jared Haines) #23592
  • [002c35cd42] - test: assertions arguments match docs (Amanuel Ghebreweldi) #23594
  • [3d703042c1] - test: fix assert.strictEqual() argument order (Derek) #23598
  • [25b166a5cb] - test: fix assert parameter order in test-https-localaddress.js (Ian Sutherland) #23599
  • [e98d8f427c] - test: change order of assert.strictEquals arguments (Chuck Theobald) #23600
  • [8d39cf6323] - test: fix assert equal order of arguments (David Jiang) #23602
  • [af6528ab85] - test: fix order of assert args in client response domain test (Emily Kolar) #23604
  • [984fac4a53] - test: re-order strictEqual paramater calls (Paul Tichonczuk) #23607
  • [37e1101a0f] - test: fix assertions args order (Milton Sosa) #23608
  • [0c9a866541] - test: fix parameters in test-repl.js (Israel Ortiz) #23609
  • [d370c5e8c1] - test: reverse arguments in assert.strictEqual (Vsevolod Geraskin) #23613
  • [4d9059b1df] - test: update assertion parameter order (Sean Healy) #23614
  • [6d80af3112] - test: fix backward assertion arguments (Stéphane Vasseur) #23616
  • [202d38c484] - test: reversed 1st and 2nd arguments for assert.strictEqual() (vchoubey08) #23617
  • [9fb6cf01f9] - test: correct assertion argument order (Jeff Marvin) #23618
  • [64268d005a] - test: fix assertion order (erickwendel) #23626
  • [4874ce2106] - test: updated assert test values to doc standards (keeysnc) #23593
  • [57b4fc16c3] - test: switch order of assertion arguments (Mel) #23563
  • [e0b4dab586] - test: fix assert.strictEqual() argument order (Savio Resende) #23564
  • [0fcbe2c8ba] - test: fix parameter order of assertions (Pete Lombardo) #23565
  • [7c7f8068be] - test: fix assert value order (Ethan Weber) #23566
  • [ef2777db40] - test: fix strictEqual order for timers test (Saleh Abdel Motaal) #23568
  • [2cb4789a68] - test: corrected assertion arguments order (francois) #23569
  • [110606daa5] - test: fix strictEqual input parameters order (AlixAng) #23570
  • [bcf24e7a4d] - test: fix order of arguments passed to strictEqual (Joe Shindelar) #23571
  • [2a3ba01b08] - test: fix arguments ordering for assertions to match the docs (Liran Tal) #23575
  • [b68ee2238f] - test: fixed strictEqual arguments order (Ruy Adorno) #23576
  • [2ea96196fe] - test: add crypto.scrypt test case with different encoding (Yitong) #23578
  • [6ec5b4a84d] - test: reversed actual and expected values for .strictEqual() (Salman Shakeel) #23579
  • [70ba0f97a0] - test: increased code coverage for proxySessionHandler (Justin Lee) #23583
  • [18ea8cfbdd] - test: fix assertion arguments order (seantcoyote) #23584
  • [c9ba20aeca] - test: fix assert.strictEqual() parameter order in test-path-maklong.js (blakehall) #23587
  • [8b38c2e1c0] - test: fix argument order in assertions (Illescas, Ricardo) #23589
  • [9439e3e973] - test: fix order of parameters to assert.strictEqual (Jason Nutter) #23590
  • [760b5715d9] - test: removed unused variable in fs-watch-file-slow (Maki Toda) #23548
  • [04769c4573] - test: update strictEqual arguments order (Clinton Pahl) #23552
  • [042e97428f] - test: removed unused error variable in try catch (Murtaza H) #23553
  • [fc2f104efe] - test: reverse order of args in reconnect-error assert (Jackelin Herrera) #23555
  • [abf19da10f] - test: added async-hook benchmark (peter) #23556
  • [0569bfeab1] - test: fix order of assert arguments in vm-new-script-this-context (Victor Poriazov) #23558
  • [fc05ca56e7] - test: modernize test-crypto-domain (naris93) #23559
  • [77f2100469] - test: fix strictEqual assertion order on readline tests (Joe Grosspietsch) #23561
  • [8d583a7b40] - test: switch strictEqual parameters - actual first before expected (Chris Bautista) #23537
  • [a410488994] - test: assert.strictEqual parameters ordered correctly (Justin denBroeder) #23538
  • [5bf919e818] - test: fix assert.strictEqual() arguments order (Ivan Lukasevych) #23539
  • [21a46ef123] - test: reverse the order of assertion statement arguments in pingpong test (Allan Zheng) #23540
  • [e5500f823d] - test: added test for generateKeyPair (David Xue) #23541
  • [adc89e30cf] - test: swap expected and actual arguments in assert.strictEqual() (Erin Bush) #23542
  • [6e5a5ff654] - test: fix assertions argument order (KelvinLawHF1) #23544
  • [02b0688003] - test: fix assertion argument order (Carl Richmond) #23545
  • [4c27cf0a41] - test: refactor callback functions to arrow functions (Sean Healy) #23546
  • [1e8ce06732] - test: updating assertion and expect order in test-tls-client-verify.js (Eli Itah) #23547
  • [efdbc2d846] - test: use correct argument order for assert.strictEqual() (Oktavianus Ludiro) #23527
  • [5d7c15bc6d] - test: corrected the order of arguments in assert.strictEqual() (Diana Lee) #23528
  • [8e69895603] - test: fix assert.strictEqual() argument order (ssamuels0916) #23529
  • [93af93ae9f] - test: fix strictEqual assertion argument in test-tls-ecdh-auto (jaxyz) #23530
  • [0895576d10] - test: correct labelling of asserts errors (nofwayy) #23531
  • [474b401794] - test: reorder asserts arguments (Marcos Frony) #23534
  • [de8ffbad80] - test: updating assertion on test so it fits the new method signature (garrik.leonardo@gmail.com) #23536
  • [7cd9161ea4] - test: refactor functions to es6 (Michael Chen) #23510
  • [22a4ec1d70] - test: replaced functions with arrow functions (edgarzapeka) #23511
  • [a0985281ee] - test: corret assertion arg order in test-regress-GH-892.js (Elvis-Philip N) #23513
  • [608d5fa8f0] - test: fix test-dgram-pingpong assertion arg order (David Ward) #23514
  • [0d6d6f63cd] - test: fix assert.strictEqual() argument order (Ben Schaaf) #23515
  • [161cbbb97a] - test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js (Takdeer Sodhan) #23516
  • [ad83caf7fa] - test: use the correct parameter order on assert.strictEqual() (Tyler Vann-Campbell) #23520
  • [b7d4404e87] - test: fix assert order in test-vm-context (Lee Gray) #23523
  • [9dc11e3354] - test: switch arguments of assert() (Arne Schramm) #23524
  • [4f116a7009] - test: swap assert argument order in test-vm-create-and-run-in-context.js (Pascal Lambert) #23525
  • [ff5345cf5c] - test: fix order of assert.strictEqual() args to actual, expected (Joshua Belcher) #23501
  • [f5fd8a2168] - test: fixed incorrect variable order in assert.strictEqual() (Daniyal Mokhammad) #23502
  • [66c82adb0e] - test: properly order test assertion variables (David Scott) #23503
  • [28b6129a7b] - test: modernize test-child-process-flush-stdio (Viacheslav Liakhov) #23504
  • [23d6932c61] - test: put expected assert value in correct place (Jean-Francois Arseneau) #23505
  • [d590aa858d] - test: fix argument order in assertions (Illescas, Ricardo) #23506
  • [119fc3abdd] - test: fix assertions args order in test/parallel/test-fs-chmod.js (Milton Sosa) #23507
  • [6f590be539] - test: fix strictEqual assertion arguments (Alejandro Oviedo Garcia) #23508
  • [d156d093ff] - test: fix ordering of assertion values (Andrew MacCuaig)
  • [fd5290e68c] - test: update function keywords to fat arrows (Robert Monks) #23493
  • [e9f17464a8] - test: reversed arguments in strictqual to reflect documentation (scabhi) #23494
  • [f1fb2bea5e] - test: modernized test to use arrow functions (Greg Goforth) #23496
  • [627e3ad241] - test: use arrow functions in test-exception-handler (Jenna Zeigen) #23498
  • [13afb68e8a] - test: fix argument order in asserts (@CAYdenberg) #23499
  • [e0a3e238bb] - test: modernizing test-dgram-listen-after-bind with arrow functions (chrisforrette) #23500
  • [01d599cffe] - test: fix strictEqual argument order (Felix Schlenkrich) #23490
  • [58aaa61363] - test: rename process.argv[0] to process.execPath, rename ex to err (Kayla Altepeter) #23488
  • [7e56801ddd] - test: fix assertion argument order (Carl Richmond) #23489
  • [16175c1b89] - test: fix assertion order test-tls-server-verify (Carolina Pinzon) #23549
  • [ac0a03a278] - test: fix assertion order (Chris Nguyen) #23533
  • [bf20cf8ba2] - test: change to arrow functions in send-bad-arguments (Anna Zhao) #23483
  • [b29b836d04] - test: removed unused variable (Michal Hynek) #23481
  • [b083715671] - test: fix argument order for assert.strictEqual (Stacey) #23485
  • [d6dabc79c5] - test: fix assert.strictEqual params order (Rock Hu) #23480
  • [87367eccbb] - test: removed mustCallAsync from common and added inside testcase (Quinn Langille) #23467
  • [46f944f700] - test: remove unused "e" from catch in http2 test (Stephen Heitman) #23476
  • [adff51fc11] - test: remove unused variable from catch (Paige Kato) #23477
  • [d7609a7a07] - test: inline common module boolean (ashleysimpson) #23479
  • [c73a6a05d1] - test: swap the order arguments are passed to assert (Dylson Valente Neto) #23580
  • [da17d97d82] - test: flip assertion arguments for make-callback/test.js (Tim Cheung) #23470
  • [b436ccc3b2] - test: replace function with arrow function (Yitong) #23474
  • [a6787a7f2b] - test: swap actual and expected in assertions (Yitong) #23474
  • [148d4e4b8e] - test: correctly order assertion arguments (Emily Kolar) #23473
  • [75d4bf2348] - test: mark test-http2-session-timeout as flake on ARM (Refael Ackermann) #23639
  • [65ea85f4a3] - test: update test-cluster-worker-events to use arrow functions (S. Everett Abbott) #23469
  • [1a39a56f6c] - test: correct order for assert.strictEqual for inspector-helper test (Maggie Nolan) #23468
  • [f8e7112b91] - test: fix incorrect expectation order (Amie) #23466
  • [77ef4970f6] - test: remove unused e variable in catch statement (Denny Scott) #23465
  • [ed9f8acc79] - test: correct assert test (Richard Markins) #23463
  • [eac6ba94f1] - test: fix incorrect ordering of args in assert.strictEqual() (mdaum) #23461
  • [8766d27598] - test: swap assert.strictEqual args to actual, expected (epeden) #23459
  • [2f920ce497] - test: fix assert.strictEqual argument order (andy addington) #23457
  • [58a5b76a58] - test: strictEqual correct order for http-information-processing test (Ivan Sieder) #23456
  • [e5a2fa2dcb] - test: fix http local address test assertion (Danu Widatama) #23451
  • [8a9b2b6168] - test: fix order of values in test assertions (Jared Haines) #23450
  • [31a96600fb] - test: fix assert.strictEqual arguments in test/parallel/test-c-ares.js (jungkumseok) #23448
  • [b3e43a6393] - test: fix parameter order passed to strictEqual (Shannon) #23577
  • [484dccbd44] - test: adding test coverage for SourceTextModule.evaluate (Kayla Altepeter) #23595
  • [2d3292225f] - test: rename common.ddCommand() (Rich Trott) #23411
  • [2f84a189c7] - test: refactor common.ddCommand() (Rich Trott) #23411
  • [65ae332098] - test: move some gc tests back to parallel/, unmark flaky (Anna Henningsen) #23356
  • [21c3822719] - test: improve test-gc-http-client-onerror (Denys Otrishko) #23196
  • [693a50e494] - test: improve test-gc-http-client-connaborted (Denys Otrishko) #23193
  • [6fa033c5b1] - test: fix assert.strictEqual argument order (et4891) #23518
  • [305c1e15fd] - test: fixing assertion value order (Joe Sepi) #23574
  • [3024e3abed] - test: separate WPT console test from other test (Rich Trott) #23340
  • [75a849aadf] - test: add WPT console-label-conversion test (Rich Trott) #23340
  • [a1fef95500] - test: rename WPT console test (Rich Trott) #23340
  • [27dd4dee0d] - test: add logging to test-worker-memory (Rich Trott) #23418
  • [e865418138] - test: add test for a vm indexed property (conectado) #23318
  • [dad3d7468b] - test: fix compiler warning in doc/api/addons.md (Daniel Bevenius) #23323
  • [9aec3e6863] - tls: close StreamWrap and its stream correctly (Ouyang Yadong) #23654
  • [81dc2419f4] - tls: prevent multiple connection errors (cjihrig) #23636
  • [1afd2071ee] - tls: make StreamWrap work correctly in "drain" callback (Ouyang Yadong) #23294
  • [e973b5df74] - tools: update alternative docs versions (Richard Lau) #23980
  • [3249a57f2b] - tools: update ESLint to 5.8.0 (cjihrig) #23904
  • [703f40a035] - tools: clarify commit message linting (Rich Trott) #23742
  • [28599e896a] - tools: do not lint commit message if var undefined (Rich Trott) #23725
  • [ac83a14714] - tools: prefer filter to remove empty strings (Sakthipriyan Vairamani (thefourtheye)) #23727
  • [6af2f9f946] - tools: update ESLint to 5.7.0 (cjihrig) #23629
  • [47eb9484ab] - tools: update node-lint-md-cli-rollup (Rich Trott) #23358
  • [43446671e1] - tools,icu: read full ICU version info from file (Refael Ackermann) #23269
  • [9e03393ff2] - tools,test: add list of slow tests (Refael Ackermann) #23251
  • [148ae30fd7] - tools,test: cleanup and dedup code (Refael Ackermann) #23251
  • [808f37c97f] - trace_events: destroy platform before tracing (Ali Ijaz Sheikh) #22938
  • [3df083c5fb] - util: handle null prototype on inspect (Anto Aravinth) #22331
  • [ffadcc1b22] - vm: pass parsing_context to ScriptCompiler::CompileFunctionInContext (Dara Hayes) #23206
  • [257a5e9c38] - win: add prompt to tools installation script (João Reis) #23987
  • [e9a291582d] - win: clarify Boxstarter behavior on install tools (Rob Reynolds) #23987
  • [469473d550] - Revert "win,msi: install tools for native modules" (Refael Ackermann) #24344
  • [1c17aa1e43] - worker: remove delete MessagePort.prototype.hasRef (James Traver) #23471
  • [179d4c7269] - zlib: refactor zlib internals (Anna Henningsen) #23360
  • [7fd1b4dd4b] - zlib: generate error code names in C++ (Anna Henningsen) #23413
rxiayth and others added 30 commits Oct 12, 2018
PR-URL: #23455
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
We are migrating towards using internalBinding(\'options\').getOptions()
instead of process.binding(\'config\') to access the value of the
--experimental-vm-modules command line option.

PR-URL: #23586
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #23483
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Update ESLint to 5.7.0.

PR-URL: #23629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This fixes links that were broken due to inclusion of the trailing dot.
Also simplifies a pair of occurances of []().

PR-URL: #23359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Now it points to the actual pr, not to /compare/.

PR-URL: #23359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Changes non-reserved domains to reserved ones in url.md.

PR-URL: #23359
Refs: https://www.iana.org/domains/reserved
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes one WHATWG URL example to match the actual behavior.

PR-URL: #23359
Fixes: #22653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23533
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #23610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
PR-URL: #23490
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23488
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Switch the cjs loader to use internalBinding instead of
process.binding for reading command line options.

PR-URL: #23492
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23489
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23549
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This change removes a variable that is not being used in the file.

PR-URL: #23497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23498
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23494
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23499
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23496
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23508
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23506
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23507
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23503
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The order of arguments in test-fs-readdir-ucs2 was the
opposite of what is recommended in the documentation,
which is that the first value should be the value being tested,
and the second value is the expected value.
This fixes the test to make it conform to the documentation.

PR-URL: #23505
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23501
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #23526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
oyyd and others added 15 commits Oct 31, 2018
This commit supplements some types and their corresponding return
values in docs, including `AsyncResource`, `DiffieHellman`,
`ECDH`, `https.Server`, `repl.REPLServer`.

PR-URL: #23998
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #23976
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #22416
Fixes: #20749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: #23968
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #23956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Update invalidcmd test case in test-child-process-spawn-typeerror to
assert on specific expected error code.

PR-URL: #23942
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Make the text shorter and clearer.

PR-URL: #23988
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23989
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Simplify text/content.

PR-URL: #23990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #24026
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original commit message:

    Stop manual unescaping of script source data when preprocessing logs.

    It appears that the fields are already being unescaped elsewhere,
    perhaps by the JSON writer. So if we unescape when adding the source
    filename and contents, unescaping will happen again later and plain
    backslashes will be interpreted as escape codes.

    Bug: v8:6240
    Change-Id: Ic66b9017ae685d6dd12944ee8d254991e26fbd32
    Reviewed-on: https://chromium-review.googlesource.com/1186625
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55401}

Refs: v8/v8@2987946

PR-URL: #24555
Fixes: #20891
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Nov 27, 2018

@codebytere sadly an error occured when I tried to trigger a build :(

Notable changes:
  * Coming Soon

PR-URL: #24675
@codebytere codebytere force-pushed the v10.13.1-proposal branch from cfc16a6 to 4088d6e Nov 27, 2018
@@ -24,12 +24,12 @@

#define NODE_MAJOR_VERSION 10
#define NODE_MINOR_VERSION 13
#define NODE_PATCH_VERSION 1
#define NODE_PATCH_VERSION 2

This comment has been minimized.

Copy link
@richardlau

richardlau Nov 27, 2018

Member

I don't think this should be changed until the subsequent Now working on v10.13.2 commit that also changes NODE_VERSION_IS_RELEASE back to 0.

@richardlau

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

This needs to be rebased and renamed v10.14.2 now.

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Replaced by 10.14.2

@MylesBorins MylesBorins deleted the v10.13.1-proposal branch Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.