Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: removed unused variable #23481

Closed
wants to merge 1 commit into from

Conversation

@michal-hynek
Copy link
Contributor

commented Oct 12, 2018

Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

Checklist
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.
@Trott Trott referenced this pull request Oct 14, 2018
@Trott

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

Landed in fd230c1

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Oct 14, 2018

addaleax added a commit that referenced this pull request Oct 14, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax added a commit that referenced this pull request Oct 14, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
burgerboydaddy added a commit to burgerboydaddy/node that referenced this pull request Oct 17, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: nodejs#23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Oct 17, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 30, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
test: removed unused variable
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.

PR-URL: #23481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.