test: skip failing tests for osx mojave

[jnord99]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[gdams]

FYI I am currently working on adding Mojave to ci.nodejs.org. Should be in there by the end of the day

[devsnek]

rip privileged escalation 😢

[Trott]

One downside is that the test will continue to be skipped after the bug in Mojave is fixed.

[gdams]

CI: https://ci.nodejs.org/job/node-test-pull-request/17873/

[refack]

One downside is that the test will continue to be skipped after the bug in Mojave is fixed.

@jnord99 could you add test that fails to /test/known_issues/ (where we expect test to fail until the underlying issue is resolved)?

[cjihrig]

I would not recommend moving them to known_issues.

[Trott]

I don't think this is a good candidate for known_issues because you'll need to list all the places where it will succeed in known_issues.status and there's no way to specify macOS Mojave only.

[refack]

I would not recommend moving them to known_issues.

Ack, Not moving. Adding a new one with the opposite condition, i.e.:

// Fail on OS X Mojave. https://github.com/nodejs/node/issues/21679
if (!common.isOSXMojave)
  common.skip('bypass test for non macOS Mojave');

... Do something that fails ...

[jnord99]

the update skips the test if it is Mojave. It already was doing the same for Windows. It will execute the test for other systems.
Yes, right now it is not granular. It currently looks for the base level of the OS and skips based on that major version. The node os module shows the version as 18. the test will skip for every os shown as 'darwin' and starts with 18. It could be revised to only skip if 'darwin' and 18.0.0 as that is what os.release() shows as the current version. If they fix it in 18.0.1 then the test will pass. if not then that would need to add 18.0.1 and so on until fixed.
current thinking was to just put it in as a major level skip and it could be updated if and when Apple corrects the issue. I don't know if that should be added as a known version or how best to track it.

[refack]

Added a "known_issue" test in https://github.com/nodejs/node/pull/23550/commits/cbc55b0874bd9742fd33cb27a14b4dd94d0e48d9to track this. Unfortunately we can't CI it.

@nodejs/platform-macos anyone can verify?
(python tools/test.py known_issues)

[mhdawson]

LGTM

[ChALkeR]

LGTM.

One downside is that the test will continue to be skipped after the bug in Mojave is fixed.

That is correct, but this is obviously better than scaring off all macOS users from contributing because they can't get tests to pass on their platform.

We can revisit it later once/if the issue gets fixed.

Also, this checks specifically for =18, not >=18.
So any macOS version later than Mojave would have this test running again, either passing (if that gets fixed) or failing (so we revisit again and would have to update the test once more).

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17964/

[addaleax]

Landed in eff869f

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)