test: fix timeout in sequential/test-fs-watch-system-limit #23692
Conversation
|
This likely isn't the best way to handle this. Our test runner will generally catch the timeout and fail the test as is. /cc @nodejs/testing |
|
as I was trying alternative options, I attempted to skip the test, but since the error stream expects at least one call, the tests were failing. I'm happy to make any changes, but off the top of my head I couldn't think of anything that would successful pass the test without upping the number of child processes that could get spawned. |
|
Would it make sense to move the test file from |
|
@Trott I would be okay with moving it there, yes… |
|
@marcusscott Would you be OK updating this to move the test unchanged from the |
|
sure thing, makes sense to me! |
mmmscott
force-pushed
the
fix-fs-watch-limit-timeout
branch
from
53a9eec
to
df71605
Compare
Timeout in this test can occur on Linux if machine is able to handle 200 child processes that are spawned.
Trott
force-pushed
the
fix-fs-watch-limit-timeout
branch
from
df71605
to
ed6c394
Compare
PR-URL: #23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in e492f92 |
PR-URL: #23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Timeout in this test can occur on Linux if machine is able to handle
200 child processes that are spawned.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes