Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document HPE_HEADER_OVERFLOW error #23963

Closed
wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Member

commented Oct 29, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/errors.md Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

left a comment

LGTM

@mhdawson
Copy link
Member

left a comment

LGTM

@sam-github sam-github force-pushed the sam-github:doc-http-errors branch from 8cd51d7 to f51e34c Oct 30, 2018

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

Landed in 0a4a08f

@sam-github sam-github closed this Oct 30, 2018

@sam-github sam-github deleted the sam-github:doc-http-errors branch Oct 30, 2018

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 30, 2018
doc: document HPE_HEADER_OVERFLOW error
PR-URL: nodejs#23963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos added a commit that referenced this pull request Nov 1, 2018
doc: document HPE_HEADER_OVERFLOW error
PR-URL: #23963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@targos targos referenced this pull request Nov 1, 2018
MylesBorins added a commit that referenced this pull request Nov 27, 2018
doc: document HPE_HEADER_OVERFLOW error
PR-URL: #23963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: document HPE_HEADER_OVERFLOW error
PR-URL: #23963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
doc: document HPE_HEADER_OVERFLOW error
PR-URL: #23963
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.