http2: multiple improvements #24063
Closed
http2: multiple improvements #24063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
jasnell
changed the title
jasnell
force-pushed
the
http2-js-improvements
branch
from
2747fde
to
b7d8d9e
Compare
|
On this PR... I plan to pull the destructuring changes back out as that is still a bit too expensive and is offsetting the performance improvement from other bits of the code. |
jasnell
force-pushed
the
http2-js-improvements
branch
2 times, most recently
from
53105f7
to
eeb665e
Compare
jasnell
force-pushed
the
http2-js-improvements
branch
from
eeb665e
to
3bc2c94
Compare
jasnell
changed the title
|
Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/18510/ /cc @nodejs/http2 |
|
Needs a rebase to eliminate conflicts? |
|
Yep, will get it this week
On Nov 14, 2018 19:24, "Rich Trott" <notifications@github.com> wrote:
Needs a rebase to eliminate conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24063 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eZAq2IbfAbzzJrPGeoE9oZbMFD3Jks5uvN5ngaJpZM4YM6pw>
.
|
jasnell
force-pushed
the
http2-js-improvements
branch
from
3bc2c94
to
aecc38c
Compare
|
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/18763/ |
|
Ping @nodejs/http2 ... I plan to get this landed by Wednesday this week. |
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`.
jasnell
force-pushed
the
http2-js-improvements
branch
from
8481e58
to
6da3da2
Compare
jasnell
added a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
jasnell
added a commit
that referenced
this pull request
Nov 21, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
jasnell
added a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
targos
pushed a commit
that referenced
this pull request
Nov 21, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
This was referenced Dec 7, 2018
|
@jasnell could you backport this to |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Make the http2 binding a bit more efficient by setting the callback functions once when the module is loaded rather than for each `Http2Session` and `Http2Stream`. PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24063 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Note: Landed with one collaborator approval after PR was open for 18 days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple improvements throughout the http2 js code
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes