v11.4.0 proposal #24854
Merged
v11.4.0 proposal #24854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #24416 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Instead of putting the source code and the cache in v8::Objects,
put them in per-process std::maps. This has the following benefits:
- It's slightly lighter in weight compared to storing things on the
v8 heap. Also it may be slightly faster since the preivous v8::Object
is already in dictionary mode - though the difference is very small
given the number of native modules is limited.
- The source and code cache generation templates are now much simpler
since they just initialize static arrays and manipulate STL
constructs.
- The static native module data can be accessed independently of any
Environment or Isolate, and it's easy to look them up from the
C++'s side.
- It's now impossible to mutate the source code used to compile
native modules from the JS land since it's completely separate
from the v8 heap. We can still get the constant strings from
process.binding('natives') but that's all.
A few drive-by fixes:
- Remove DecorateErrorStack in LookupAndCompile - We don't need to
capture the exception to decorate when we encounter
errors during native module compilation, as those errors should be
syntax errors and v8 is able to decorate them well. We use
CompileFunctionInContext so there is no need to worry about
wrappers either.
- The code cache could be rejected when node is started with v8 flags.
Instead of aborting in that case, simply keep a record in the
native_module_without_cache set.
- Refactor js2c.py a bit, reduce code duplication and inline Render()
to make the one-byte/two-byte special treatment easier to read.
PR-URL: #24384
Fixes: https://github.com/Remove
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24413 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24417 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24485 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This patch: - Introduces `common.bakeUrlData` which can be used to pre-generate the data set for the URL benchmarks to loop through instead of looping over a constant. - Add the option to use WPT data in benchmarks for better diversity in the input - Add the option to benchmark URL parsing with base URLs (whatwg only) - Moves the data in `benchmark/fixtures/url-inputs.js` to `benchmark/common.js` PR-URL: #24302 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This patch adds the option in the create-clientrequest benchmark to accept URL inputs (as strings or as URL objects) so we can measure the impact of URL parsing in a more sophisticated use case. PR-URL: #24302 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #24418 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24400 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24390 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24435 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #24469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #24440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to `setupInspector` and remove the argument from `setupInspector`. PR-URL: #24446 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Re-defining the array length will always set to 0. Hence, the code branch can not be covered. PR-URL: #24447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sudo:false is being removed by Travis CI. Travis CI recommends removing the configuration. Fixes: #24510 PR-URL: #24511 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #24411 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
use object spread to make console code more readable PR-URL: #24412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
X.509 certs are provided to the user in a parsed object form by a number of TLS APIs. Include public key info for elliptic curves as well, not just RSA. - pubkey: the public key - bits: the strength of the curve - asn1Curve: the ASN.1 OID for the curve - nistCurve: the NIST nickname for the curve, if it has one PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
For symmetricality with the EC public key info, and because its useful. PR-URL: #24358 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #24532 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Improve markup and return value description. PR-URL: #24533 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #24429 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Replace rollup + plugins + config file with zeit/ncc package designed to do the particular task that we're leveraging rollup for but with zero-ish configuration. (rollup can do a whole lot more, but we're using a tiny portion of its functionality.) PR-URL: #24813 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
checkNumberType() was a very thin wrapper around validateNumber(). This commit removes checkNumberType() and used validateNumber() directly instead. PR-URL: #24815 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24847 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was missed when reverting a former commit. To make sure the history is kept in place, this just adds a new entry to state the revert. PR-URL: #24805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #23199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory. This PR prevents that behavior. PR-URL: #24802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add a `--http-parser=llhttp` vs `--http-parser=traditional` command line switch, to make testing and comparing the new llhttp-based implementation easier. PR-URL: #24739 Refs: #24730 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR
force-pushed
the
v11.4.0-proposal
branch
from
758cb07
to
4c9a474
Compare
BridgeAR
force-pushed
the
v11.4.0-proposal
branch
from
4c9a474
to
8c40f09
Compare
|
New CI after excluding the process change: https://ci.nodejs.org/job/node-test-pull-request/19299/ ✔️ |
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR
force-pushed
the
v11.4.0-proposal
branch
from
8c40f09
to
4f1297f
Compare
targos
approved these changes
Dec 7, 2018
BridgeAR
added a commit
that referenced
this pull request
Dec 7, 2018
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR
added a commit
to BridgeAR/nodejs.org
that referenced
this pull request
Dec 7, 2018
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
nodejs#23708
* The inspection `depth` default is now back at 2.
nodejs#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
nodejs#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
nodejs#24739
* readline:
* The `readline` module now supports async iterators.
nodejs#23916
* repl:
* The multiline history feature is removed.
nodejs#24804
* tls:
* Added min/max protocol version options.
nodejs#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. nodejs#24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
nodejs#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
nodejs#24677
* The install-tools scripts or now included in the dist.
nodejs#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
nodejs#24655
PR-URL: nodejs#24854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-12-06, Version 11.4.0 (Current), @BridgeAR
Notable Changes
consolefunctions now handle symbols as defined in the spec. util,console: more spec compliant util format #23708depthdefault is now back at 2. Revert "util: change util.inspect depth default" #24326netanddgram. net,dgram: add ipv6Only option for net and dgram #23798readlinemodule now supports async iterators. readline: add support for async iteration #23916pathToFileURL()now supports LF, CR and TAB. url: support LF, CR and TAB in pathToFileURL #23720Commits:
7fb8d319fa] - assert: fix loose deepEqual map comparison (Ruben Bridgewater) #247498905518650] - assert,util: fix sparse array comparison (Ruben Bridgewater) #24749ef63bb287d] - benchmark: support URL inputs in create-clientrequest (Joyee Cheung) #24302f5d4db1e9c] - benchmark: pre-generate data set for URL benchmarks (Joyee Cheung) #2430273786c854a] - buffer: remove checkNumberType() (cjihrig) #24815a22ac0bb66] - build: add '.git' to 'make lint-py' exclude list (cclauss) #24802bfec6a4eb3] - build: fix check-xz for platforms defaulting to sh (Rod Vagg) #248413a24c91c7d] - build: make tar.xz creation opt-out, fail if no xz (Rod Vagg) #245516b71099303] - build: add line break as soon tests are done (Ruben Bridgewater) #24748e0e15da6ca] - build: fix line length off by one error (Ruben Bridgewater) #247483fe4498fe1] - build: fix c++ code coverage on macOS (Refael Ackermann) #24520955819e0a3] - build: only check REPLACEME & DEP...X for releases (Rod Vagg) #245753fa4def6ea] - build: replace-notwith!infind(Rich Trott) #24635e37c6182e5] - build: fix Python detection when depot_tools are in PATH in Windows (Guy Bedford) #2253939614add79] - build: remove sudo:false from .travis.yml (Rich Trott) #2451121e59a68cf] - build: use print() function in configure.py (cclauss) #244844dc1e785a3] - build: check minimum ICU in configure for system-icu (Steven R. Loomis) #24255c5e32fdebf] - build: remove unnecessary prerequisite in Makefile (Rich Trott) #24342383d8092b1] - build, tools, win: add .S files support to GYP (Bartosz Sosnowski) #24553bd4df5b326] - build,src: sync src files with node.gyp (Refael Ackermann) #24505331b26eda9] - build,tools: update make-v8.sh for ppc64le (Refael Ackermann) #24293706bc414b9] - (SEMVER-MINOR) build,win: pack the install-tools scripts for dist (Refael Ackermann) #24233b214ae44c8] - cli: add missing env vars to --help (cjihrig) #2438350005e7ddf] - console: improve code readability (gengjiawen) #2441212feb9e492] - crypto: harden bignum-to-binary conversions (Ben Noordhuis) #24719c15efcec92] - crypto: convert to arrow function (yosuke ota) #2459716d70603a1] - crypto: allow monkey patching of pseudoRandomBytes (Gerhard Stoebich) #241087c29e9b83b] - crypto: remove unnecessary fully qualified names (Gagandeep Singh) #244520afcb9ad3a] - deps: cherry-pick 88f8fe1 from upstream V8 (Yang Guo) #2451461179e6cfe] - deps: cherry-pick 073073b from upstream V8 (Yang Guo) #24515230eb0dde9] - deps: update llhttp to 1.0.1 (Fedor Indutny) #2450806c28b9d75] - deps: upgrade to libuv 1.24.0 (cjihrig) #243322dfaa480de] - dns: simplify dns.promises warning logic (cjihrig) #247885a1fb1e663] - doc: mention util depth default change (Ruben Bridgewater) #24805d800998161] - doc: list all versions WHATWG URL api was added (Thomas Watson) #2484771e520cfa6] - doc: add authority and scheme psuedo headers (Kenigbolo Meya Stephen) #247775b78d2c504] - doc: remove duplicate whitespaces in doc/api (Yusuke Kawasaki)162b3a12b6] - doc: add triaging section to releases.md (Beth Griggs) #20165b8611a384a] - doc: use author's titles for linked resources (Rich Trott) #24837566046ca4e] - doc: revise code review guidelines (Rich Trott) #247903d1853b178] - doc: add a note on usage scope of AliasedBuffer (Gireesh Punathil) #24724997c0e05a4] - doc: hide undocumented object artifacts in async_hooks (Gireesh Punathil) #2474158e5c00c9b] - doc: fix added version of randomFill+randomFillSync (Thomas Watson) #24812751d961d29] - doc: streamline Accepting Modifications in Collaborator Guide (Rich Trott) #24807c09ea83869] - doc: make release README link be consistent with text (ZYSzys) #2478306011f501d] - doc: fix REPLACEME for tls min/max protocol option (Sam Roberts) #247594d41c8f6d6] - doc: add missing changes entry (Ruben Bridgewater) #2475825e5164cf1] - doc: cookie is joined using '; ' (Gerhard Stoebich) #2474066d83305f8] - doc: sort bottom-of-file markdown links (Sam Roberts) #24679654bd65464] - doc: remove trailing whitespace (Daijiro Wachi) #2464268dc100565] - doc: describe current HTTP header size limit (Sam Roberts) #24700b3e77a5690] - doc: fix nits in http(s) server.headersTimeout (Vse Mozhet Byt) #246973288c27453] - doc: add antsmartian to collaborators (Anto Aravinth) #2465585aa03085d] - doc: revise accepting-modifications in guide (Rich Trott) #246502ebb32b480] - doc: document fs.write limitation with TTY (Matteo Collina) #245715a47c2e7d3] - doc: clarify symlink resolution for __filename (Rich Trott) #24587b65ffd5b1d] - doc: use arrow function for anonymous callbacks (koki-oshima) #24606d4491a48ba] - doc: revise handling-own-pull-requests text (Rich Trott) #24583663d1c8823] - doc: fix duplicate "this" and "the" on http2.md (Yusuke Kawasaki) #246118d550f7888] - doc: replace anonymous function with arrow function (ka2jun8) #24617657d7a5f9d] - doc: use arrow function (sadness_ojisan) #24590f80e7a13fb] - doc: replace anonymous function with arrow function (yuriettys) #246275796c6aba4] - doc: mark napi_add_finalizer experimental (Michael Dawson) #245724da44ada88] - doc: clarify who may land on an LTS staging branch (Myles Borins) #244657463a7f5cf] - doc: reviseauthor readyexplanation (Rich Trott) #2455841f2e36046] - doc: add readable and writable property to Readable and Writable (Dexter Leng) #23933580eb5ba66] - doc: move trott to tsc emeritus (Rich Trott) #244921a74fad1cd] - doc: add Ruben Bridgewater to release team (Ruben Bridgewater) #23432672a31c91b] - doc: edit COLLABORATOR_GUIDE.md on closing issues (Rich Trott) #244776d147efa92] - doc: move Timothy to TSC emeritus (Timothy Gu) #2453591494bf023] - doc: add NODE_DEBUG_NATIVE to API docs (cjihrig) #243836e4a12062a] - doc: add missing env variables to man page (cjihrig) #2438348852cc51f] - doc: minor cleanup of tls.getProtocol() (Sam Roberts) #24533d34527177c] - doc: add Beth Griggs to release team (Beth Griggs) #24532dadc2eb62d] - (SEMVER-MINOR) doc: describe certificate object properties (Sam Roberts) #243589ab2bcf97c] - doc: update 11.0.0 changelog with missing commit (Rich Trott) #24404a499db714c] - doc: add filehandle.write(string[, position[, encoding]]) (Dara Hayes) #23224cf2306d380] - doc: udpate list item spacing in changelogs (Rich Trott) #24391ed78339a6b] - doc: update crypto examples to not use deprecated api (Mayank Asthana) #241075c4f569857] - doc: simplify first-time contributors section of Collaborator Guide (Rich Trott) #2438781ec97ba3d] - doc: adjusting formatting when printing (Thomas Hunter II) #24325a3599a5067] - doc: better linkage to node-addon-api (Michael Dawson) #243715f747f1dc5] - doc: add help on fixing IPv6 test failures (Michael Dawson) #2437285f9201687] - doc: update collaborator guide with LTS labels (Charalampos Fanoulis) #243792245e5e484] - doc,meta: update PR approving info (Vse Mozhet Byt) #245611743568975] - esm: refactor dynamic modules (Myles Borins) #24560dd89cfeb30] - events: extract listener check as a function (ZYSzys) #24303124fca0267] - fs: simplify fs.promises warning logic (cjihrig) #24788b1622a2c92] - fs: inline typeof check (dexterleng) #24390c8d5e31db4] - (SEMVER-MINOR) http: make parser choice a runtime flag (Anna Henningsen) #247391f8787c32d] - http: destroy the socket on parse error (Luigi Pinca) #247573fe3bc961f] - http: fix error return inFinish()(Fedor Indutny) #24738798504a8c9] - http2: make compat writeHead not crash if the stream is destroyed (Matteo Collina) #2472361e0103d60] - http2: add compat support for nested array headers (Sebastiaan Deckers) #24665091238a9a7] - http2: fix session[kSession] undefined issue (leeight) #245475051e1bdab] - http2: cleanup endStream logic (James M Snell) #2406381a7056378] - http2: set js callbacks once (James M Snell) #24063cd7df56903] - http2: throw from mapToHeaders (James M Snell) #24063f5e9bb1b39] - http2: replace unreachable error with assertion (Rich Trott) #244071f544999af] - http2: order declarations in http2.js (ZYSzys) #24411454883b6ce] - http2: elevate v8 namespaces of repeated references (Gagandeep Singh) #2445373bc5fd39a] - Revert "lib: repl multiline history support" (Ruben Bridgewater) #248046c8a73de33] - lib: remove some useless assignments (Gus Caplan) #231991ec4f8dc3d] - lib: remove duplicated noop function (ZYSzys) #24770eab981e76f] - lib: do not register DOMException in a module (Joyee Cheung) #24708d77cf929cf] - lib: move setupAllowedFlags() into per_thread.js (Joyee Cheung) #24704b1d3747b5b] - lib: convert to arrow function in fs.js (exoego) #2460497b803fa13] - lib: change callbacks to arrow function (/Jesse) #246251c4bc86388] - lib: chenged anonymous function to arrow function (nakashima) #2460583ab5f4049] - lib: rearm pre-existing signal event registrations (Gireesh Punathil) #246516f42b98a1a] - lib: convert to arrow function (horihiro) #24623e5c85ef886] - lib: convert to Arrow Function (Daiki Arai) #246151063e0c92c] - lib: fix comment nits in bootstrap\loaders.js (Vse Mozhet Byt) #246413df8633b86] - lib: suppress crypto related env vars in help msg (Daniel Bevenius) #2455659c2ee0c37] - lib: convert to arrow function (Naojirou Hisada) #24596a8e93f7691] - lib: change anonymous function to arrow function (takato) #24589b2c243ff8b] - lib: simplify own keys retrieval (Vse Mozhet Byt) #2458235a76460b8] - lib: fix nits in lib/internal/bootstrap/cache.js (Vse Mozhet Byt) #24581daeb34809a] - lib: move encodeStr function to internal for reusable (ZYSzys) #24242e14abfe432] - lib: refactor setupInspector in bootstrap/node.js (leeight) #24446e16ff521d4] - lib: set stderr._destroy to dummyDestroy (Joyee Cheung) #24398bc5a0d3c05] - lib: gather all errors constant in the same place for consistency (ZYSzys) #240380c51fc51b0] - n-api: handle reference delete before finalize (Michael Dawson) #244947ef516a9de] - n-api,test: remove last argument in assert.strictEqual() (susantruong) #24584e82f67d710] - Revert "net: partially revert "simplify Socket.prototype._final"" (Anna Henningsen) #24290a1254a3e90] - (SEMVER-MINOR) net,dgram: add ipv6Only option for net and dgram (Ouyang Yadong) #2379824acd53cc4] - net,http2: merge after-write code (Anna Henningsen) #243805874a03f39] - process: refactor the bootstrap mode branching for readability (Joyee Cheung) #24673effe30777b] - process: fix omitting--fromprocess.execArgv(Anna Henningsen) #2465481b42d2258] - process: emit unhandled warning immediately (Anatoli Papirovski) #24632b22e95d5ed] - (SEMVER-MINOR) readline: add support for async iteration (Timothy Gu) #239166fed6f5e1f] - Revert "repl: handle buffered string logic on finish" (Ruben Bridgewater) #24804bd8be407b1] - repl: handle buffered string logic on finish (Anto Aravinth) #243895bd33f18ea] - src: fix type mismatch warnings from missing priv (Sam Roberts) #247377c70b6192b] - src: move version metadata into node_metadata{.h, .cc} (Joyee Cheung) #2477453b59b4066] - src: move READONLY_* macros into util.h (Joyee Cheung) #24774c957adb171] - src: use custom TryCatch subclass (Gus Caplan) #24751ecbe616b9d] - src: use arraysize instead of hardcode number (leeight) #244730e88f44547] - src: set HAS_USERNAME/PASSWORD more strictly (Timothy Gu) #24495193f315560] - src: elevate v8 namespaces for node_process.cc (Jayasankar) #24578f28fdc96ef] - src: remove unused context variable in node_serdes (Daniel Bevenius) #247130148c1d4f9] - src: elevate v8 namespaces referenced (Juan José Arboleda) #24657f31292dff3] - src: move C++ binding/addon related code into node_binding{.h, .cc} (Joyee Cheung) #2470187c864cd5e] - src: remove unused variables in node_util.cc (Daniel Bevenius) #24717a122ba598e] - src: simplify LibuvStreamWrap::DoWrite (Anna Henningsen) #24588b554ff7620] - src: replace create new Array (kohta ito) #24618c26b10caeb] - src: migrate to new V8 array API (Yoshiya Hinosawa) #24613c708abb3ba] - src: use NativeModuleLoader to compile per_context.js (Joyee Cheung) #246609caad06d6f] - src: simplify uptime and ppid return values (cjihrig) #24562dca1ecffbd] - src: replace array implementation (kazuya kawaguchi) #24614955a8a720a] - src: replace new Array creation (kohta ito) #246018a91fc1af0] - src: elevate v8 namespaces for node_url.cc (Jayasankar) #24573aa220cf9d7] - src: enable detailed source positions in V8 (Yang Guo) #24515b9bd4e9d09] - src: add include for standalone compile (Gary Hsu) #244982565ff0785] - src: elevate namespaces for repeated entities (Sarath Govind K K) #24475b8ed930674] - src: elevate namespaces of repeated artifacts (Maya Anilson) #24429216f751b2a] - src: elevate v8 namespaces of node_trace_events.cc (Jayasankar) #2446921e9aa2bf4] - src: use STL containers instead of v8 values for static module data (Joyee Cheung) #24384873dee9789] - src: elevate v8 namespaces of repeated references (leeight) #24460aa481c4198] - src: elevate repeated use of v8 namespaced type (Shubham Urkade) #24427ea862acc7a] - src: use smart pointers in cares_wrap.cc (Daniel Bevenius) #2381353fac5c0d3] - src: fix compiler warning (cjihrig) #23954c2fde2124f] - src: remove unused variables (Anna Henningsen) #23880dba003cbff] - src: include util-inl.h in worker_agent.cc (Anna Henningsen) #2388025a9eee9fd] - src: add direct dependency on\*-inl.hfile (Refael Ackermann) #2380833e7f6e953] - src: add AliasedBuffer::reserve (Refael Ackermann) #2380874c0a97a96] - src: clean clang-tidy errors in node_file.h (Refael Ackermann) #23793260d77710e] - src: fix resource leak in node::fs::FileHandle (Refael Ackermann) #23793c0a9a83c51] - src: refactor FillStatsArray (Refael Ackermann) #237935061610094] - src: removeEnvironment::tracing\_agent\_writer()(Anna Henningsen) #23781af3c7efffc] - src: factor out Node.js-agnostic N-APIs (Gabriel Schulhof) #23786b44623e776] - src: elevate v8 namespaces of referenced artifacts (Kanika Singhal) #24424a7f6c043a4] - Revert "src: enable detailed source positions in V8" (Refael Ackermann) #243945d67eeca1a] - src: emit warnings from V8 (Gus Caplan) #24365fa9e03c1a7] - src: re-sort the symbol macros (Sam Roberts) #243822d885ed0f9] - src: fix compiler warning in node_os (Daniel Bevenius) #24356806570d80a] - src: remove unused variables (Daniel Bevenius) #2435588a54497e5] - src,lib: make process.binding('config') internal (Masashi Hirano) #23400b809fa8571] - stream: make async iterator .next() always resolve (Matteo Collina) #2466899b018bf48] - stream: use arrow function for callback (DoiChris) #24609ba1ebb4a40] - stream: correctly pause and resume after once('readable') (Matteo Collina) #243667bc2011ad9] - stream: do not use crypto.DEFAULT_ENCODING in lazy_transform.js (Joyee Cheung) #2439601e8a3a8d5] - stream: change comment on duplex stream options (Jesse W. Collins) #242470ed669cf65] - test: remove unused addons-napi directory (Rich Trott) #248397069ed7546] - test: add .gitignore file for node-api (Rich Trott) #24839c227b1be16] - test: partition N-API tests (Gabriel Schulhof) #2455763b06b55d7] - test: fixcommon.mustNotCall()usage in HTTP test (Anna Henningsen) #24750cc133c4432] - test: use ES2017 syntax in test-fs-open-* (jy95) #23031a7a1cb48f5] - test: check for the correct strict equal arguments order (Ruben Bridgewater) #2475295720089d5] - test: add flag scenario in test-fs-write-file-sync (Gireesh Punathil) #247665f58928b06] - test: improve comparison coverage to 100% (Ruben Bridgewater) #247497577e754bb] - test: check invalid argument error for option (timothy searcy) #247362916b592d3] - test: increase assert test coverage (Ruben Bridgewater) #24745085f5b6366] - test: show stdout and stderr in test-cli-syntax when it fails (Joyee Cheung) #24720026e03cf35] - test: minor refactoring of onticketkeycallback (Daniel Bevenius) #2471810c2773da8] - test: mark test_threadsafe_function/test as flaky (Gireesh Punathil) #247148ffe04f533] - test: verify order of error in h2 server stream (Myles Borins) #246853c3ebe57f6] - test: cover path empty string case (lakatostamas) #24569089489965c] - test: use arrow syntax for anonymous callbacks (Shubham Urkade) #24691d5bf7362b9] - test: fix the arguments order in assert.strictEqual (pastak) #246201035e36de6] - test: mark test-vm-timeout-escape-nexttick flaky (Gireesh Punathil) #24712603bc2751e] - test: fix the arguments order in assert.strictEqual (sigwyg) #24624969ae7a598] - test: fix the arguments order inassert.strictEqual(rt33) #24626e96c60e472] - test: reach res._dump after abort ClientRequest (Tadhg Creedon) #24191053f3d6289] - test: validate fs.rename() when NODE_TEST_DIR on separate mount (Drew Folta) #247079e1c6eb6aa] - test: test and docs for detached fork process (timothy searcy) #24524992a9040bf] - test: fix arguments order inassert.strictEqual(sota1235) #24607f8acf73ae7] - test: fix arguments order in assert.strictEqual (grimrose) #2460884249dfac6] - test: make test-uv-binding-constant JS engine neutral (Rich Trott) #246660a492c730a] - test: use arrow function (sagirk) #244828072a2b85c] - test: fix arguments order inassert.strictEqual(Takahiro Nakamura) #246219d5455515c] - test: use arrow functions in callbacks (apoorvanand) #2444199dbdca73b] - test: update strictEqual argument order (VeysonD) #246223b99191e13] - test: fix argument order in assert.strictEqual (feng jianmei) #24594d6fff0e618] - test: add test for socket.end callback (ajido) #24087abb1c64c2d] - test: replace anonymous closure functions with arrow functions (tpanthera) #24443b7aa312672] - test: fix arguments order inassert.strictEqual(tottokotkd) #24612a82b420883] - test: convert callback to arrow function (jamesgeorge007) #245137edea030af] - test: change anonymous function to arrow function (Gagandeep Singh) #24528a701dfbb2b] - test: split out http2 from test-stream-pipeline (Rich Trott) #246318849d8073a] - test: cover path.basename when path and ext are the same (Laszlo.Moczo) #2457012d7107edc] - test: fix assert.strictEqual (mki-skt) #2461954778a082a] - test: fix arguments order in assert.strictEqual (teppeis) #24591cd1aa2b0b5] - test: fix http2-binding strictEqual order (dominikeinkemmer) #2461682ef618e98] - test: fix the arguments order inassert.strictEqual(sota1235) #245951067653221] - test: replace callback with arrow functions (prodroy1) #24434363d3c6deb] - test: use destructuring on require (Juan José Arboleda) #2445534b40af5ab] - test: fix test case in test-child-process-fork-dgram.js (gengjiawen) #2445940701520ce] - test: replace callback with arrow functions (sreepurnajasti) #245412a67a49053] - test: replace callback with arrow function (potham) #2453139adfc8d48] - test: replace anonymous function with arrow (Gagandeep Singh) #245276b88541fe2] - test: replace anonymous function with arrow (Gagandeep Singh) #24526765a81e32a] - test: add information to assertion (Rich Trott) #24566759ed86e5c] - test: replace anonymous function with arrow func (Gagandeep Singh) #245259bf2659af4] - test: change anonymous closure function to arrow function (Nethra Ravindran) #24433e8c0fcee95] - test: replace closure functions with arrow functions (Gagandeep Singh) #245222c8c7b882d] - test: replace anonymous function with arrow function (Gagandeep Singh) #245297b0292a839] - test: favor arrow function in callback (Pranay Kothapalli) #245428fcf3b3c59] - test: remove unused reject handlers (Dan Foley) #2454046b5df0f1f] - test: refactor test to use arrow functions (sagirk) #24479c28ec86c90] - test: replace closure with arrow function (Maya Anilson) #244891cd73a81fa] - test: using arrow functions (NoSkillGirl) #24436b309dd2be3] - test: replace anonymous closure with arrow func (suman-mitra) #24480c4f16ddccd] - test: replace callback with arrow functions (sreepurnajasti) #24490dbf14ce17b] - test: replcae anonymous closure with arrow function (Sarath Govind K K) #244764792bea514] - test: refactor test-http-write-empty-string to use arrow functions (sagirk) #24483c45660fd53] - test: replace anonymous closure with arrow functions (suman-mitra) #24481f19dae33e6] - test: replace anonymous closure functions with arrow functions (sagirk) #24478fbb228be97] - test: replace anonymous closure functions with arrow function (Abhishek Dixit) #24420c15208cb8f] - test: replace anonymous closure with arrow funct (Prabu Subra) #244398f18f0d5bd] - test: add whatwg-encoding TextDecoder custom inspection with showHidden (ZauberNerd) #2416633b524203b] - test: use Worker scope in WPT (Joyee Cheung) #24410ed714a2e79] - test: modify order of parameters for assertion (Mrityunjoy Saha) #244303bfa953990] - test: replace closure with arrow functions (kanishk30) #244407d743e659d] - test: replace anonymous closure function with arrow function (Kunda Sunil Kumar) #24435e9abf42751] - test: add typeerror test for EC crypto keygen (Matteo) #24400237e479196] - test: change anonymous closure functions to arrow functions (Namit Bhalla) #244182f0a5b6a45] - test: favor arrow functions in callbacks (UjjwalUpadhyay) #24425957ecbe019] - test: use print() function on both Python 2 and 3 (cclauss) #24485b1dee7dab6] - test: replace anonymous closure functions with arrow function (Amanpreet) #244174348ffede5] - test: fix arguments order in napi test_exception (kanishk30) #244130a08cd714e] - test: fix the arguments order inassert.strictEqual(Jay Arthanareeswaran) #24416585ebfffa7] - test: replace closure with arrow functions (Amanpreet) #24438d5543ead7c] - test: change callback function to arrow function (Jay Arthanareeswaran) #244195d663100a0] - test: fix the arguments order inassert.strictEqual(apoorvanand) #244319b2ab12b8c] - test: assertion equality fix (NoSkillGirl) #244222777bc42aa] - test: remove unused function arguments in async-hooks tests (Simon Bruce) #2440659723d4b2b] - test: fix actual parameter order for 'assert.strictEqual' (Selvaraj) #24428658df6ba26] - test: swap actual&optional params (Nikhil M) #24426de378c0c2d] - test: skip test that use --tls-v1.x flags (Daniel Bevenius) #24376c1777990ae] - test: change callback function to arrow function (Lakshmi Shanmugam) #24421ffb5e5da4b] - test: replace anonymous closure for test-http-expect-handling.js (Jayasankar) #244233fadc809bb] - test: replace callback functions with arrow functions (potham) #24432856a0fc8e4] - test: use arrow functions for callbacks (Pushkal B) #24444f112c06b3e] - test: replace anonymous closure function (Jayasankar) #244156dd29252c7] - test: fixed the arguments order inassert.strictEqual(Lakshmi Shanmugam) #244147e2a2849db] - test: use destructuring and remove unused arguments (Julia) #24375cdda7f4f18] - test: https agent clientcertengine coverage (Osmond van Hemert) #2424892f826622b] - test: confirm tls server suite default is its own (Sam Roberts) #24374261aa7884c] - test: cover tls multi-identity option mixtures (Sam Roberts) #243743c2fb883b4] - test: add independent multi-alg crypto identities (Sam Roberts) #243742fc9550280] - test: rename agent1-pfx.pem to agent1.pfx (Sam Roberts) #24374ee64ae0f6d] - test: remove unused function arguments in async-hooks tests (Rich Trott) #24368d2e9b76c1d] - timers: fix setTimeout expiration logic (Suguru Motegi) #24214acb73518b7] - (SEMVER-MINOR) tls: add min/max protocol version options (Sam Roberts) #24405f30c7c4911] - (SEMVER-MINOR) tls: include RSA bit size in X.509 public key info (Sam Roberts) #2435837f0bd7e3a] - (SEMVER-MINOR) tls: include elliptic curve X.509 public key info (Sam Roberts) #2435871a9c987b2] - tls: destroy TLS socket if StreamWrap is destroyed (Anna Henningsen) #242900c93b125e4] - tls: do not rely on 'drain' handlers in StreamWrap (Anna Henningsen) #24290249c143703] - tools: prepare tools/install.py for Python 3 (cclauss) #248001ea01c5790] - tools: replace rollup with ncc (Rich Trott) #2481309cd2ec034] - tools: fix eslint usage for Node.js 8 and before (Ruben Bridgewater) #247539e5a79a192] - tools: don't use GH API for commit message checks (Rod Vagg) #24574e3649c8e09] - tools: only sign release if promotion successful (Rod Vagg) #246692ef6aed58a] - tools: check for git tag before promoting release (Rod Vagg) #24670e7fbdf5784] - tools: update remark-preset-lint-node to v1.3.1 (Daijiro Wachi) #2464223d815292f] - tools: use print() function on both Python 2 and 3 (cclauss) #2448613a4d10f67] - tools: update to remark-lint-preset-node@1.2.0 (Rich Trott) #243915748e862b0] - tools: fixmake lint-md-rollupand run it (Daijiro Wachi) #243337ffc8b7778] - tools: update remark-lint to v6.0.3 from v6.0.2 (Daijiro Wachi) #24333b9a4bc15c2] - tools: update remark version to v10 from v8 (Daijiro Wachi) #243331625329fbf] - tools,doc: fix version picker bug in html.js (Rich Trott) #24638b6004b3651] - trace_events: forbid tracing modifications from worker threads (Anna Henningsen) #23781d881b33028] - (SEMVER-MINOR) url: support LF, CR and TAB in pathToFileURL (Charles Samborski) #23720540929d597] - url: simplify native URL object construction (Timothy Gu) #244950d7ee19786] - url: reuse existing context in href setter (Timothy Gu) #2449596e6873dd0] - Revert "url: make the context non-enumerable" (Timothy Gu) #24495be54dc0f72] - url: use SafeSet to filter known special protocols (Mike Samuel) #247035a853a093c] - Revert "util: change util.inspect depth default" (Gus Caplan)807c108be8] - util: improve internalisError()validation (Ruben Bridgewater) #24746764d76f684] - Revert "util: change %o depth default" (Ruben Bridgewater) #248069e8f91dbc7] - util: remove unreachable branch (rahulshuklab4u) #24447e13571c199] - (SEMVER-MINOR) util,console: handle symbols as defined in the spec (Ruben Bridgewater) #237084d9a2650b2] - win: do not use Boxstarter to install tools (João Reis) #24677899e7c30b0] - win, build: skip building cctest by default (Bartosz Sosnowski) #21408Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes