-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update fs.open() changes record for optional 'flags' #24240
Conversation
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
hey @vsemozhetbyt & @cjihrig would you mind taking a look at the latest update here? I've given fs.openSync the same treatment and also copied the change doc for the |
@rvagg do the promises versions of these also need to be updated? |
yeah, |
It seems the doc section for - * `flags` {string|number} See [support of file system `flags`][].
+ * `flags` {string|number} See [support of file system `flags`][]. **Default:** `'r'`. |
711db29
to
d8479c0
Compare
d8479c0
to
a39e208
Compare
Thanks @vsemozhetbyt, added that change to another fixup commit |
Landed in 1532232 |
Was missed on original PR. Ref: nodejs#23767 PR-URL: nodejs#24240 Refs: nodejs#23767 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Was missed on original PR. Ref: nodejs#23767 PR-URL: nodejs#24240 Refs: nodejs#23767 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Was missed on original PR.
Ref: #23767