test: fix flaky test-vm-timeout-escape-nexttick #24251
Conversation
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: nodejs#24120
|
@nodejs/build Is there an easy way to run a stress test on a Pi2 device? |
|
Baseline stress
Not ATM, well not simple. You could patch Lines 444 to 447 in 1f6c4ba I'll see if I can make it simpler. |
@refack Compilation or something failed for both... |
Again... |
|
@refack Getting closer. The second one seemed to fail on git somewhere/somehow? |
|
PR: https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/98/ But we don't have a repro with More intense stress on |
|
FWIW, we were seeing it on the Pi2 devices, which might have a different (lower) common.platform() multiplier, so maybe testing on Pi1 is not the way to go? But I don't see an easy way to test on Pi2 or Pi3, unfortunately.... |
Trying to get the job to run on all 3 PI versions: |
|
Job 100 fails indeed on PI2 |
|
Results are looking promising so far. Thanks for handling the CI finessing, @refack! |
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18445/ (Failure on FreeBSD is a known and unrelated flaky.) |
|
This changes a 24% failure on Pi2 to a 0% failure. Fixing CI so proposing to fast-track. Collaborators, please 👍 here to approve. |
Trott
added
author ready
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: nodejs#24120 PR-URL: nodejs#24251 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in a4a2e9f |
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: #24120 PR-URL: #24251 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: nodejs#24120 PR-URL: nodejs#24251 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: #24120 PR-URL: #24251 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.
Fixes: #24120
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes