Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: make Http2ServerResponse#end() always return this #24346

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Nov 13, 2018

Http2Response.end can return false instead of this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag force-pushed the nxtedition:http2-compat-end-return-this branch from 0ab5abc to 11e7f62 Nov 13, 2018

@lpinca
lpinca approved these changes Mar 10, 2019
@lpinca

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@lpinca lpinca changed the title Http2 compat end return this http2: Make Http2ServerResponse#end() always return this Mar 10, 2019

@lpinca

This comment has been minimized.

@mcollina
Copy link
Member

left a comment

LGTM

@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@lpinca lpinca referenced this pull request Mar 11, 2019
4 of 4 tasks complete

@lpinca lpinca changed the title http2: Make Http2ServerResponse#end() always return this http2: make Http2ServerResponse#end() always return this Mar 11, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Landed in 90fdf1b 🎉

@BridgeAR BridgeAR closed this Mar 12, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
http2: `Http2ServerResponse.end()` should always return self
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.