New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add DCHECK macros #24359

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@kiyomizumia
Copy link
Contributor

kiyomizumia commented Nov 14, 2018

Refactored and removed some debug #ifdef statements.

@addaleax
Copy link
Member

addaleax left a comment

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 14, 2018

@kiyomizumia Do you think you could rebase out the merge commits here, and/or squash the commits together? Our CI doesn’t play too well with merge commits, sadly :/

@kiyomizumia kiyomizumia force-pushed the kiyomizumia:cppcode branch from 53039ba to 602eb98 Nov 15, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 16, 2018

@kiyomizumia I think something went wrong when rebasing here… I think this should work:

$ git checkout cppcode
$ git fetch upstream 
$ git rebase -i upstream/master
# delete all lines except the last 2 ones (your commits)
$ git push --force-with-lease

Could you try that?

kiyomizumia added some commits Nov 14, 2018

src: refactored and removed some ifdef debug statements
test: fixed order of actual and expected arguments

src: ifdef changes

src: refactored and removed some ifdef debug statements
@kiyomizumia

This comment has been minimized.

Copy link
Contributor

kiyomizumia commented Nov 19, 2018

@addaleax I should remove all of the commits except mine, correct? There are quite a few of them...

@kiyomizumia kiyomizumia force-pushed the kiyomizumia:cppcode branch from 602eb98 to 07c92d3 Nov 19, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 19, 2018

@kiyomizumia Yes, correct… the last one in this PR (07c92d3) seems to be a bit odd and should probably be left out, but since there are no merge commits anymore, I think we can run CI:

CI: https://ci.nodejs.org/job/node-test-pull-request/18748/

@addaleax addaleax referenced this pull request Nov 22, 2018

Closed

src: add DCHECK macros #24563

2 of 2 tasks complete
@joyeecheung
Copy link
Member

joyeecheung left a comment

CI is happy. Whoever lands this be sure to leave out the first commit.

@joyeecheung
Copy link
Member

joyeecheung left a comment

BTW it's the last commit that needs to be dropped..also, the first two commits looks a bit odd - the first one not only adds the macro but also drops #ifdef DEBUG in base_object-inl.h without making the CHECKs DCHECK, while the second commit also contains whitespace changes to util.h. I'd suggest either squash them all into one commit during landing, or use some git magic to split into two commits where one only contains changes to util.h and the other one contains other changes to src.

Show resolved Hide resolved src/stream_base.cc

@kiyomizumia kiyomizumia force-pushed the kiyomizumia:cppcode branch from 07c92d3 to 4f6fdbd Nov 24, 2018

@joyeecheung

This comment has been minimized.

@Trott Trott removed the author ready label Nov 25, 2018

@joyeecheung joyeecheung referenced this pull request Nov 28, 2018

Closed

src: migrate to new V8 array API #24613

2 of 2 tasks complete
@joyeecheung

This comment has been minimized.

Copy link
Member

joyeecheung commented Nov 28, 2018

Ping @kiyomizumia , do you have time to add the missing endif? (I believe you can just click the apply suggestion button in #24359 (comment) instead of making the change locally and pushing again)

@joyeecheung

This comment has been minimized.

Copy link
Member

joyeecheung commented Dec 6, 2018

Ping @kiyomizumia again...if you don't mind can I push to the PR branch? I want to get this landed so that DCHECK macros can be used in the code base.

@kiyomizumia

This comment has been minimized.

Copy link
Contributor

kiyomizumia commented Dec 7, 2018

@joyeecheung Okay, go ahead!

Update src/inspector/node_string.h
Co-Authored-By: kiyomizumia <42000558+kiyomizumia@users.noreply.github.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 7, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 19, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 24, 2018

@joyeecheung joyeecheung changed the title Cppcode src: add DCHECK macros Dec 24, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 24, 2018

src: add DCHECK macros
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: nodejs#24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 24, 2018

Landed in 71bc7e1 🎉

@BridgeAR BridgeAR closed this Dec 24, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

src: add DCHECK macros
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: #24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

src: add DCHECK macros
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: #24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: add DCHECK macros
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: nodejs#24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment