Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix c++ code coverage on macOS #24520

Merged
merged 1 commit into from Dec 1, 2018
Merged

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 20, 2018

Alternative to #24004

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 20, 2018
@refack
Copy link
Contributor Author

refack commented Nov 20, 2018

@refack refack added macos Issues and PRs related to the macOS platform / OSX. coverage Issues and PRs related to native coverage support. labels Nov 20, 2018
@refack
Copy link
Contributor Author

refack commented Nov 20, 2018

/CC @nodejs/build-files @nodejs/gyp

@refack refack self-assigned this Nov 20, 2018
@refack
Copy link
Contributor Author

refack commented Nov 20, 2018

I tested this on https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/, and it builds and links
node.zip

But I get this from nyc:


> bash-3.2$ NODE_DEBUG=nyc ./node ./node_modules/.bin/nyc instrument --extension .js --extension .mjs --exit-on-error lib_/ lib/ > nyc.log 2> nyc.err

profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: mismatched number of counters (10)
profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: corrupt arc tag (0x344e496f)
.
.
.
Segmentation fault: 11

P.S. it's actually just the node binary:

> ./node -p 'process.version'
v12.0.0-pre
profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: mismatched number of counters (10)
.
.
.

nyc.zip

@refack
Copy link
Contributor Author

refack commented Nov 26, 2018

/CC @nodejs/build-files @nodejs/gyp (CI had just a flake)

@Trott
Copy link
Member

Trott commented Dec 1, 2018

@Trott
Copy link
Member

Trott commented Dec 1, 2018

PR-URL: nodejs#24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott merged commit eb6741b into nodejs:master Dec 1, 2018
@Trott
Copy link
Member

Trott commented Dec 1, 2018

Landed in eb6741b

BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refack refack removed their assignment Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. coverage Issues and PRs related to native coverage support. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants