http2: fix session[kSession] undefined issue #24547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
leeight
force-pushed
the
fix-24546
branch
3 times, most recently
from
d30c6a3
to
1cd1023
Compare
oyyd
reviewed
Nov 21, 2018
jasnell
approved these changes
Nov 21, 2018
lpinca
approved these changes
Nov 21, 2018
|
@leeight looks good, thanks |
oyyd
approved these changes
Nov 22, 2018
`finishSessionDestroy` already done session cleaning up. Fix: nodejs#24546
Co-Authored-By: leeight <leeight@gmail.com>
cjihrig
approved these changes
Nov 22, 2018
|
Landed in 895fe2f |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 25, 2018
`finishSessionDestroy` session cleanup when already done. PR-URL: nodejs#24547 Fixes: nodejs#24546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 7, 2018
davedoesdev
added a commit
to davedoesdev/centro
that referenced
this pull request
Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
`finishSessionDestroy` session cleanup when already done. PR-URL: nodejs#24547 Fixes: nodejs#24546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishSessionDestroyalready done session cleaning up.Fix: #24546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes