Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix comment nits in bootstrap\loaders.js #24641

Conversation

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 25, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

vsemozhetbyt commented Nov 25, 2018

As only comments are changed, it seems CI-lite suffices. Let me know if we need full CI.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

vsemozhetbyt commented Nov 25, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@lpinca
lpinca approved these changes Nov 26, 2018
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

vsemozhetbyt commented Nov 27, 2018

Landed in 1db808c
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:lib-internal-bootstrap-loaders.js branch Nov 27, 2018
vsemozhetbyt added a commit that referenced this pull request Nov 27, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos added a commit that referenced this pull request Nov 27, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
GaryGSC added a commit to GaryGSC/node that referenced this pull request Nov 8, 2019
PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

(cherry picked from commit 1db808c)
GaryGSC added a commit to GaryGSC/node that referenced this pull request Nov 8, 2019
Backport-PR-URL: nodejs#30338

PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

(cherry picked from commit 1db808c)
BethGriggs added a commit that referenced this pull request Nov 22, 2019
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.