Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: do not register DOMException in a module #24708

Closed
wants to merge 1 commit into from
Closed

lib: do not register DOMException in a module #24708

wants to merge 1 commit into from

Commits on Nov 28, 2018

  1. lib: do not register DOMException in a module 

    Instead of registering it in a global scope of a native module
and expecting that it only gets evaluated when the module is actually
compiled and run and will not be evaluated because the module can
be cached, directly register the DOMException constructor
onto Environment during bootstrap for clarity, since this is
a side effect that has to happen during bootstrap.
    @joyeecheung
    joyeecheung committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    0023b6e View commit details
    Browse the repository at this point in the history