Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bailout test_threadsafe_function/test #24714

Merged
merged 1 commit into from Dec 1, 2018

Conversation

@gireeshpunathil
Copy link
Member

commented Nov 29, 2018

This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Ref: #23621
Ref: #24607
/cc @Trott

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Waiting for #24712 to land before re-running CI.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/19046/

Might need a full CI re-run to incorporate the change from #24712 if that test continues to fail, but I'm not sure about that.

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2018

10:26:12 not ok 312 known_issues/test-vm-timeout-escape-nexttick
10:26:12   ---
10:26:12   duration_ms: 7.165
10:26:12   severity: fail
10:26:12   stack: |-
10:26:12   ...

looks like either the resume CI did not pick up the landed commit, or the changes did not have any effect - the test is continued to run and fail. Let me run a full CI to confirm one or the other.

full CI: https://ci.nodejs.org/job/node-test-pull-request/19072/

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

looks like either the resume CI did not pick up the landed commit, or the changes did not have any effect - the test is continued to run and fail. Let me run a full CI to confirm one or the other.

Running "Resume Build" will rebuild from the same commit as the job that is being resumed. It will not rebase against master. So, yeah, running a full CI was the way to go. Now that we've done that...

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19074/ ✔️

@Trott
Trott approved these changes Nov 30, 2018

@Trott Trott added the fast-track label Nov 30, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

Collaborators, 👍 here to fast-track.

test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@gireeshpunathil gireeshpunathil force-pushed the gireeshpunathil:known_issues2 branch from c419eb2 to 2b1dd6c Dec 1, 2018

@Trott Trott merged commit 2b1dd6c into nodejs:master Dec 1, 2018

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
BridgeAR added a commit that referenced this pull request Dec 5, 2018
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 14, 2018
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Jan 18, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: mark test_threadsafe_function/test as flaky
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.