Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check invalid argument error for option #24736

Closed
wants to merge 1 commit into from

Conversation

@nanomosfet
Copy link
Contributor

commented Nov 30, 2018

this adds a test for the validateArguments function in TextDecoder

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

As another note I would like to test the function makeTextDecoderJS in encoding.js but I do not know how to force hasIntl to be false without rebuilding node with the option --without-intl. Is there a way to do this at runtime? (Maybe it could be providing a icu-data-dir that has it disabled? I just don't know what that file would look like if that is the case)

If anyone knows a way to set hasIntl to off let me know because I can just include those tests and get the coverage of encoding.js up even more!

test: check invalid argument error for option
this adds a test for the validateArguments function in TextDecoder
@Trott
Trott approved these changes Nov 30, 2018
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 2, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Dec 3, 2018

Landed in f8f9601.

@danbev danbev closed this Dec 3, 2018

danbev added a commit that referenced this pull request Dec 3, 2018
test: check invalid argument error for option
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
test: check invalid argument error for option
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: check invalid argument error for option
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: nodejs#24736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: check invalid argument error for option
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: check invalid argument error for option
This commit adds a test for the validateArguments function in
TextDecoder.

PR-URL: #24736
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.