Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: streamline Accepting Modifications in Collaborator Guide #24807

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Dec 3, 2018

Editing a sentence I missed simplifying in the last pass on that
section.

Collaborators, 馃憤 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

@Trott Trott added the fast-track label Dec 3, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

Landed in 2e03b76

@Trott Trott closed this Dec 3, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 3, 2018
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
doc: streamline Accepting Modifications in Collaborator Guide
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.