Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix compiler version detection #24879

Closed
wants to merge 2 commits into from

Conversation

@richardlau
Copy link
Member

commented Dec 6, 2018

Compiler version tuples should be numeric for tuple comparisons
to work.

Before:

-bash-4.2$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.2$ ./configure
-bash-4.2$

After:

-bash-4.2$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.2$ ./configure
WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=g++)
WARNING: warnings were emitted in the configure phase
-bash-4.2$
Checklist
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.
@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

@richardlau

This comment was marked as outdated.

Copy link
Member Author

commented Dec 6, 2018

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

Also corrected the version check for AIX, which requires GCC 6.3.0 (https://github.com/nodejs/node/blob/master/BUILDING.md#aix):

-bash-4.4$ g++ --version
g++ (GCC) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-bash-4.4$ ./configure
WARNING: C++ compiler too old, need g++ 6.3.0 (CXX=g++)
WARNING: Could not recognize `gas`:
WARNING: warnings were emitted in the configure phase
-bash-4.4$
@joyeecheung
Copy link
Member

left a comment

LGTM if CI is happy

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

arm-fanned seems to have infra issues. Have raised nodejs/build#1626.

@bnoordhuis
Copy link
Member

left a comment

The bug was introduced in commit 641d4a4 / PR #21183?

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

The bug was introduced in commit 641d4a4 / PR #21183?

Yes, although the previous string-based comparison was probably not quite correct either.

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

Landed in c3dd0d0

@Trott Trott closed this Dec 8, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2018
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: nodejs#24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs added a commit that referenced this pull request Dec 17, 2018
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: nodejs#24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg added a commit that referenced this pull request Feb 28, 2019
build: fix compiler version detection
Compiler version tuples should be numeric for tuple comparisons
to work.

Also correct check for AIX where the minimum supported GCC is 6.3.0

PR-URL: #24879
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.