Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more tests for internal/util/types #25225

Closed
wants to merge 2 commits into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 26, 2018

Add more tests for methods in internal/util/types.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@ZYSzys ZYSzys force-pushed the zys-contribs:test-util-types branch from 81f3dc3 to 09f2883 Dec 28, 2018

@addaleax

This comment has been minimized.

@mhdawson
Copy link
Member

left a comment

LGTM

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Landed in 519a11b

@addaleax addaleax closed this Jan 9, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
test: more tests for internal/util/types
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
test: more tests for internal/util/types
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test: more tests for internal/util/types
PR-URL: nodejs#25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@ZYSzys ZYSzys deleted the zys-contribs:test-util-types branch Jan 18, 2019

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: more tests for internal/util/types
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: more tests for internal/util/types
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: more tests for internal/util/types
PR-URL: #25225
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.