Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.8.0 proposal #25687

Merged
merged 88 commits into from Jan 25, 2019

Conversation

@MylesBorins
Copy link
Member

commented Jan 24, 2019

2019-01-24, Version 11.8.0 (Current), @MylesBorins

Notable Changes

  • events:
    • For unhandled error events with an argument that is not an Error object, the resulting exeption will have more information about the argument. nodejs/node#25621
  • child_process:
    • When the maxBuffer option is passed, stdout and stderr will be truncated rather than unavailable in case of an error. nodejs/node#24951
  • policy:
    • Experimental support for module integrity checks through a manifest file is implemented now. nodejs/node#23834
  • n-api:
  • report:
    • An experimental diagnostic API for capturing process state is available as process.report and through command line flags. nodejs/node#22712
  • tls:
    • tls.connect() takes a timeout option analogous to the net.connect() one. nodejs/node#25517
  • worker:
    • process.umask() is available as a read-only function inside Worker threads now nodejs/node#25526
    • An execArgv option that supports a subset of Node.js command line options is supported now. nodejs/node#25467

Commits

  • [e09dd0c5f0] - assert: make actual and expected getters (Ruben Bridgewater) #25250
  • [516f75fda8] - benchmark: fix net-wrap-js-stream-passthrough (Rich Trott) #25273
  • [9a627a4694] - (SEMVER-MINOR) benchmark,test: add brotli (Anna Henningsen) #24938
  • [8e84ccb502] - buffer: move Buffer prototype wiring into internal/buffer.js (Joyee Cheung) #25292
  • [042d20ab47] - buffer: move initialization of buffer prototype into node.js (Joyee Cheung) #25292
  • [68014fbc22] - buffer: inspect extra properties (Ruben Bridgewater) #25150
  • [1d4940888d] - buffer: refactor checks for SlowBuffer creation (P. Mike) #25266
  • [7dc4c3be03] - buffer: fix crash for invalid index types (Anna Henningsen) #25154
  • [5fab92c88a] - build: remove AIX/ppc (32bit) dead code (Refael Ackermann) #25523
  • [34da9a3089] - build: make install.py python 3 compatiable (Sakthipriyan Vairamani (thefourtheye)) #25583
  • [8cc936a8ea] - build: remove erroneous duplicate declaration from node_inspector.gypi (Refael Ackermann) #25586
  • [28894af902] - build: do not lint python scripts under test/fixtures (Joyee Cheung) #25639
  • [47d040dd77] - build: introduce --openssl-is-fips flag (Daniel Bevenius) #25412
  • [a4f50a62d5] - build: set -blibpath: for AIX (Richard Lau) #25447
  • [07ffa3f189] - build: add check for empty openssl-fips flag (Daniel Bevenius) #25391
  • [a2cc4bad0e] - build: fix Windows shared lib build (Richard Lau) #25166
  • [ac5fa2c7f6] - child_process: truncate output when maxBuffer is exceeded (Jeremiah Senkpiel) #24951
  • [56e7e4f0cd] - child_process: simplify argument handling (cjihrig) #25194
  • [3c661f0aa6] - console: refactor inspector console extension installation (Joyee Cheung) #25450
  • [272ddb1765] - console: improve inspectOptions validation (cjihrig) #25090
  • [65d485b880] - (SEMVER-MINOR) console: add inspectOptions option (Ruben Bridgewater) #24978
  • [57323e8048] - console: move the inspector console wrapping in a separate file (Joyee Cheung) #24709
  • [b549058cc4] - console: split console into global.js and constructor.js (Joyee Cheung) #24709
  • [4052aec321] - console: lazy load process.stderr and process.stdout (Joyee Cheung) #24534
  • [7f5bb9d3bf] - console: bind methods from the prototype chain in Console (Joyee Cheung) #24047
  • [b2b0645805] - console: create the global console from Console constructor (Joyee Cheung) #25420
  • [561c2689ef] - console: use spread notation instead of Object.assign (Ruben Bridgewater) #25149
  • [63fbd00834] - coverage: pass cwd to path.resolve() in setup (cjihrig) #25289
  • [daca3188af] - coverage: use process._rawDebug() during setup (cjihrig) #25289
  • [f415069c65] - crypto: add crypto modules to cannotUseCache (Daniel Bevenius) #25606
  • [bb7f71ad8a] - crypto: fix key handle extraction (Tobias Nießen) #25562
  • [eaaaa0d479] - (SEMVER-MINOR) crypto: always accept private keys as public keys (Tobias Nießen) #25217
  • [32e45b20da] - crypto: fix key object wrapping in sync keygen (Tobias Nießen) #25326
  • [bc6f4bc0c5] - crypto: add crypto/keys to cannotUseCache (Daniel Bevenius) #25237
  • [f3ebc391a3] - crypto: fix zero byte allocation assertion failure (Tobias Nießen) #25248
  • [c0859d7176] - deps: upgrade to libuv 1.25.0 (cjihrig) #25571
  • [e1d4f4384a] - deps: cherry-pick d9fbfeb from upstream V8 (Alexey Kozyatinskiy) #25331
  • [91015918d8] - deps: upgrade npm to v6.5.0 (Jordan Harband) #25234
  • [11c01a6a69] - (SEMVER-MINOR) deps: add brotli (Hackzzila) #24938
  • [f2abe7bf76] - deps: V8: backport 3e010af (Ruben Bridgewater) #25101
  • [201cf97fcb] - deps: V8: backport bf84766 (Ruben Bridgewater) #25101
  • [ec87b6c994] - (SEMVER-MINOR) deps,tools: update license-builder.sh and LICENSE (Hackzzila) #24938
  • [5b4fab1a40] - dns: fix TTL value for AAAA replies to resolveAny() (Anna Henningsen) #25187
  • [9d8a225c6c] - doc: add note regarding pushing release tags (Myles Borins) #25569
  • [5440f9d4bc] - doc: use correct placeholder for policy docs (Anna Henningsen) #25627
  • [4f38106ef5] - (SEMVER-MINOR) doc: add node-report documentation (Vipin Menon) #22712
  • [eac438acc8] - doc: running coverage for individual suites (Benjamin Coe) #25622
  • [65478faa7b] - doc: hyperlink reference to process.nextTick (Sam Roberts) #25615
  • [c5d89e6333] - doc: reword stream docs to clarify that decodeStrings encodes strings (Daniel George Holz) #25468
  • [0c046e8e68] - doc: correct my wrong note about buf.fill() (Vse Mozhet Byt) #25585
  • [10bff7a58c] - doc: add a note to buf.fill() description (Vse Mozhet Byt) #25547
  • [688fb8d619] - doc: fix typo in Buffer API (H1Gdev) #25544
  • [417023046e] - doc: add Rich back to TSC list (Michael Dawson) #25535
  • [26c5bd8a5c] - doc: add metadata about ecdh curve options (Sam Roberts) #25502
  • [edab2d61fd] - doc: revert incorrect change on readable._read (Matteo Collina) #25442
  • [2172dbfce4] - doc: add TLSSocket.isSessionReused() docs (Sam Roberts) #25423
  • [7123167e31] - doc: improve Sign/Verify examples and docs (Sam Roberts) #25452
  • [9a61a7abb3] - doc: fix section order in vm.md (Vse Mozhet Byt) #25374
  • [2b0c8538ef] - doc: fix sorting in buffer.md (Vse Mozhet Byt) #25477
  • [f8bb544bfb] - doc: fix napi\_open\_callback\_scope description (Philipp Renoth) #25366
  • [b67c4b4f99] - doc: document that stream.on('close') was changed in Node 10 (Matteo Collina) #25413
  • [3db7a9ffba] - doc: fix, unify, formalize, and amplify vm.md (Vse Mozhet Byt) #25422
  • [ebd202736c] - doc: fix the path to postMessage() (Mitar) #25332
  • [177635b320] - doc: update os.networkInterfaces() example (jvelezpo) #25417
  • [67782613bb] - doc: make sure that calls to .read() are looped (Matteo Collina) #25375
  • [f58b5300cd] - doc: wrap and punctuate YAML description text (Sam Roberts) #25419
  • [8380bd46a0] - doc: add history to http.request.setTimeout() (James Bunton) #25121
  • [8bc1651249] - doc: add clarification for exception behaviour (Michael Dawson) #25339
  • [f3d86391d9] - doc: clarify timing of socket.connecting (Sam Roberts) #25333
  • [7d46437c45] - doc: update benchmark doc (Kazushi Kitaya) #25367
  • [071f84e80a] - doc: use lowercase for zlib (Rich Trott) #25371
  • [7d1d26191d] - doc: fix heading in cpp style guide (Kazushi Kitaya) #25303
  • [354fba1b26] - doc: fix process.stdin example (Anna Henningsen) #25344
  • [1e20c5e440] - doc: make modules.md more accurate (Vse Mozhet Byt) #25357
  • [f8dcbba563] - doc: fs.mkdir('/') throws EPERM on Windows (Corey Farrell) #25340
  • [b9b2ba22ec] - doc: document key encryption options (Tobias Nießen) #23632
  • [f5008fd1ef] - doc: simplify DEP0119 wording (cjihrig) #25276
  • [1c5a99797b] - (SEMVER-MINOR) doc: add documentation for brotli support (Anna Henningsen) #24938
  • [be45469744] - doc: edit and simplify util.inspect() docs (cjihrig) #25195
  • [8a701c3fce] - doc: include license for src/large_pages in LICENSE (Ujjwal Sharma) #25246
  • [e6da77b12c] - doc: describe TLS session resumption (Sam Roberts) #25174
  • [3af173df00] - doc: link and expand --tls-cipher-list docs (Sam Roberts) #25174
  • [39b3fd1b61] - doc: revise "Breaking Changes to Internal Elements" (Rich Trott) #25190
  • [2c50bcda8a] - doc: fix NAPI typo (Philipp Renoth) #25216
  • [1697604ae0] - doc,worker: revise worker_threads.md (Rich Trott) #25402
  • [593714e4bd] - events: show inspected error in uncaught 'error' message (Anna Henningsen) #25621
  • [dd0381fe4e] - (SEMVER-MAJOR) fs: make process.binding('fs') internal (Masashi Hirano) #22478
  • [ca7adcafda] - fs: extract start and end check into checkPosition (ZYSzys) #25264
  • [d6b50c66cc] - http: make ClientRequest#setTimeout() noop at end (Tim De Pauw) #25536
  • [e55c5c341d] - http: reuse noop function in socketOnError() (cjihrig) #25566
  • [9a410a189e] - http2: allow fully synchronous \_final() (Anna Henningsen) #25609
  • [26f2eb8b12] - http2: add test case for goaway (Anto Aravinth) #24054
  • [445ba9f283] - inspector: move process.binding to internalBinding (Beni von Cheni) #24931
  • [8cc97571a4] - Revert "inspector: move process.binding to internalBinding" (Joyee Cheung) #25446
  • [4794cf601e] - inspector: move process.binding to internalBinding (Beni von Cheni) #24931
  • [cb73fed430] - inspector, test: verify reported console message (Eugene Ostroukhov) #25455
  • [6528ce6176] - lib: expose all type checks from the internal types module (Ruben Bridgewater) #25149
  • [207612c723] - lib: remove internalBinding('config').pendingDeprecation (Joyee Cheung) #24962
  • [d8ba520622] - lib: remove unused NativeModule/NativeModule wraps (Joyee Cheung) #24904
  • [87a58beed7] - lib: remove duplicated noop function (ZYSzys) #24770
  • [d7d772b2f8] - Revert "lib: remove duplicated noop function" (Joyee Cheung) #25446
  • [42a7eaf9d4] - Revert "lib: remove unused NativeModule/NativeModule wraps" (Joyee Cheung) #25446
  • [b48865f03f] - lib: move lib/console.js to lib/internal/console/constructor.js (Joyee Cheung) #24709
  • [3350230e20] - lib: remove internal util.\_extends() usage (Ruben Bridgewater) #25105
  • [73c3a3d5ed] - (SEMVER-MAJOR) lib: make the global console [[Prototype]] an empty object (Joyee Cheung) #23509
  • [8d0c638583] - (SEMVER-MINOR) lib: support overriding http\s.globalAgent (Roy Sommer) #25170
  • [217bb0e5f0] - lib: simplify several debug() calls (cjihrig) #25241
  • [e14f8646e2] - lib,test: remove lib/internal/test/unicode.js (Rich Trott) #25298
  • [f688e73984] - n-api: change #ifdef to #if in node_api_types (Daniel Bevenius) #25635
  • [2b1858298a] - (SEMVER-MINOR) n-api: mark thread-safe function as stable (Gabriel Schulhof) #25556
  • [c13e5be740] - net: use decodeStrings public API for writable stream (Rich Trott) #25201
  • [9ac8d41925] - net: check for close on stream, not parent (David Halls) #25026
  • [0ebe6ebbb1] - os: implement os.release() using uv_os_uname() (cjihrig) #25600
  • [3bd8e4b6a3] - os: add fallback for undefined CPUs (Minwoo Jung) #25493
  • [840ec230f1] - os: improve networkInterfaces() performance (Brian White) #25410
  • [d197105476] - os: move process.binding('os') to internalBinding (briete) #25087
  • [f64e5ec148] - Revert "os: move process.binding('os') to internalBinding" (Joyee Cheung) #25446
  • [55d185f0dd] - os: move process.binding('os') to internalBinding (briete) #25087
  • [da8c526888] - (SEMVER-MINOR) policy: manifest with subresource integrity checks (Bradley Farias) #23834
  • [647a37f5d8] - process: clarify the pre- and post-condition of esm setup (Joyee Cheung) #25530
  • [b2834ce65b] - process: fix call process.reallyExit, vs., binding (Benjamin Coe) #25655
  • [92dd8998e7] - process: check env->EmitProcessEnvWarning() last (Benjamin) #25575
  • [07f1bb001c] - process: allow reading umask in workers (cjihrig) #25526
  • [c718592147] - process: register the inspector async hooks in bootstrap/node.js (Joyee Cheung) #25443
  • [b524a7bed0] - process: refactor coverage setup during bootstrap (Joyee Cheung) #25398
  • [83900148e6] - process: allow StartExecution() to take a main script ID (Joyee Cheung) #25474
  • [28baf266c7] - process: move C++ process events into node_process_events.cc (Joyee Cheung) #25397
  • [5eada9dce4] - process: move --help and --bash-completeion handling to startExecution (Joyee Cheung) #25262
  • [743056e3af] - process: move process.features initialization into node.js (Joyee Cheung) #25239
  • [c07b12da42] - process: make tick callback and promise rejection callback more robust (Joyee Cheung) #25200
  • [655c1c9232] - process: move worker bootstrap code into worker_thread_only.js (Joyee Cheung) #25199
  • [9480e1b795] - process: split worker IO into internal/worker/io.js (Joyee Cheung) #25199
  • [456b1b55b1] - process: move eval and exception bootstrap ito process/execution.js (Joyee Cheung) #25199
  • [f32e6a81a6] - process: make internal/queue_microtask.js more self-contained (Joyee Cheung) #25189
  • [6b5c962a0a] - process: move child process IPC setup condition into node.js (Joyee Cheung) #25130
  • [e93dd4dad6] - process: move POSIX credential accessors into node_credentials.cc (Joyee Cheung) #25066
  • [0e2fbe4ff4] - process: specialize building and storage of process.config (Joyee Cheung) #24816
  • [18052364ce] - process: provide dummy stdio for non-console Windows apps (Anna Henningsen) #20640
  • [1ccaf9a8f1] - repl: indicate if errors are thrown or not (Ruben Bridgewater) #25253
  • [f3d0591abf] - report: use uv\_handle\_type\_name() to get handle type (Anna Henningsen) #25610
  • [03ba34401b] - report: downgrade reinterpret_cast to static_cast (Anna Henningsen) #25610
  • [07a0dc89ad] - report: roll extra loop iteration in PrintNativeStack() (Anna Henningsen) #25610
  • [64959b6668] - report: remove internalBinding('config').hasReport (Anna Henningsen) #25610
  • [4031b5c267] - report: remove InitializeReport() (Anna Henningsen) #25598
  • [0f91e0355a] - report: simplify rlimit to JSON logic (cjihrig) #25597
  • [a02b621312] - report: simplify option checking (cjihrig) #25597
  • [c598d98970] - report: use uv_pid_t instead of custom PID_TYPE (cjihrig) #25597
  • [213eddd323] - report: remove unnecessary includes (cjihrig) #25597
  • [42bbe58c47] - report: remove unnecessary intermediate variable (cjihrig) #25597
  • [a161a9b9c3] - src: remove unnecessary filename variable (Anna Henningsen) #25610
  • [c59edcadc1] - src: remove using v8::Function in node_os.cc (cjihrig) #25640
  • [dbecc82524] - src: remove outdated Neuter() call in node\_buffer.cc (Anna Henningsen) #25479
  • [8f42c9efe9] - src: silence compiler warning in node_report.cc (Daniel Bevenius) #25557
  • [549216a138] - (SEMVER-MINOR) src: merge into core (Gireesh Punathil) #22712
  • [55768c0079] - src: restrict unloading addons to Worker threads (Anna Henningsen) #25577
  • [d9a8113a5b] - src: pass along errors from --security-reverts (Anna Henningsen) #25466
  • [291cedf25d] - src: reduce includes of node_internals.h (Joyee Cheung) #25507
  • [03e05cb4fb] - src: fix FIPS section in Sign::SignFinal (Daniel Bevenius) #25412
  • [0897504adc] - src: call Environment::Exit() for fatal exceptions (Anna Henningsen) #25472
  • [7ffa8ec756] - src: reset StopTracingAgent() before platform teardown (Anna Henningsen) #25472
  • [2ed3fa187e] - src: declare process-related C++ methods in node_process.h (Joyee Cheung) #25397
  • [49ac9688f3] - src: move process object creation into node_process_object.cc (Joyee Cheung) #25397
  • [299aefd81a] - src: clean up node::Init() wrt embedder scenarios (Anna Henningsen) #25370
  • [dca6741b9b] - src: move InternalMakeCallback and MakeCallback (Joyee Cheung) #25299
  • [81924ffa4f] - src: remove unused isolate variable (Daniel Bevenius) #25368
  • [8e6175e001] - src: use generic helper for splitting strings (Anna Henningsen) #25363
  • [6cdaf038ce] - src: split LoadEnvironment() at startExecution() (Anna Henningsen) #25320
  • [c6adf4b44f] - src: move per-process global variables into node::per_process (Joyee Cheung) #25302
  • [69d8e60596] - src: use internalBinding('config').hasInspector in JS land (Joyee Cheung) #25291
  • [c5ab3408b1] - src: refactor tickInfo access (Joyee Cheung) #25200
  • [2e33ad1caa] - src: move process.nextTick and promise setup into node_task_queue.cc (Joyee Cheung) #25163
  • [fa74cd352f] - src: move symbols binding into node_symbols.cc (Joyee Cheung) #25163
  • [57a0cd4d48] - src: move node::errno_string into node_errors.h/cc (Joyee Cheung) #25396
  • [f8ba4880ab] - src: fix compiler warnings (cjihrig) #25165
  • [dde71520ba] - src: move more process methods initialization in bootstrap/node.js (Joyee Cheung) #25127
  • [5fe774104f] - src: dispose of V8 platform in process.exit() (Anna Henningsen) #25061
  • [e9b4d24eda] - src: move arch, platform and release into node_metadata.cc (Joyee Cheung) #25293
  • [43535f56fd] - src: simplify JS Array creation (Anna Henningsen) #25288
  • [de6f1f5e4d] - src: initialize ICU version in per_process::metadata.versions (Joyee Cheung) #25115
  • [e5b4af43fd] - src: move the declaration of http parser versions into node_metadata.h (Joyee Cheung) #25115
  • [64c713a2e7] - src: move GetOpenSSLVersion into node_metadata.cc (Joyee Cheung) #25115
  • [b1500d9a7f] - src: pass isMainThread into bootstrap/node.js directly (Joyee Cheung) #25017
  • [ee461feaee] - src: always compile and store code cache for native modules (Joyee Cheung) #24950
  • [fd913fe365] - src: remove code cache integrity check (Joyee Cheung) #24950
  • [d245c4cd50] - src: use NativeModuleLoader to compile all the bootstrappers (Joyee Cheung) #24775
  • [d1ff107b51] - src: initialize Environment members in class definition (Anna Henningsen) #25369
  • [5b933565ac] - src: check curve ID existence instead of asn flags (Sam Roberts) #25345
  • [807e732832] - src: trace_events: fix race with metadata events (Ali Ijaz Sheikh) #25235
  • [1e60e0afcb] - src: remove unused method declaration (Ben Noordhuis) #25329
  • [f6e341a546] - src: improve ToV8Value() functions (Anna Henningsen) #25288
  • [465d02b817] - src: add NAPI_VERSION_EXPERIMENTAL (Michael Dawson) #25319
  • [d7186252df] - src: unload addons when environment quits (Gabriel Schulhof) #24861
  • [f62e35fd05] - src: fix warning in cares_wrap.cc (cjihrig) #25230
  • [2f5c8b5041] - src: remove unused variable from string_search.h (Anna Henningsen) #25139
  • [e00b326f33] - src: pass along MaybeLocal<> state from URL::ToObject() (Anna Henningsen) #25141
  • [ae86192732] - src: ignore termination exceptions in fatal TryCatch (Anna Henningsen) #25141
  • [c9d49d65a4] - src: fulfill Maybe contract in InlineDecoder (Anna Henningsen) #25140
  • [dd6667d05e] - src: lazily load internalBinding('uv') and build the errmap lazily (Joyee Cheung) #25143
  • [bc66356093] - src: use consistent names for JSStream (Sam Roberts) #25153
  • [99a5af65df] - src: introduce DCHECK macro (cjihrig) #25207
  • [e2a01ca061] - src: use DCHECK_* macros where possible (cjihrig) #25207
  • [73ccfc81c9] - src: fix compiler warnings in node_crypto.cc (cjihrig) #25205
  • [7365b00929] - src: do not leak NodeTraceStateObserver (Anna Henningsen) #25180
  • [37ba20112a] - src,lib: prefer internal/options over process._foo (Anna Henningsen) #25063
  • [7480864c51] - src,lib: make process.binding('config') internal (Masashi Hirano) #23400
  • [577da835d2] - Revert "src,lib: make process.binding('config') internal" (Joyee Cheung) #25446
  • [a9ffce908d] - test: fix pummel/test-exec (Rich Trott) #25677
  • [08ade9b0d3] - test: clarify the path relativeness of WPT runner classes (Joyee Cheung) #25616
  • [74ee8d3b72] - test: run html/webappapis/microtask-queuing WPT (Joyee Cheung) #25616
  • [572a70feae] - test: pull html/webappapis/microtask-queuing WPT (Joyee Cheung) #25616
  • [90a64ab280] - test: add stdio checks to cp-exec-maxBuffer (Jeremiah Senkpiel) #24951
  • [0800f91dcc] - (SEMVER-MINOR) test: add node-report tests (LakshmiSwethaG) #22712
  • [7490fc880e] - test: switch to native v8 coverage (Benjamin Coe) #25157
  • [ecd358b1fd] - test: revoke flaky designation for tests (Gireesh Punathil) #25611
  • [5a0332ed31] - test: remove potential race condition in https renegotiation test (Rich Trott) #25601
  • [6881454d92] - test: replace common.PORT with 0 in https renegotiation test (Rich Trott) #25599
  • [5684da5360] - test: changed function to arrow function (yathamravali) #25441
  • [efe089e01a] - test: use stronger curves for keygen (Daniel Bevenius) #25564
  • [3dcdf27399] - test: change ciphers from RC4 to no-such-cipher (Daniel Bevenius) #25534
  • [faa1776048] - test: relax chunk count expectations (Gireesh Punathil) #25415
  • [b8d780c0ee] - test: ensure npm version is not release candidate (Myles Borins) #25538
  • [2112b707e6] - test: improve code coverage for i18n (Michael Dawson) #25428
  • [4e52b07fb7] - test: use fipsMode instead of common.hasFipsCrypto (Daniel Bevenius) #25510
  • [4c207d9b84] - test: do not use uninitialized memory in common flags check (Anna Henningsen) #25475
  • [cfcb759e5d] - test: prepare test-hash-seed for CI (Rich Trott) #25522
  • [35240cab05] - test: refactor min() in test-hash-seed (Rich Trott) #25522
  • [779ce29f39] - test: add check for wrk to test-keep-alive (Rich Trott) #25516
  • [ab861433c9] - test: fix test-repl timeout and tmpdir refresh (Brian White) #25425
  • [6347940e9f] - test: refactor pummel/test-net-pingpong (Rich Trott) #25485
  • [307da2d3e7] - test: refactor pummel/test-net-many-clients (Rich Trott) #25485
  • [69c0841a5a] - test: refactor pummel/test-net-connect-econnrefused (Rich Trott) #25485
  • [817b44db54] - test: refactor pummel/test-keep-alive (Rich Trott) #25485
  • [d7bc03e2ca] - test: improve known_issues/test-vm-timeout-escape-queuemicrotask (Rich Trott) #25503
  • [3afb4813c8] - test: add test for fs.lchmod (ZYSzys) #25439
  • [067d38fb07] - test: make test-v8-coverage.js more strict (cjihrig) #25289
  • [f6c14bd1e2] - test: rework ephemeralkeyinfo to run in parallel (Sam Roberts) #25409
  • [29b89badb5] - test: check for tls renegotiation errors (Sam Roberts) #25437
  • [23d41fbf01] - test: fix test-net-connect-econnrefused (again) (Rich Trott) #25438
  • [d86a3e8245] - test: remove unnecessary skipIfWorker() (Rich Trott) #25427
  • [82fc9a8889] - test: fix module loading error for AIX 7.1 (Richard Lau) #25418
  • [3f661097d1] - test: improve test coverage of native crypto code (Tobias Nießen) #25400
  • [fe9b6ee88b] - test: move require('https') to after crypto check (Daniel Bevenius) #25388
  • [b545b4c1e9] - test: fix test-net-connect-econnrefused (Rich Trott) #25389
  • [0f290e8f62] - test: remove test/pummel/test-http-client-reconnect-bug.js (Rich Trott) #25387
  • [58de81faa7] - test: remove duplicate encoding tests in favor of WPT (Joyee Cheung) #25321
  • [da34c6c575] - test: use WPT runner to run encoding tests (Joyee Cheung) #25321
  • [8d8c30599a] - test: support more icu requirements in the WPT status file (Joyee Cheung) #25321
  • [d9adceecb6] - test: pull enconding WPT test fixtures (Joyee Cheung) #25321
  • [837ca76a0d] - test: refactor test-fs-watch-non-recursive (Rich Trott) #25386
  • [65dfeeb9a9] - test: fix test/pummel/test-fs-watch-non-recursive.js (Rich Trott) #25386
  • [bdcf8f4784] - test: fix test/pummel/test-fs-watch-file.js (Rich Trott) #25384
  • [be16cc9fd6] - test: set umask for tests (Rich Trott) #25229
  • [3bebcf0180] - test: fix failing assertion (Ruben Bridgewater) #25250
  • [201a8d9dc2] - test: refactor common.expectWarning() (Ruben Bridgewater) #25251
  • [f0202a7604] - test: fix test/pummel/test-fs-largefile.js (Rich Trott) #25372
  • [fc22df9552] - test: more tests for internal/util/types (ZYSzys) #25225
  • [c826af781f] - test: clean up wasm fixtures (Gus Caplan) #25360
  • [c1aa5f0dae] - test: tune test-uv-threadpool-schedule (Rich Trott) #25358
  • [f80fbd2c16] - test: remove redundant fchmod test (ZYSzys) #25282
  • [ce7bbd2ad9] - test: move test-tls-securepair-client out of pummel (Rich Trott) #25222
  • [7ac1db2c31] - test: fix test-tls-securepair-client (Rich Trott) #25222
  • [239d5ec92c] - test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH (Furqan Shaikh) #25296
  • [456f76a48b] - test: remove flag for test-addon-uv-handle-leak (Rich Trott) #25327
  • [523872b37f] - test: fix test-benchmark-zlib (Rich Trott) #25365
  • [379260e4bd] - test: replace internals with public API (Rich Trott) #25309
  • [973b32d3c3] - test: set umask explicitly (Thomas Chung) #25213
  • [c10b131ec9] - test: make sure tmpdir is created before using it (Joyee Cheung) #25224
  • [5a5bc58b4f] - test: remove unused --expose-native-as V8 flag (peterwmwong) #25275
  • [61fc3bfd8e] - test: mark test-util-callbackify flaky on AIX (Rich Trott) #25284
  • [ee8a4a291d] - test: remove unnecessary test flags (cjihrig) #25277
  • [4ca4b546ab] - test: remove util.inherits() usage (ZYSzys) #25245
  • [11c9a82f0f] - test: slightly refactor test-child-process-execsync (Denys Otrishko) #25227
  • [05d1a536cc] - test: remove try/catch in common.isMainThread (Rich Trott) #25249
  • [b0b1414ad7] - test: regression test for uv threadpool congestion (Gireesh Punathil) #23099
  • [c7d2dbd5da] - test: add TODO to encoding tests that can be replaced with WPT (Joyee Cheung) #25155
  • [b45be671db] - test: rename custom encoding tests that cannot be replaced by WPT (Joyee Cheung) #25155
  • [be421823e5] - test: split encoding tests where some cases can be run without ICU (Joyee Cheung) #25155
  • [deceb26238] - test: split test-whatwg-encoding-textdecoder-fatal.js (Joyee Cheung) #25155
  • [a8f5191eb9] - test: split test-whatwg-encoding-textdecoder.js (Joyee Cheung) #25155
  • [7e2ae75a6b] - test: mark two tests as flaky in AIX (Gireesh Punathil) #25126
  • [e182ca9bdc] - test: add more inspect subclassing tests (Ruben Bridgewater) #25192
  • [58af085d9f] - test: refactor stdio handling in test-esm-cjs-main (Richard Lau) #25169
  • [91d1aea311] - test: refactor test-esm-namespace.mjs (Rich Trott) #25117
  • [b7b1d7eb88] - test: fix test-repl-envvars (Anna Henningsen) #25226
  • [95353c7c20] - test,doc: add tests and docs for addon unloading (Anna Henningsen) #24861
  • [aa9a86aa32] - test,worker: verify that .terminate() breaks microtask queue (Anna Henningsen) #25480
  • [a29adef252] - test,worker: simplify common.isMainThread (Rich Trott) #25426
  • [a6df7278d8] - test,worker: refactor test-worker-cleanup-handles (Rich Trott) #25401
  • [c3409f57fd] - tls: do not free cert in .getCertificate() (Anna Henningsen) #25490
  • [58952a1a96] - (SEMVER-MINOR) tls: make tls.connect() accept a timeout option (Luigi Pinca) #25517
  • [453bd18969] - tls: do not confuse TLSSocket and Socket (Sam Roberts) #25153
  • [f6b2ea8bb9] - tls: do not confuse session and session ID (Sam Roberts) #25153
  • [d5ba121e74] - tls: fix initRead socket argument name (Sam Roberts) #25153
  • [acf7802fe3] - tls: remove unused ocsp extension parsing (Sam Roberts) #25153
  • [1cbadd8d1c] - tools: improve valgrind support (Anna Henningsen) #25498
  • [d9da4af245] - tools: update ESLint to 5.12.1 (cjihrig) #25573
  • [f0409be2a7] - tools: lint for use of internalBinding() (cjihrig) #25395
  • [2a85cc7cae] - tools: update crypo check rule (cjihrig) #25399
  • [dcbf1d9da4] - tools: add openssl-cli to macos-firewall.sh (Daniel Bevenius) #25385
  • [ee4c46c72f] - tools: update ESLint to 5.12.0 (cjihrig) #25347
  • [1be566bd2f] - tools: replace NULL with nullptr (Juan José Arboleda) #25179
  • [fee8a11634] - tools: remove custom buffer-constructor lint rule (cjihrig) #25261
  • [ee43540aa7] - tools: enable no-buffer-constructor lint rule (cjihrig) #25261
  • [e6b5232381] - tools: enable no-useless-catch lint rule (cjihrig) #25236
  • [f944a75336] - tools: update ESLint to 5.11.1 (cjihrig) #25236
  • [19f1a506ee] - trace_events: move SetupTraceCategoryState into node_trace_events.cc (Joyee Cheung) #25128
  • [6e716ed1d6] - url: return backslashes from fileURLToPath on win (Kevin Smith) #25349
  • [338f456107] - util: fix iterable types with special prototype (Ruben Bridgewater) #25457
  • [71432c3d06] - util: fixes type in argument type validation error (Ankur Oberoi) #25103
  • [46ec26f8aa] - util: remove eslint comments and rename variables (Ruben Bridgewater) #25255
  • [7ff44105be] - util: remove outdated comment (Ruben Bridgewater) #25255
  • [45a8eb6ed3] - util: simpler module namespace code (Ruben Bridgewater) #25255
  • [a333272fb0] - util: code cleanup (Ruben Bridgewater) #25255
  • [7696d1fe84] - util: switch recurseTimes counter (Ruben Bridgewater) #25255
  • [2e6e4cfaf5] - util: add null prototype support for date (Anto Aravinth) #25144
  • [901d3d0959] - (SEMVER-MINOR) util: inspect ArrayBuffers contents as well (Ruben Bridgewater) #25006
  • [4ca0968918] - util: update comment in util.promisify (Kazushi Kitaya) #25323
  • [37976251b5] - util: fix util.inspect with proxied function (Weijia Wang) #25244
  • [88e73862ca] - util: simplify code (Kazushi Kitaya) #25162
  • [73f3a1c4e6] - util: make inspect aware of RegExp subclasses and null prototype (Ruben Bridgewater) #25192
  • [7f78137c37] - v8: enable inline WASM in serialization API (Anna Henningsen) #25313
  • [2df0d14e18] - win, build: fix building addons on Windows (Bartosz Sosnowski) #25108
  • [219b1b8ce1] - (SEMVER-MINOR) worker: enable passing command line flags (Yael Hermon) #25467
  • [243f90283c] - worker: remove --experimental-worker flag (Anna Henningsen) #25361
  • [e8a6cc8802] - worker: improve JS-side debugging (Anna Henningsen) #25312
  • [65c136f3de] - worker: partially remove --experimental-worker flag (Anna Henningsen) #25404
  • [7bb7b9a61f] - worker: set --experimental-worker always (Anna Henningsen) #25404
  • [dd8795f4a0] - worker: enable transferring WASM modules (Anna Henningsen) #25314
  • [2014eba782] - worker: use engine-provided deleter for SharedArrayBuffers (Anna Henningsen) #25307
  • [7edf8c7e74] - (SEMVER-MINOR) zlib: add brotli support (Anna Henningsen) #24938
  • [e534dcd75e] - zlib: split JS code as prep for non-zlib-backed streams (Anna Henningsen) #24939
Trott and others added 30 commits Jan 14, 2019
* Reduce concurrent and duration options by half so as to avoid
  interference with other tests. (Excessive TCP activity in this test
  resulted in throttling that caused subsequent tests to fail on my
  local setup.)
* Use an OS-provided port rather than `common.PORT`. This possibly
  reduces side-effects on other tests (that may also be using
  `common.PORT`).
* Add punctuation in comments.

PR-URL: #25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test
  failures as a result of side effects from other tests. (For my local
  setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT
  and/or EADDRNOTAVAIL. It would seem to be a result of throttling.
  Reducing the pummel-iness of that test and this one seems to solve the
  problem.)
* Apply capitalization and punctuation to comment.

PR-URL: #25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* Use port 0 instead of `common.PORT`.
* Reduce `concurrent` from 100 to 50 and `connections_per_client` from 5
  to 3. This is to avoid side effects from other tests. Prior to this
  change, running this along with test-keep-alive would result in
  failures on my local setup, apparently due to network throttling.
* Remove unnecessary `console.log()` and improve remaining
  `console.log()` to provide clearer information.

PR-URL: #25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* Use port 0 instead of `common.PORT`.
* Use `//` for comments, capitalize comments, and add punctuation.

PR-URL: #25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This makes sure that `StopTracingAgent()` is always called
before tearing down the `tracing::Agent`,
since previously its destructor might have tried to access the
agent, which would be destroyed by the (earlier) `Dispose()` call.

PR-URL: #25472
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Call `Environment::Exit()` rather than the process-wide
`exit()` function, since JS exceptions generally only affect
the current JS engine instance.

PR-URL: #25472
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit introduces a new configuration flag named
--openssl-is-fips which is intended to be used when linking against
an OpenSSL library that is FIPS compatible.

The motivation for this is that Red Hat Enterprise Linux 8 (RHEL8)
comes with OpenSSL 1.1.1 and includes FIPS support, and we would
like to be able to dynamically link against this version and also have
FIPS features enabled in node, like would be done when statically
linking and using the --openssl-fips flag.

The suggestion here is to introduce a new flag:
$ ./configure --help
...
--openssl-is-fips specifies that the shared OpenSSL version is FIPS
                  compatible

This flag could be used in combination with the shared-openssl flag:
$ ./configure --shared-openssl ---openssl-is-fips

This will enable FIPS support in node and the runtime flags will be
availalbe to enable FIPS (--enable-fips, --force-fips).

PR-URL: #25412
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Currently, while FIPS is not supported yet for this release there might
be an option to dynamically link against a FIPS compatible OpenSSL
version.

This commit fixes the compiler errors.

PR-URL: #25412
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0
- ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0

PR-URL: #25502
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #25425
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Refs: #25448
PR-URL: #25526
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fixes: nodejs/TSC#650

PR-URL: #25535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if
it is, and skip the test if it isn't.

This is yet another step in preparation for running pummel tests in CI
daily.

PR-URL: #25516
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace min() function with Math.min(...).

PR-URL: #25522
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reduce the time it takes to run test/pummel/test-hash-seed by switching
from spawnSync() to spawn(). On my computer, this reduces the runtime
from about 80 seconds to about 40 seconds. This test is not (yet) run
regularly on CI, but when it was run recently, it timed out.

PR-URL: #25522
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
PR-URL: #25544
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Only use the amount of data that was actually read from the test file.
Otherwise, there is a small risk of getting false positives, and
generally reading uninitialized memory makes using automated
memory error detection tools harder.

PR-URL: #25475
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The fallback should only be taken for a null prototype. If an
iterable data type (e.g., Array) has a prototype without
`Symbol.iterator`, just try the best to visualize it as object.

PR-URL: #25457
Fixes: #25451
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, test-cli-node-print-help uses common.hasFipsCrypto to
determine if the test should check for the existence of FIPS related
options (--enable-fips, and --force-fips). The FIPS options are
available when node has been compiled against an OpenSSL library with
FIPS support in which case the test would verify that these  options
are available. But by using crypto.fips (which uses crypto.getFips())
this would only be checked when fips has been enabled, but these
options are available regardless if FIPS is enabled or disabled.

This commit updates the test to use fipsMode from config to determine
if the FIPS options existence should be checked.

PR-URL: #25510
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25562
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`.
This test should avoid it happening in the future.

PR-URL: #25538
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
PR-URL: #25547
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
In parallel/test-fs-read-stream-concurrent-reads.js the number
of data chunks used is being tested when few concurrent reads
are performed. The number of chunks can fluctuate based on the
number of concurrent reads as well as the data that was read in
one shot. Accommodate these variations in the test.

Fixes: #22339

PR-URL: #25415
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
If specified, and only when a socket is created internally, the option
will make `socket.setTimeout()` to be called on the created socket with
the given timeout.

This is consistent with the `timeout` option of `net.connect()` and
prevents the `timeout` option of the `https.Agent` from being ignored
when a socket is created.

PR-URL: #25517
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #25566
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
I was implementing a Writable stream and misunderstood `decodeStrings`
to mean 'will decode `Buffer`s into `string`s before calling `_write`'.
This change adds a little more detail to the description of
`decodeStrings` to clarify its effect on a Writable stream & what gets
passed to `_write`.

Changing the name of the option to `encodeStrings` would make it much
easier to understand, but the name was chosen in 2012 and the option
used in many projects (22k mentions of 'decodeStringsr in JS projects in
GitHub). Deprecating the old name & rolling out a replacement is beyond
my capabilities as a first-time contributor.

PR-URL: #25468
Fixes: #25464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Update ESLint to 5.12.1

PR-URL: #25573
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in
test/parallel/test-tls-handshake-error.js.

The motivation for this change is that this test is verifying that a
'no ciphers match' error be thrown, but 'RC4' might be among the ciphers
supported by the OpenSSL version when dynamically linking. I ran into
this specific issue when dynamically linking against OpenSSL 1.1.1 on
RHEL8 using #25381.

PR-URL: #25534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins and others added 6 commits Jan 18, 2019
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The `setup()` method is only called when the `--experimental-report`
option is set. `getOptionValue()` returns `undefined` when
the flag is not defined, so the extra check inside of `setup()` is
redundant.

PR-URL: #25610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #25610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #25610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #25610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #25610
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins force-pushed the v11.8.0-proposal branch from e118153 to 4422ab5 Jan 24, 2019
MylesBorins added a commit that referenced this pull request Jan 24, 2019
Notable Changes:

* events:
  * For unhandled `error` events with an argument that is not an
    `Error` object, the resulting exeption will have more information
    about the argument.
    #25621
* child_process:
  * When the `maxBuffer` option is passed, `stdout` and `stderr` will
    be truncated rather than unavailable in case of an error.
    #24951
* policy:
  * Experimental support for module integrity checks through a manifest
    file is implemented now.
    #23834
* n-api:
  * The `napi_threadsafe_function` feature is now stable.
    #25556
* report:
  * An experimental diagnostic API for capturing process state is
    available as `process.report` and through command line flags.
    #22712
* tls:
  * `tls.connect()` takes a `timeout` option analogous to the
    `net.connect()` one.
    #25517
* worker:
  * `process.umask()` is available as a read-only function inside Worker
    threads now.
    #25526
  * An `execArgv` option that supports a subset of Node.js command line
    options is supported now.
    #25467

PR-URL: #25687
@MylesBorins MylesBorins force-pushed the v11.8.0-proposal branch from 4422ab5 to 88e5ed8 Jan 24, 2019
MylesBorins added a commit that referenced this pull request Jan 24, 2019
Notable Changes:

* events:
  * For unhandled `error` events with an argument that is not an
    `Error` object, the resulting exeption will have more information
    about the argument.
    #25621
* child_process:
  * When the `maxBuffer` option is passed, `stdout` and `stderr` will
    be truncated rather than unavailable in case of an error.
    #24951
* policy:
  * Experimental support for module integrity checks through a manifest
    file is implemented now.
    #23834
* n-api:
  * The `napi_threadsafe_function` feature is now stable.
    #25556
* report:
  * An experimental diagnostic API for capturing process state is
    available as `process.report` and through command line flags.
    #22712
* tls:
  * `tls.connect()` takes a `timeout` option analogous to the
    `net.connect()` one.
    #25517
* worker:
  * `process.umask()` is available as a read-only function inside Worker
    threads now.
    #25526
  * An `execArgv` option that supports a subset of Node.js command line
    options is supported now.
    #25467

PR-URL: #25687
Notable Changes:

* events:
  * For unhandled `error` events with an argument that is not an
    `Error` object, the resulting exeption will have more information
    about the argument.
    #25621
* child_process:
  * When the `maxBuffer` option is passed, `stdout` and `stderr` will
    be truncated rather than unavailable in case of an error.
    #24951
* policy:
  * Experimental support for module integrity checks through a manifest
    file is implemented now.
    #23834
* n-api:
  * The `napi_threadsafe_function` feature is now stable.
    #25556
* report:
  * An experimental diagnostic API for capturing process state is
    available as `process.report` and through command line flags.
    #22712
* tls:
  * `tls.connect()` takes a `timeout` option analogous to the
    `net.connect()` one.
    #25517
* worker:
  * `process.umask()` is available as a read-only function inside Worker
    threads now.
    #25526
  * An `execArgv` option that supports a subset of Node.js command line
    options is supported now.
    #25467

PR-URL: #25687
@MylesBorins MylesBorins force-pushed the v11.8.0-proposal branch from 88e5ed8 to 11ee794 Jan 24, 2019
@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2019

Single failure on arm sequential/test-performance which is known to be flaky

CITGM failures mostly appear to be flakes or infra failures

Promoting the release

@MylesBorins MylesBorins merged commit 11ee794 into v11.x Jan 25, 2019
14 of 17 checks passed
14 of 17 checks passed
node-test-commit tests failed
Details
node-test-commit-arm-fanned tests failed
Details
node-test-commit-linux tests failed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
node-test-commit-aix tests passed
Details
node-test-commit-linuxone tests passed
Details
node-test-commit-osx tests passed
Details
node-test-commit-plinux tests passed
Details
node-test-commit-smartos tests passed
Details
node-test-commit-windows-fanned flaky tests failed
Details
node-test-linter tests passed
Details
node-test-linux-linked-debug tests passed
Details
node-test-linux-linked-openssl110 tests passed
Details
node-test-linux-linked-shared tests passed
Details
node-test-linux-linked-withoutintl tests passed
Details
node-test-linux-linked-zlib tests passed
Details
MylesBorins added a commit that referenced this pull request Jan 25, 2019
PR-URL: #25687
MylesBorins added a commit that referenced this pull request Jan 25, 2019
Notable Changes:

* events:
  * For unhandled `error` events with an argument that is not an
    `Error` object, the resulting exeption will have more information
    about the argument.
    #25621
* child_process:
  * When the `maxBuffer` option is passed, `stdout` and `stderr` will
    be truncated rather than unavailable in case of an error.
    #24951
* policy:
  * Experimental support for module integrity checks through a manifest
    file is implemented now.
    #23834
* n-api:
  * The `napi_threadsafe_function` feature is now stable.
    #25556
* report:
  * An experimental diagnostic API for capturing process state is
    available as `process.report` and through command line flags.
    #22712
* tls:
  * `tls.connect()` takes a `timeout` option analogous to the
    `net.connect()` one.
    #25517
* worker:
  * `process.umask()` is available as a read-only function inside Worker
    threads now.
    #25526
  * An `execArgv` option that supports a subset of Node.js command line
    options is supported now.
    #25467

PR-URL: #25687
MylesBorins added a commit to MylesBorins/nodejs.org that referenced this pull request Jan 25, 2019
@targos targos added this to Releases in v11.x Jan 30, 2019
@targos targos deleted the v11.8.0-proposal branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v11.x
  
Releases
You can’t perform that action at this time.