Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable no-buffer-constructor lint rule #25261

Merged
merged 2 commits into from
Dec 31, 2018
Merged

tools: enable no-buffer-constructor lint rule #25261

merged 2 commits into from
Dec 31, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 28, 2018

The custom buffer-constructor ESLint rule can be removed in favor of the built in no-buffer-constructor rule.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2097/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 28, 2018
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2018
@cjihrig
tools: enable no-buffer-constructor lint rule
7bb3d63 
PR-URL: nodejs#25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig
tools: remove custom buffer-constructor lint rule
ad10cc5 
This rule is no longer needed. ESLint's built in
no-buffer-constructor rule is enabled instead.

PR-URL: nodejs#25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig cjihrig merged commit ad10cc5 into nodejs:master Dec 31, 2018
@cjihrig cjihrig deleted the buf-eslint branch December 31, 2018 00:19
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
tools: enable no-buffer-constructor lint rule
ee43540 
PR-URL: #25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
tools: remove custom buffer-constructor lint rule
fee8a11 
This rule is no longer needed. ESLint's built in
no-buffer-constructor rule is enabled instead.

PR-URL: #25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
tools: enable no-buffer-constructor lint rule
7532d5c 
PR-URL: nodejs#25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
tools: remove custom buffer-constructor lint rule
1634dee 
This rule is no longer needed. ESLint's built in
no-buffer-constructor rule is enabled instead.

PR-URL: nodejs#25261
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cjihrig @nodejs-github-bot @addaleax @lpinca @richardlau @BridgeAR @Trott