New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused method declaration #25329

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@bnoordhuis
Copy link
Member

bnoordhuis commented Jan 3, 2019

No description provided.

@lpinca

lpinca approved these changes Jan 3, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@addaleax

This comment has been minimized.

@cjihrig

cjihrig approved these changes Jan 3, 2019

@fhinkel

fhinkel approved these changes Jan 5, 2019

@jasnell

jasnell approved these changes Jan 5, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 7, 2019

Re-run of failing node-test-commit-windows-fanned ✔️

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 7, 2019

Landed in 5717dc2.

@danbev danbev closed this Jan 7, 2019

danbev added a commit that referenced this pull request Jan 7, 2019

src: remove unused method declaration
PR-URL: #25329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Jan 9, 2019

src: remove unused method declaration
PR-URL: #25329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: remove unused method declaration
PR-URL: nodejs#25329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

src: remove unused method declaration
PR-URL: nodejs#25329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment