Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use lowercase for zlib #25371

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

Does anybody know why Travis CI doesn’t kick off? https://www.traviscistatus.com/ doesn’t seem to show anything. Did we disable it in some way?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

Does anybody know why Travis CI doesn’t kick off? https://www.traviscistatus.com/ doesn’t seem to show anything. Did we disable it in some way?

Looks like it stopped working about 7 hours ago, if that gives anyone any ideas.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

I’ve (re-?)enabled “Build pushed branches” and “Build pushed pull requests” in https://travis-ci.com/nodejs/node/settings, maybe that’s it. I’d be surprised if one of us had disabled these without telling anybody, though.

@Trott Trott added the author ready label Jan 7, 2019

@watilde
watilde approved these changes Jan 7, 2019
@jasnell
jasnell approved these changes Jan 7, 2019
@cjihrig
cjihrig approved these changes Jan 7, 2019
@lpinca
lpinca approved these changes Jan 7, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2019

Landed in 005363a

@Trott Trott closed this Jan 8, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 8, 2019
doc: use lowercase for zlib
PR-URL: nodejs#25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
doc: use lowercase for zlib
PR-URL: #25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: use lowercase for zlib
PR-URL: nodejs#25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: use lowercase for zlib
PR-URL: #25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: use lowercase for zlib
PR-URL: #25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: use lowercase for zlib
PR-URL: #25371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@sam-github sam-github deleted the Trott-patch-1 branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.