New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage of native crypto code #25400

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@tniessen
Copy link
Member

tniessen commented Jan 8, 2019

These error conditions are currently not being tested:

  • Creating a cipher with an invalid algorithm.
  • Creating a cipher with an invalid key length.
  • Creating an HMAC with an invalid algorithm.
  • Signing with an invalid algorithm.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added the crypto label Jan 8, 2019

@cjihrig

cjihrig approved these changes Jan 8, 2019

@lpinca

lpinca approved these changes Jan 8, 2019

@danbev

This comment has been minimized.

@jasnell

jasnell approved these changes Jan 9, 2019

@tniessen

This comment has been minimized.

Copy link
Member

tniessen commented Jan 9, 2019

tniessen added a commit to tniessen/node that referenced this pull request Jan 11, 2019

test: improve test coverage of native crypto code
PR-URL: nodejs#25400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen

This comment has been minimized.

Copy link
Member

tniessen commented Jan 11, 2019

Landed in 7710235, thanks for reviewing!

@tniessen tniessen closed this Jan 11, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019

test: improve test coverage of native crypto code
PR-URL: #25400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

test: improve test coverage of native crypto code
PR-URL: nodejs#25400
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment