test,worker_threads: simplify common.isMainThread #25426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed.
eugeneo
approved these changes
Jan 10, 2019
BridgeAR
approved these changes
Jan 10, 2019
|
Is there a case for removing this from |
@richardlau Yes, probably, but that will be a larger change with more churn that will be more likely to have merge conflicts on backporting etc. So I was thinking: Do this narrower change first. |
richardlau
approved these changes
Jan 10, 2019
cjihrig
approved these changes
Jan 10, 2019
Trott
added
the
author ready
|
Landed in 9e62bb5 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 12, 2019
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: nodejs#25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: #25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: nodejs#25426 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
worker_threadsdo not require a flag, the logic aroundloading
isMainThreadcan be removed.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes