Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,worker_threads: simplify common.isMainThread #25426

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 9, 2019

Now that worker_threads do not require a flag, the logic around
loading isMainThread can be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test,worker_threads: simplify common.isMainThread
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@richardlau

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Is there a case for removing this from common entirely now and directly calling require('worker_threads').isMainThread from the tests?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

Is there a case for removing this from common entirely now and directly calling require('worker_threads').isMainThread from the tests?

@richardlau Yes, probably, but that will be a larger change with more churn that will be more likely to have merge conflicts on backporting etc. So I was thinking: Do this narrower change first.

@Trott Trott added the author ready label Jan 11, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

Landed in 9e62bb5

@Trott Trott closed this Jan 12, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2019
test,worker: simplify common.isMainThread
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: nodejs#25426
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
test,worker: simplify common.isMainThread
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: #25426
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
test,worker: simplify common.isMainThread
Now that `worker_threads` do not require a flag, the logic around
loading `isMainThread` can be removed.

PR-URL: nodejs#25426
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.