Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set `-blibpath:` for AIX #25447

Closed
wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

commented Jan 11, 2019

#17604 refactored the gyp files
so that -blibpath: on AIX was only set if node_shared=="true".
Restore the setting for non-shared builds.

Fixes: #25444

cc @nodejs/build-files @nodejs/platform-aix

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444
@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

Locally built:

bash-4.4$ dump -X64 -H out/Release/node

out/Release/node:

                        ***Loader Section***
                      Loader Header Information
VERSION#         #SYMtableENT     #RELOCent        LENidSTR
0x00000001       0x0000c49b       0x00027893       0x000000a4

#IMPfilID        OFFidSTR         LENstrTBL        OFFstrTBL
0x00000006       0x0039f7f0       0x0033a49e       0x0039f894


                        ***Import File Strings***
INDEX  PATH                          BASE                MEMBER
0      /usr/lib:/lib:/opt/freeware/lib/pthread/ppc64
1                                    libperfstat.a       shr_64.o
2                                    libstdc++.a         libstdc++.so.6
3                                    libgcc_s.a          shr.o
4                                    libpthreads.a       shr_xpg5_64.o
5                                    libc.a              shr_64.o
bash-4.4$
@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

@richardlau richardlau added the aix label Jan 11, 2019

@mhdawson
Copy link
Member

left a comment

I'd like this not to land until the discussion on whether its the right thing to do completes.

@mhdawson
Copy link
Member

left a comment

LGTM. Ok I see this actually fixes a regression and it was that way before assuming CI passes of course.

@mhdawson

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@richardlau did you check that the fix that caused the regression was backported to 6.x and 8.x ?

@mhdawson

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

I see it was backported to 6.x and 8.x so never mind.

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

common.gypi Show resolved Hide resolved
@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Landed in bd8d682

@addaleax addaleax closed this Jan 14, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau added a commit to richardlau/node-1 that referenced this pull request Jan 15, 2019
build: set `-blibpath:` for AIX
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#25521
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Backport to v8.x-staging: #25521 (as requested).

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
build: set `-blibpath:` for AIX
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Feb 13, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs added a commit that referenced this pull request Feb 19, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs added a commit that referenced this pull request Feb 20, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 6, 2019
build: set `-blibpath:` for AIX
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#25521
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@richardlau richardlau referenced this pull request Mar 6, 2019
2 of 2 tasks complete
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 6, 2019
build: set `-blibpath:` for AIX
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#26478
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 12, 2019
build: set `-blibpath:` for AIX
nodejs#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: nodejs#25444

Backport-PR-URL: nodejs#26478
PR-URL: nodejs#25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs added a commit that referenced this pull request Mar 15, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #26478
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs referenced this pull request Mar 15, 2019
BethGriggs added a commit that referenced this pull request Mar 19, 2019
build: set `-blibpath:` for AIX
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #25521
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.