New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make mkssldef.py Python 3 compatible #25584

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@thefourtheye
Copy link
Contributor

thefourtheye commented Jan 19, 2019

This patch replaces the usage of map in such a way that it will be
compatible with Python 3.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss

tools: make mkssldef.py Python 3 compatible
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.
@refack

refack approved these changes Jan 19, 2019

@refack refack added the python label Jan 19, 2019

@bnoordhuis
Copy link
Member

bnoordhuis left a comment

Left a comment but LGTM either way.

exported = []

for filename in filenames:
for line in open(filename).readlines():
name, _, _, meta, _ = re.split('\s+', line)
if any(map(lambda p: p.match(name), excludes)): continue
if any([p.match(name) for p in excludes]): continue

This comment has been minimized.

@bnoordhuis

bnoordhuis Jan 21, 2019

Member

You don't need the square brackets here, any() accepts a generator.

This comment has been minimized.

@thefourtheye

thefourtheye Jan 22, 2019

Author Contributor

Changed it to a generator now.

@addaleax

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 28, 2019

Re-run of failing node-test-commit-windows-fanned ✔️

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 28, 2019

Landed in 4814987.

@danbev danbev closed this Jan 28, 2019

danbev added a commit that referenced this pull request Jan 28, 2019

tools: make mkssldef.py Python 3 compatible
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@thefourtheye thefourtheye deleted the thefourtheye:make-mkssldef.py-python3-compatible branch Jan 28, 2019

addaleax added a commit that referenced this pull request Jan 28, 2019

tools: make mkssldef.py Python 3 compatible
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment