src: refactor to nullptr #25888
Closed
src: refactor to nullptr #25888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
gengjiawen
force-pushed
the
cpp_use_nullptr
branch
from
60864d5
to
082db98
Compare
|
Is there easy way I can use to do cpplint on windows ? Looks |
|
Found |
Signed-off-by: gengjiawen <technicalcute@gmail.com>
gengjiawen
force-pushed
the
cpp_use_nullptr
branch
from
082db98
to
59b5b86
Compare
|
@addaleax Can you review this pr ? Thanks. |
addaleax
approved these changes
Feb 4, 2019
cjihrig
approved these changes
Feb 4, 2019
jasnell
approved these changes
Feb 6, 2019
refack
approved these changes
Feb 6, 2019
| @@ -562,13 +562,15 @@ extern "C" NODE_EXTERN void node_module_register(void* mod); | |||
| /* Called after the event loop exits but before the VM is disposed. | |||
| * Callbacks are run in reverse order of registration, i.e. newest first. | |||
| */ | |||
| NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = 0); | |||
| NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = nullptr); | |||
There was a problem hiding this comment.
Anyone know is this has any chance of effecting the ecosystem?
There was a problem hiding this comment.
We already use nullptr elsewhere in this file, so I think this should be okay.
addaleax
added
the
author ready
|
Landed in abba102. |
danbev
pushed a commit
that referenced
this pull request
Feb 7, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 0 with nullptr in multi places for clarity.
make -j4 test(UNIX), orvcbuild test(Windows) passes