-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor to nullptr #25888
src: refactor to nullptr #25888
Conversation
60864d5
to
082db98
Compare
Is there easy way I can use to do cpplint on windows ? Looks |
Found |
Signed-off-by: gengjiawen <technicalcute@gmail.com>
082db98
to
59b5b86
Compare
@addaleax Can you review this pr ? Thanks. |
@@ -562,13 +562,15 @@ extern "C" NODE_EXTERN void node_module_register(void* mod); | |||
/* Called after the event loop exits but before the VM is disposed. | |||
* Callbacks are run in reverse order of registration, i.e. newest first. | |||
*/ | |||
NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = 0); | |||
NODE_EXTERN void AtExit(void (*cb)(void* arg), void* arg = nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone know is this has any chance of effecting the ecosystem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already use nullptr
elsewhere in this file, so I think this should be okay.
Landed in abba102. |
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25888 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Replace 0 with nullptr in multi places for clarity.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes