Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.10.0 proposal #26098

Merged
merged 223 commits into from Feb 14, 2019

Conversation

@targos
Copy link
Member

commented Feb 14, 2019

2019-02-14, Version 11.10.0 (Current), @targos

Notable Changes

TODO

Commits

  • [ccf60bbad2] - assert: add internal assert.fail() (Rich Trott) #26047
  • [0b4055e616] - assert: create internal/assert micro-module (Rich Trott) #25956
  • [37d207cc0c] - assert: refactor internal assert.js (Rich Trott) #25956
  • [2b1f88185f] - benchmark: remove unreachable return (ZYSzys) #25883
  • [c4d16e80b7] - benchmark: refactor for consistent style (Rich Trott) #25944
  • [c4e2bbbcab] - benchmark: use consistent coding style in assert/* (Rich Trott) #25865
  • [18b344c0d2] - benchmark: refactor benchmark/common.js (Rich Trott) #25805
  • [40398fd07a] - benchmark: refactor _http-benchmarkers.js (Rich Trott) #25803
  • [d5d163d8b9] - build: export deprecated OpenSSL symbols on Windows (Richard Lau) #25991
  • [197efb7f84] - child_process: close pipe ends that are re-piped (Gireesh Punathil) #21209
  • [f87352366a] - cluster: migrate round_robin_handle to internal assert (Rich Trott) #26047
  • [8c9800ce27] - crypto: include 'Buffer' in error output of Hash.update method (Amit Zur) #25533
  • [baa0865886] - crypto: don't crash X509ToObject on error (David Benjamin) #25717
  • [3e010aff83] - crypto: fix malloc mixing in X509ToObject (David Benjamin) #25717
  • [da46be2542] - crypto: fix public key encoding name in comment (David Benjamin) #25736
  • [8b5a2c4f61] - deps: upgrade to libuv 1.26.0 (cjihrig) #26037
  • [1c5fbeab34] - deps: upgrade npm to 6.7.0 (Kat Marchán) #25804
  • [3f8c22b4cb] - deps: update llhttp to 1.1.1 (Fedor Indutny) #25753
  • [823fd5b493] - (SEMVER-MINOR) deps: float fix for building HdrHistogram on Win x86 (jasnell) #25378
  • [c01bbc5258] - deps: update acorn to 6.0.7 (Michaël Zasso) #25844
  • [a6c8e40655] - deps: patch to fix *.onion MX query on c-ares (XadillaX) #25840
  • [8b71464711] - deps: remove OpenSSL git and travis configuration (Sam Roberts) #25689
  • [673e434714] - deps: v8, cherry-pick 9365d09, aac2f8c, 47d34a3 (Benjamin Coe) #25429
  • [411f6fe832] - deps: cherry-pick c736883 from upstream V8 (Yang Guo)
  • [4a254a6ce4] - doc: edit N-API introductory material in Collaborator Guide (Rich Trott) #26051
  • [44fc2f6094] - doc: clarify effect of stream.destroy() on write() (Sam Roberts) #25973
  • [21e6d353af] - doc: renamed remote's name (Thang Tran) #26050
  • [e629afa6ae] - doc: fix minor typo in dgram.md (Daniel Bevenius) #26055
  • [663b6251a0] - doc: fix some nits in perf_hooks (Vse Mozhet Byt) #26022
  • [9420a737fe] - doc: edit process.report related documentation (cjihrig) #25983
  • [eb4b5ea233] - doc: clarify http timeouts (Andrew Moss) #25748
  • [a225f99ea8] - doc: revise Introducing New Modules (Rich Trott) #25975
  • [f516f68032] - doc: add a sentence about REPLACEME in code changes (Lance Ball) #25961
  • [3b74cc6c26] - doc: revise Collaborator Guide on reverting (Rich Trott) #25942
  • [353de0f752] - doc: fix err_synthetic issue on v11.x (sreepurnajasti) #25770
  • [cc4ae20d20] - doc: improve doc on unintended breaking changes (Rich Trott) #25887
  • [1f6acbb279] - doc: document os.userInfo() throwing SystemError (Raido Kuli) #25724
  • [699d161f9e] - doc: fix machine field in example report (cjihrig) #25855
  • [618f641271] - doc: remove redundant LTS/Current information in Collaborator Guide (Rich Trott) #25842
  • [7a1f166cfa] - doc: add documentation for request.path (Kei Ito) #25788
  • [f5db5090bc] - doc: remove outdated COLLABORATOR_GUIDE sentence about breaking changes (Rich Trott) #25780
  • [accb8aec35] - doc: revise inspect security info in cli.md (Rich Trott) #25779
  • [fd98d62909] - doc: revise style guide (Rich Trott) #25778
  • [60c5099f4b] - domain: avoid circular memory references (Anna Henningsen) #25993
  • [2b48a381b9] - fs: remove redundant callback check (ZYSzys) #25160
  • [29c195e17f] - fs: remove useless internalFS (ZYSzys) #25161
  • [51982978eb] - http: improve performance for incoming headers (Weijia Wang) #26041
  • [90c9f1d323] - http: reduce multiple output arrays into one (Weijia Wang) #26004
  • [a5247cc180] - (SEMVER-MINOR) http: makes response.writeHead return the response (Mark S. Everitt) #25974
  • [b7fb49e70a] - http: remove redundant call to socket.setTimeout() (Luigi Pinca) #25928
  • [25c19eb1d8] - http: make timeout event work with agent timeout (Luigi Pinca) #25488
  • [0899c8bb32] - http2: improve compat performance (Matteo Collina) #25567
  • [237b5e65e4] - (SEMVER-MINOR) http2: makes response.writeHead return the response (Mark S. Everitt) #25974
  • [6967407b19] - inspector, trace_events: make sure messages are sent on a main thread (Eugene Ostroukhov) #24814
  • [d02ad40d42] - inspector,vm: remove --eval wrapper (Anna Henningsen) #25832
  • [32e6bb32b2] - lib: merge 'undefined' into one 'break' branch (MaleDong) #26039
  • [b2b37c631a] - lib: simplify 'umask' (MaleDong) #26035
  • [b1a8927adc] - lib: fix the typo error (MaleDong) #26032
  • [d5f4a1f2ac] - lib: save a copy of Symbol in primordials (Joyee Cheung) #26033
  • [bd932a347e] - lib: move per_context.js under lib/internal/bootstrap (Joyee Cheung) #26033
  • [f40e0fcdcb] - lib: replace 'assert' with 'internal/assert' for many built-ins (Rich Trott) #25956
  • [8ade433f51] - lib: move signal event handling into bootstrap/node.js (Joyee Cheung) #25859
  • [92ca50636c] - lib: save primordials during bootstrap and use it in builtins (Joyee Cheung) #25816
  • [1b8d2ca85f] - lib: remove dollar symbol for private function (MaleDong) #25590
  • [b06f2fafe7] - lib: use internal/options to query --abort-on-uncaught-exception (Joyee Cheung) #25862
  • [0b302e4520] - lib: fix a few minor issues flagged by lgtm (Robin Neatherway) #25873
  • [99bc0df74c] - lib: refactor ERR_SYNTHETIC (cjihrig) #25749
  • [1c6fadea31] - meta: clarify EoL platform support (João Reis) #25838
  • [03ffcf76b7] - n-api: finalize during second-pass callback (Gabriel Schulhof) #25992
  • [5f6a710d8d] - os,report: use UV_MAXHOSTNAMESIZE (cjihrig) #26038
  • [2cbb7a85db] - (SEMVER-MINOR) perf_hooks: implement histogram based api (James M Snell) #25378
  • [e81c6c81de] - perf_hooks: only enable GC tracking when it's requested (Joyee Cheung) #25853
  • [9d6291ad46] - process: refactor lib/internal/bootstrap/node.js (Joyee Cheung) #26033
  • [8d3eb47d48] - process: use primordials in bootstrap/node.js (Joyee Cheung) #26033
  • [85bc64a5c9] - process: document the bootstrap process in node.js (Joyee Cheung) #26033
  • [ae21fca36b] - process: normalize process.execPath in CreateProcessObject() (Joyee Cheung) #26002
  • [614bb9f3c8] - process: normalize process.argv before user code execution (Joyee Cheung) #26000
  • [9a7e883b83] - process: group main thread execution preparation code (Joyee Cheung) #26000
  • [d7bf070652] - process: move deprecation warning initialization into pre_execution.js (Joyee Cheung) #25825
  • [d7ed125fd1] - process: stub unsupported worker methods (cjihrig) #25587
  • [c8bf4327d8] - process: move process mutation into bootstrap/node.js (Joyee Cheung) #25821
  • [1d76ba1b3d] - (SEMVER-MINOR) process: expose process.features.inspector (Joyee Cheung) #25819
  • [e6a4fb6d01] - process: split execution into main scripts (Joyee Cheung) #25667
  • [f4cfbf4c9e] - process: move setup of process warnings into node.js (Anto Aravinth) #25263
  • [cc253b5f2d] - process: simplify report uncaught exception logic (cjihrig) #25744
  • [4c22d6eaa1] - (SEMVER-MINOR) repl: add repl.setupHistory for programmatic repl (Lance Ball) #25895
  • [2c737a89d5] - repl: remove obsolete buffer clearing (Ruben Bridgewater) #25731
  • [5aaeb01655] - repl: fix eval return value (Ruben Bridgewater) #25731
  • [e66cb58a9b] - repl: simplify and improve completion (Ruben Bridgewater) #25731
  • [dfd47aa1e8] - report: make more items programmatically accessible (Anna Henningsen) #26019
  • [88019b051c] - report: rename setDiagnosticReportOptions() (cjihrig) #25990
  • [c8ceece815] - report: refactor report option validation (cjihrig) #25990
  • [afb2d17c16] - report: use uv_getnameinfo() for socket endpoints (cjihrig) #25962
  • [3f400310bd] - report: widen scope of #ifndef (cjihrig) #25960
  • [8494a61d79] - report: remove unnecessary case block scopes (cjihrig) #25960
  • [7443288c68] - report: remove empty string stream insertion (cjihrig) #25960
  • [6c51ec3014] - report: include information about event loop itself (Anna Henningsen) #25906
  • [30a4e8900a] - report: print libuv handle addresses as hex (cjihrig) #25910
  • [6d39a54354] - report: use libuv calls for OS and machine info (cjihrig) #25900
  • [1007416596] - report: separate release metadata (Richard Lau) #25826
  • [b1e0c43abd] - report: disambiguate glibc versions (cjihrig) #25781
  • [f6c8820b46] - report: fix typo in error message (cjihrig) #25782
  • [d4631816ef] - report: use consistent format for dumpEventTime (Anna Henningsen) #25751
  • [cc22fd7be9] - report: split up osVersion and machine values (cjihrig) #25755
  • [f71d6762ca] - src: remove redundant cast in node_http2.h (gengjiawen) #25978
  • [adaa2ae70b] - src: add lock to inspector MainThreadHandle dtor (Anna Henningsen) #26010
  • [731c2731d2] - src: add WeakReference utility (Anna Henningsen) #25993
  • [7ab34ae421] - src: remove unused method in class Http2Stream (gengjiawen) #25979
  • [d7ae1054ef] - src: remove redundant cast in node_file.cc (gengjiawen) #25977
  • [6c6e678eaa] - src: remove unused class in node_errors.h (gengjiawen) #25980
  • [24d9e9c8b6] - src: remove redundant void (gengjiawen) #26003
  • [5de103430f] - src: use NULL check macros to check nullptr (ZYSzys) #25916
  • [c47eb932bc] - src: move process.reallyExit impl into node_process_methods.cc (Joyee Cheung) #25860
  • [01bb7b7559] - src: split ownsProcessState off isMainThread (Anna Henningsen) #25881
  • [fd6ce533aa] - src: remove main_isolate (Anna Henningsen) #25823
  • [b72ec23201] - src: move public C++ APIs into src/api/*.cc (Joyee Cheung) #25541
  • [0a154ff7ad] - src: move v8_platform implementation into node_v8_platform-inl.h (Joyee Cheung) #25541
  • [d342707fa7] - src: remove unused internalBinding('config') properties (Joyee Cheung) #25463
  • [756558617e] - src: pass cli options to bootstrap/loaders.js lexically (Joyee Cheung) #25463
  • [85d5f67efe] - src: fix return type in Hash (gengjiawen) #25936
  • [779a5773cf] - src: refactor macro to std::min in node_buffer.cc (gengjiawen) #25919
  • [76687dedce] - src: remove unused variable (cjihrig) #25481
  • [b280d90279] - src: simplify NativeModule caching and remove redundant data (Joyee Cheung) #25352
  • [469cdacd59] - src: pass along errors from StreamBase req obj creations (Anna Henningsen) #25822
  • [d6f3b8785f] - src: pass along errors from fs object creations (Anna Henningsen) #25822
  • [0672c24dc3] - src: pass along errors from http2 object creation (Anna Henningsen) #25822
  • [e3fd7520d0] - src: pass along errors from tls object creation (Anna Henningsen) #25822
  • [e0af205c98] - src: nullcheck on trace controller (Gireesh Punathil) #25943
  • [c72c4b041d] - src: allow --perf-prof-unwinding-info in NODE_OPTIONS (Tom Gallacher) #25565
  • [e6a2548807] - src: allow --perf-basic-prof-only-functions in NODE_OPTIONS (Tom Gallacher) #25565
  • [7cf484c656] - src: refactor SSLError case statement (Sam Roberts) #25861
  • [55a313bb31] - src: make watchdog async callback a lambda (Gireesh Punathil) #25945
  • [de9f37d314] - src: make deleted function public in agent.h (gengjiawen) #25909
  • [620d429343] - src: use bool instead of integer literal in connection_wrap.cc (gengjiawen) #25923
  • [8cedfb8196] - src: refactor to nullptr in cpp code (gengjiawen) #25888
  • [f5d50342b0] - src: clean unused code in agent.h (gengjiawen) #25914
  • [2d575044ff] - src: fix compiler warnings in node_buffer.cc (Daniel Bevenius) #25665
  • [015ed0b1d7] - src: remove redundant method in node_worker.h (gengjiawen) #25849
  • [44655e93dd] - src: delete unreachable code in node_perf.h (gengjiawen) #25850
  • [5a66e380ff] - src: fix data type in node_crypto.cc (gengjiawen) #25889
  • [d4c4f77d31] - src: const_cast is necessary for 1.1.1, not 0.9.7 (Sam Roberts) #25861
  • [b5a8376ffe] - src: organize TLSWrap declarations by parent (Sam Roberts) #25861
  • [0772ce35fb] - src: remove unused TLWrap::EnableTrace() (Sam Roberts) #25861
  • [703549665e] - src: add PrintLibuvHandleInformation debug helper (Anna Henningsen) #25905
  • [2e80b912ef] - src: use visibility("default") exports on POSIX (Jeremy Apthorp) #25893
  • [e28d891788] - src: fix race condition in \~NodeTraceBuffer (Anna Henningsen) #25896
  • [bd771d90fd] - src: remove unimplemented method in node_http2.h (gengjiawen) #25732
  • [00f8e86702] - src: use nullptr in node_buffer.cc (gengjiawen) #25820
  • [84358b5010] - src: handle errors while printing error objects (Anna Henningsen) #25834
  • [f027290542] - src: use struct as arguments to node::Assert (Anna Henningsen) #25869
  • [8a8c17880e] - src: remove unused AsyncResource constructor in node.h (gengjiawen) #25793
  • [7556994d83] - src: remove unused method in js_stream.h (gengjiawen) #25790
  • [882902c672] - src: pass along errors from PromiseWrap instantiation (Anna Henningsen) #25837
  • [998cea567f] - src: workaround MSVC compiler bug (Refael Ackermann) #25596
  • [b779c072d0] - src: make StreamPipe::Unpipe() more resilient (Anna Henningsen) #25716
  • [0b014d5299] - src: make deleted functions public in node.h (gengjiawen) #25764
  • [be499c3c7b] - src: simplify SlicedArguments (Anna Henningsen) #25745
  • [35454e0008] - src: fix indentation in a few node_http2 enums (Daniel Bevenius) #25761
  • [3f080d12f4] - src: add debug check for inspector uv_async_t (Anna Henningsen) #25777
  • [0949039d26] - src: add handle scope to OnFatalError() (Anna Henningsen) #25775
  • [d9c2690705] - src: turn ROUND_UP into an inline function (Anna Henningsen) #25743
  • [3cd134cec4] - src,lib: remove dead process.binding() code (Anna Henningsen) #25829
  • [cb86357d22] - test: replaced anonymous fn with arrow syntax (Pushkal B) #26029
  • [64cc234a84] - test: use emitter.listenerCount() in test-http-connect (Luigi Pinca) #26031
  • [6323a9fc57] - test: refactor two http client timeout tests (Luigi Pinca) #25473
  • [61330b2f84] - test: add assert test for position indicator (Rich Trott) #26024
  • [896962fd08] - test: add Worker + --prof regression test (Anna Henningsen) #26011
  • [3eb6f6130a] - test: capture stderr from child processes (Gireesh Punathil) #26007
  • [d123f944a2] - test: remove extraneous report validation argument (cjihrig) #25986
  • [de587bae8a] - test: refactor to block-scope (LakshmiSwethaG) #25532
  • [4dca3ab23d] - test: exit sequence sanity tests (Gireesh Punathil) #25085
  • [ef9139e5a0] - test: end tls gracefully, rather than destroy (Sam Roberts) #25508
  • [7e9f5ea295] - test: pin regression test for #8074 to TLS 1.2 (Sam Roberts) #25508
  • [1b9a608dca] - test: refactor test-http-agent-timeout-option (Luigi Pinca) #25886
  • [c457d007cd] - test: clarify confusion over "client" in comment (Sam Roberts) #25508
  • [1be867685c] - test: use mustCall(), not global state checks (Sam Roberts) #25508
  • [50d2c8e945] - test: use common.mustCall(), and log the events (Sam Roberts) #25508
  • [1b542e8ba0] - test: use mustCall in ephemeralkeyinfo test (Sam Roberts) #25508
  • [898cf782f8] - test: send a bad record only after connection done (Sam Roberts) #25508
  • [ace267b21c] - test: do not race connection and rejection (Sam Roberts) #25508
  • [639dc07ca0] - test: do not assume tls handshake order (Sam Roberts) #25508
  • [cc6b30f4b7] - test: do not assume server gets secure connection (Sam Roberts) #25508
  • [c17a37d95a] - test: wait for TCP connect, not TLS handshake (Sam Roberts) #25508
  • [1f8991fae6] - test: add util.isDeepStrictEqual edge case tests (Rich Trott) #25932
  • [baa10aeb75] - test: add BigInt test for isDeepStrictEqual (Rich Trott) #25932
  • [c866b52942] - test: remove obsolete code (Ruben Bridgewater) #25731
  • [ee3165d6e7] - test: relax expectations in test-icu-transcode (Yang Guo) #25866
  • [025a7c3e31] - test: do not fail SLOW tests if they are not slow (Yang Guo) #25868
  • [059d30e369] - test: add hasCrypto to worker-cleanexit-with-moduleload (Daniel Bevenius) #25811
  • [7cb943937f] - test: refactor test-http-agent-timeout-option (Luigi Pinca) #25854
  • [cdf3e84804] - test: exclude additional test for coverage (Michael Dawson) #25833
  • [704a440d52] - test: allow coverage threshold to be enforced (Benjamin Coe) #25675
  • [5bffcf6246] - test: run html/webappapis/timers WPT (Joyee Cheung) #25618
  • [579220815a] - test: pull html/webappapis/timers WPT (Joyee Cheung) #25618
  • [d683da7ffa] - test, tools: suppress addon function cast warnings (Daniel Bevenius) #25663
  • [2009f18064] - test,tracing: use close event to wait for stdio (Anna Henningsen) #25894
  • [8495a788c6] - tls: renegotiate should take care of its own state (Sam Roberts) #25997
  • [fb83f842a8] - tls: in-line comments and other cleanups (Sam Roberts) #25861
  • [4d0b56f3f7] - tls: don't shadow the tls global with a local (Sam Roberts) #25861
  • [7656d58eed] - (SEMVER-MINOR) tls: introduce client 'session' event (Sam Roberts) #25831
  • [6ca8d26020] - tools: apply more stringent lint rules for benchmark code (Rich Trott) #25944
  • [c55d662bd1] - tools: replace deprecated ESLint configuration (Rich Trott) #25877
  • [e13c1850d2] - tools: update ESLint to 5.13.0 (Rich Trott) #25877
  • [8d14870b15] - tools: update dmn in update-estlint.sh (Rich Trott) #25877
  • [988c7141d4] - tools: improve prerequisites for test-all-suites (Rich Trott) #25892
  • [f395728b32] - tools: exclude benchmark code from coverage report (Rich Trott) #25841
  • [9d2ea1802b] - tools: add test-all-suites to Makefile (Rich Trott) #25799
  • [9f1bcd44df] - tools: make test.py Python 3 compatible (Sakthipriyan Vairamani (thefourtheye)) #25767
  • [454278a701] - tools: refloat Node.js patches to cpplint.py (Refael Ackermann) #25771
  • [b9289f41af] - tools: bump cpplint.py to 3d8f6f876d (Refael Ackermann) #25771
  • [9c9aefe2a0] - worker: set stack size for worker threads (Anna Henningsen) #26049
  • [23868ba45e] - worker: keep stdio after exit (Anna Henningsen) #26017
  • [6c1e92817f] - worker: set up child Isolate inside Worker thread (Anna Henningsen) #26011
  • [1764aae193] - worker: pre-allocate thread id (Anna Henningsen) #26011
  • [f63817fd38] - worker: refactor thread id management (Anna Henningsen) #25796
  • [8db6b8a95a] - worker: move worker thread setup code into the main script (Joyee Cheung) #25667
  • [5d2e064973] - worker: no throw on property access/postMessage after termination (Christopher Jeffrey) #25871
  • [508a2e7f0f] - worker: use correct ctor for error serialization (Anna Henningsen) #25951
  • [52d4b7a928] - worker: remove undocumented .onclose property (Rich Trott) #25904
  • [e70aa30ebd] - worker: add mutex lock to MessagePort ctor (Anna Henningsen) #25911
  • [55c270253b] - worker: throw for duplicates in transfer list (Anna Henningsen) #25815
  • [c959d60242] - worker,etw: only enable ETW on the main thread (Anna Henningsen) #25907

eugeneo and others added some commits Dec 3, 2018

inspector, trace_events: make sure messages are sent on a main thread
Fixes: #23185
PR-URL: #24814
Reviewed-By: James M Snell <jasnell@gmail.com>
lib: refactor ERR_SYNTHETIC
- Tidy up description in docs.
- Remove a second definition in the docs.
- Remove unused string input parameter.
- Remove duplicate "JavaScript Callstack" in error messages.

PR-URL: #25749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
report: split up osVersion and machine values
Prior to this commit, on non-Windows platforms, the "osVersion"
value was prepended to the "machine" value.

PR-URL: #25755
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
src: turn ROUND_UP into an inline function
PR-URL: #25743
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
report: use consistent format for dumpEventTime
Use the same JS-compatible format on both POSIX and Windows.

PR-URL: #25751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
src: add handle scope to `OnFatalError()`
For the report generation, we use `Environment::GetCurrent(isolate)`
which uses `isolate->GetCurrentContext()` under the hood, thus
allocates a handle. Without a `HandleScope`, this is invalid.

This might not strictly be allowed inside of `OnFatalError()`,
but it won’t make anything worse either.

PR-URL: #25775
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
src: add debug check for inspector uv_async_t
Add a check to make sure start_io_thread_async is not
accidentally re-used or used when uninitialized.
(This is a bit of an odd check imo, but it helped me figure
out a real issue and it might do so again, so… why not?)

PR-URL: #25777
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
src: fix indentation in a few node_http2 enums
PR-URL: #25761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
src: simplify SlicedArguments
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`.

PR-URL: #25745
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tools: bump cpplint.py to 3d8f6f876d
PR-URL: #25771
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
tools: refloat Node.js patches to cpplint.py
* Preserve 3 node-core checks
* Preserve patch to `FileInfo.RepositoryName`
* Remove TAP to logfile (unused)

PR-URL: #25771
Fixes: #25760
Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
process: simplify report uncaught exception logic
This commit combines two if statements into a single if
statement. Another if statement is replaced with a ternary.

PR-URL: #25744
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
doc: revise style guide
Use italics for words-as-words within style guide. Other minor
improvements.

PR-URL: #25778
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: revise inspect security info in cli.md
Revise inspect security information in cli.md.

* Reword sentence for brevity.
* Use bulleted list for clarity of options.
* Eliminate personal pronoun (_you_) per style guide.

PR-URL: #25779
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
doc: remove outdated COLLABORATOR_GUIDE sentence about breaking changes
The TSC has delegated authority over LTS and Current branches to the
Release WG. Remove the bullet point about TSC having authority to
determine that a breaking change is necessary on LTS and Current release
branches. Retaining that authority would require de-chartering the
Release WG.

Fixes: nodejs/TSC#660

PR-URL: #25780
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
src: make `StreamPipe::Unpipe()` more resilient
Clean up `StreamPipe::Unpipe()` to be more resilient against
unexpected exceptions, in particular while executing its
`MakeCallback()` line (which can fail in the presence of
termination exceptions), and clean up the getter/setter part
of the code to match that pattern as well (even though it should
not fail as part of regular operations).

PR-URL: #25716
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
src: make deleted functions public in node.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25764
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
http: make timeout event work with agent timeout
The `'timeout'` event is currently not emitted on the `ClientRequest`
instance when the socket timeout expires if only the `timeout` option
of the agent is set. This happens because, under these circumstances,
`listenSocketTimeout()` is not called.

This commit fixes the issue by calling it also when only the agent
`timeout` option is set.

PR-URL: #25488
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: pull html/webappapis/timers WPT
Using

```
git node wpt html/webappapis/timers
```

PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
test: run html/webappapis/timers WPT
PR-URL: #25618
Reviewed-By: James M Snell <jasnell@gmail.com>
report: fix typo in error message
PR-URL: #25782
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
report: disambiguate glibc versions
- Give the glibc version entries more specific names.
- Group all of the glibc version reporting together.

PR-URL: #25781
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
src: workaround MSVC compiler bug
PR-URL: #25596
Fixes: #25593
Refs: https://developercommunity.visualstudio.com/content/problem/432157/dynamic-initializers-out-of-order.html
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
doc: add documentation for request.path
The field has been added in v0.4.0.

PR-URL: #25788
Refs: b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814
Refs: https://github.com/nodejs/node/blob/380929ec0c4c4004b522bed5e3800ebce2b68bfd/test/parallel/test-http-client-defaults.js
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
benchmark: refactor _http-benchmarkers.js
Refactor _http-benchmarkers.js:

* The file used a mixture of inline callbacks with the `function`
  keyword and arrow functions. Use arrow functions for consistency.
* The file used a mixture of trailing commas and no trailing commas. Use
  trailing commas for consistency.

PR-URL: #25803
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
benchmark: refactor benchmark/common.js
Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.

PR-URL: #25805
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
crypto: fix public key encoding name in comment
PKCS#8 describes an encoding for private keys, not public keys. Using
the name as a format usually refers to the PrivateKeyInfo structure it
defines. (Or sometimes the EncryptedPrivateKeyInfo variant or the
little-used OneAsymmetricKey extension defined in RFC 5958.) None of
these structures can hold public keys to begin with.

d2i_PUBKEY actually parses the public key analogous format defined in
X.509, SubjectPublicKeyInfo. This function already uses "X.509" to refer
to an entire certificate, so say SubjectPublicKeyInfo in the comment.

(The abbreviation SPKI sometimes refers to SubjectPublicKeyInfo, e.g. in
RFC 7469, but it can also an alternate S-expression-based PKI to X.509,
Simple Public Key Infrastructure. To avoid confusion, stick with the
expanded name.)

PR-URL: #25736
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test, tools: suppress addon function cast warnings
Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:

make[1]: Entering directory '/node/test/addons/zlib-binding/build'
  CXX(target) Release/obj.target/binding/binding.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>,
          void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
					   ^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
 NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
 ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
'make -j8 test/addons/.buildstamp'.

PR-URL: #25663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
worker: throw for duplicates in transfer list
Throw a `DataCloneError` exception when encountering duplicate
`ArrayBuffer`s or `MessagePort`s in the transfer list.

Fixes: #25786

PR-URL: #25815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
deps: cherry-pick c736883 from upstream V8
Original commit message:

    Optionally use halfsiphash for integer hashing.

    Change-Id: Ibd14f7b3fe78635675c76ae864112e3a3a7bc701
    Reviewed-on: https://chromium-review.googlesource.com/c/1382463
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58674}

Refs: v8/v8@c736883

@targos targos force-pushed the v11.10.0-proposal branch from 431a867 to 5d4aad2 Feb 14, 2019

targos added a commit that referenced this pull request Feb 14, 2019

2018-02-14, Version 11.10.0 (Current)
Notable changes:

TODO

PR-URL: #26098
@mcollina
Copy link
Member

left a comment

LGTM

@gdams

gdams approved these changes Feb 14, 2019

@Leko

Leko approved these changes Feb 14, 2019

@targos targos added this to Releases in v11.x Feb 14, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

There are some weird errors in CITGM with eslint.
Here is a run on that module with Node 6,8,10 and 11: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/61/console

Edit: fails on earlier versions of Node.js as well.

2018-02-14, Version 11.10.0 (Current)
Notable changes:

deps:
  * Updated libuv to 1.26.0.
  * Updated npm to 6.7.0.
http, http2:
  * `response.writeHead` now returns the response object.
perf_hooks:
  * Implemented a histogram based API.
process:
  * Exposed `process.features.inspector`.
repl:
  * Added `repl.setupHistory` for programmatic repl.
tls:
  * Introduced client "session" event.

PR-URL: #26098

@targos targos force-pushed the v11.10.0-proposal branch from 5d4aad2 to 6e56771 Feb 14, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

I put the following notable changes:

deps:
  * Updated libuv to 1.26.0.
  * Updated npm to 6.7.0.
http, http2:
  * `response.writeHead` now returns the response object.
perf_hooks:
  * Implemented a histogram based API.
process:
  * Exposed `process.features.inspector`.
repl:
  * Added `repl.setupHistory` for programmatic repl.
tls:
  * Introduced client "session" event.

Release build: https://ci-release.nodejs.org/job/iojs+release/4221/

@targos targos merged commit 6e56771 into v11.x Feb 14, 2019

targos added a commit that referenced this pull request Feb 14, 2019

targos added a commit that referenced this pull request Feb 14, 2019

2018-02-14, Version 11.10.0 (Current)
Notable changes:

deps:
  * Updated libuv to 1.26.0.
  * Updated npm to 6.7.0.
http, http2:
  * `response.writeHead` now returns the response object.
perf_hooks:
  * Implemented a histogram based API.
process:
  * Exposed `process.features.inspector`.
repl:
  * Added `repl.setupHistory` for programmatic repl.
tls:
  * Introduced client "session" event.

PR-URL: #26098

@targos targos deleted the v11.10.0-proposal branch Feb 14, 2019

targos added a commit to nodejs/nodejs.org that referenced this pull request Feb 14, 2019

targos added a commit to nodejs/nodejs.org that referenced this pull request Feb 14, 2019

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.