Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: use libuv calls for OS and machine info #25900

Merged
merged 1 commit into from
Feb 5, 2019
Merged

report: use libuv calls for OS and machine info #25900

merged 1 commit into from
Feb 5, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 2, 2019

Replace platform specific code with libuv calls. Note that currently uv_os_uname() doesn't report the full product name on Windows. There is an open PR to libuv that would add that information. I'm not sure if anyone feels strongly about this landing before that libuv update. It doesn't matter to me, but see #25843.

Fixes: #25843

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2495/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 2, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 2, 2019
bnoordhuis
bnoordhuis approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

src/node_report.cc Show resolved Hide resolved
richardlau
richardlau reviewed Feb 3, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

References to Netapi32 dll/lib can (should?) be removed from node.gyp.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 5, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20574/

@cjihrig
report: use libuv calls for OS and machine info
9bbe29d 
PR-URL: nodejs#25900
Fixes: nodejs#25843
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit 9bbe29d into nodejs:master Feb 5, 2019
@cjihrig cjihrig deleted the report branch February 5, 2019 14:00
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@cjihrig @addaleax
report: use libuv calls for OS and machine info
6d39a54 
PR-URL: #25900
Fixes: #25843
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 11 won't run on Windows Nano Server
7 participants
@cjihrig @nodejs-github-bot @bnoordhuis @addaleax @gengjiawen @richardlau @MylesBorins