Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: use libuv calls for OS and machine info #25900

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Feb 2, 2019

Replace platform specific code with libuv calls. Note that currently uv_os_uname() doesn't report the full product name on Windows. There is an open PR to libuv that would add that information. I'm not sure if anyone feels strongly about this landing before that libuv update. It doesn't matter to me, but see #25843.

Fixes: #25843

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax addaleax added the report label Feb 2, 2019

@bnoordhuis
Copy link
Member

left a comment

LGTM % comment

src/node_report.cc Show resolved Hide resolved
@richardlau
Copy link
Member

left a comment

References to Netapi32 dll/lib can (should?) be removed from node.gyp.

@cjihrig cjihrig force-pushed the cjihrig:report branch from ac3fda9 to 82b51ad Feb 4, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

report: use libuv calls for OS and machine info
PR-URL: #25900
Fixes: #25843
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@cjihrig cjihrig force-pushed the cjihrig:report branch from 82b51ad to 9bbe29d Feb 5, 2019

@cjihrig cjihrig merged commit 9bbe29d into nodejs:master Feb 5, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:report branch Feb 5, 2019

addaleax added a commit that referenced this pull request Feb 6, 2019
report: use libuv calls for OS and machine info
PR-URL: #25900
Fixes: #25843
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.